Smalltalk › Squeak › Squeak - Dev

Revisiting the deprecation of #asMutator vs #asSimpleSetter in 5.3 (sorry)

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

24 messages Options

marcel.taeumel

Re: Revisiting the deprecation of #asMutator vs #asSimpleSetter in 5.3 (sorry)

Hi Chris!

> Another option is to use "browse revisions", then select the revision

> which un-deprecates it and select, "browse origin". Then you will

> have the version name which can be searched on the list. :)

Works like a charm. :-) Would be nice if you somehow show the repository description in the revisions browser. Then, users could inspect the list of repositories if some issue occurs.

Best,

Marcel

Am 13.04.2021 07:22:45 schrieb Chris Muller <[hidden email]>:

Another option is to use "browse revisions", then select the revision which un-deprecates it and select, "browse origin". Then you will have the version name which can be searched on the list. :)

On Mon, Apr 12, 2021 at 9:10 PM David T. Lewis <[hidden email]> wrote:
On Mon, Apr 12, 2021 at 09:11:54PM +0000, Thiede, Christoph wrote:
> Maybe just create a new version and add the pointer directly into the
> comment of #asMutator? This will be even more helpful for people who
> wonder "Should I use #asMutator or #asSimpleSetter"?
>
> I also wonder whether #asMutator deserves a #deprecate flag at least.
> Otherwise, we will have the situation of two ambiguous selectors without
> any recommendation, again.
>

Let's not over-engineer it. Just look at the method comment. Is anyone
ever going to use a method with a name like "asMutator" without first
looking at the method to see what it does? I certainly hope not :-)

Symbol>>asMutator
"Synonym for asSimpleSetter, retained for support of external packages such as Seaside"
^ self asSimpleSetter

Dave

marcel.taeumel

Re: Revisiting the deprecation of #asMutator vs #asSimpleSetter in 5.3 (sorry)

In reply to this post by David T. Lewis

Hi Dave,

you could just add another version. No need to modify dtl.1225 :-)

Best,

Marcel

Am 12.04.2021 22:56:16 schrieb David T. Lewis <[hidden email]>:
On Mon, Apr 12, 2021 at 08:43:45AM +0200, Marcel Taeumel wrote:
>
> > Am 12.04.2021 um 04:11 schrieb David T. Lewis :
> >
> >
> > On Sun, Apr 11, 2021 at 05:01:31PM +0200, Nicolas Cellier wrote:
> >> Hi all,
> >> it seems we have enough +1, let's just do it.
> >>
> >
> > Done.
>
> Hi Dave.
>
> Thanks. Maybe also add a pointer to the discussion on this list.
>

Hi Marcel,

Yes, I should have added a link to the discussion. I could save a
fixed System-dtl.1225 to trunk, although I am afraid it may cause
problems for the update stream for people who have already loaded
that version number with a different UUID in their trunk update.

If someone can confirm that it is safe to replace the existing
System-dtl.1225 with another one that differs only by commit comment
and UUID, then I'll copy it up to trunk. Otherwise I think I'll
play it safe and leave it alone.

Thanks,
Dave

David T. Lewis

Re: Revisiting the deprecation of #asMutator vs #asSimpleSetter in 5.3 (sorry)

On Wed, Apr 14, 2021 at 10:30:24AM +0200, Marcel Taeumel wrote:
> Hi Dave,
>
> you could just add another version. No need to modify dtl.1225 :-)
>

Sorry, too late to do that now. But in case future readers of this
list archive are interested, the discussion on squeak-dev is here:

http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-April/214699.html

The motivating issue for Seaside is:

https://github.com/SeasideSt/Seaside/issues/1195

Dave

> Best,
> Marcel
> Am 12.04.2021 22:56:16 schrieb David T. Lewis <[hidden email]>:
> On Mon, Apr 12, 2021 at 08:43:45AM +0200, Marcel Taeumel wrote:
> >
> > > Am 12.04.2021 um 04:11 schrieb David T. Lewis :
> > >
> > >
> > > On Sun, Apr 11, 2021 at 05:01:31PM +0200, Nicolas Cellier wrote:
> > >> Hi all,
> > >> it seems we have enough +1, let's just do it.
> > >>
> > >
> > > Done.
> >
> > Hi Dave.
> >
> > Thanks. Maybe also add a pointer to the discussion on this list.
> >
>
> Hi Marcel,
>
> Yes, I should have added a link to the discussion. I could save a
> fixed System-dtl.1225 to trunk, although I am afraid it may cause
> problems for the update stream for people who have already loaded
> that version number with a different UUID in their trunk update.
>
> If someone can confirm that it is safe to replace the existing
> System-dtl.1225 with another one that differs only by commit comment
> and UUID, then I'll copy it up to trunk. Otherwise I think I'll
> play it safe and leave it alone.
>
> Thanks,
> Dave
>
>

David T. Lewis

Re: Revisiting the deprecation of #asMutator vs #asSimpleSetter in 5.3 (sorry)

On Wed, Apr 14, 2021 at 10:31:28PM -0400, David T. Lewis wrote:

> On Wed, Apr 14, 2021 at 10:30:24AM +0200, Marcel Taeumel wrote:
> > Hi Dave,
> >
> > you could just add another version. No need to modify dtl.1225 :-)
> >
>
> Sorry, too late to do that now. But in case future readers of this
> list archive are interested, the discussion on squeak-dev is here:
>
> http://lists.squeakfoundation.org/pipermail/squeak-dev/2021-April/214699.html
>
> The motivating issue for Seaside is:
>
> https://github.com/SeasideSt/Seaside/issues/1195
>
> Dave
>

But of course adding this information to the current mail thread is
completely pointless, d'oh!

So I also added it to the "squeak-dev] The Trunk: System-dtl.1225.mcz"
thread to give people a better chance of finding it in the future.

Again, sorry for not putting this in the original commit message.

Dave