Smalltalk › Squeak › Squeak - Dev

Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

Squeak - Dev mailing list

Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

Hi folks,

Version: Squeak6.0alphaUpdate: 20010

Working through the Roassal3 tests

in RSAbstractAnimation>>loops: aNumber
self assert: aNumber >= 1 description: 'The number of times to repeat this animation'. <----test fails here.
loops := aNumber

aNumber is Infinity (inspecting displays a Boxed Float)

Poking around a bit...

(BoxedFloat64 infinity) >= 1 -> false

then....

(BoxedFloat64 infinity) < 1 ->true

Is this expected?

If so, suggestions on how I should I make the test reflect reality?

thx in advance.

codefrau

Re: Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

What does "BoxedFloat64 infinity print?

And what VM are you on? 32 or 64 bits?

FWIW, it works fine on this VM:

Open Smalltalk Cog[Spur] VM [CoInterpreterPrimitives VMMaker.oscog-nice.2715] 64 bit
Mac OS X built on Mar 3 2020 08:28:30 GMT Compiler: 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)
platform sources revision VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git
CoInterpreter VMMaker.oscog-nice.2715 uuid: 78e2f556-9829-42fe-963d-e19dfc43c0e9 Mar 3 2020
StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020

- Vanessa -

On Thu, Oct 22, 2020 at 7:51 AM gettimothy via Squeak-dev <[hidden email]> wrote:

Hi folks,

Version: Squeak6.0alphaUpdate: 20010

Working through the Roassal3 tests
in RSAbstractAnimation>>loops: aNumber
self assert: aNumber >= 1 description: 'The number of times to repeat this animation'. <----test fails here.
loops := aNumber
aNumber is Infinity (inspecting displays a Boxed Float)

Poking around a bit...

(BoxedFloat64 infinity) >= 1 -> false

then....

(BoxedFloat64 infinity) < 1 ->true

Is this expected?

If so, suggestions on how I should I make the test reflect reality?

thx in advance.

Tom Beckmann

Re: Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

In reply to this post by Squeak - Dev mailing list

Hi timothy,

here, too, I don't observe any issues. Is it possible that you loaded some Number/Math package from Pharo that could have introduced erroneous overrides?

All tests from Roassal3-Animation pass for me, except two that assume that `3 second` returns `0:00:03`, which it does in Pharo, while in Squeak it always returns `0:00:01`. Not sure which behavior I like more (I think I would personally prefer Squeak's behavior, iff it threw an error when I run `3 second` instead of silently discarding the two seconds). Regardless of that we should propose to change it to `#seconds`, as Roassal uses `#seconds` everywhere else in their code when referring to time spans >1 second.

Best,

Tom

On Thu, Oct 22, 2020 at 10:07 PM Vanessa Freudenberg <[hidden email]> wrote:

What does "BoxedFloat64 infinity print?

And what VM are you on? 32 or 64 bits?

FWIW, it works fine on this VM:

Open Smalltalk Cog[Spur] VM [CoInterpreterPrimitives VMMaker.oscog-nice.2715] 64 bit
Mac OS X built on Mar 3 2020 08:28:30 GMT Compiler: 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)
platform sources revision VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git
CoInterpreter VMMaker.oscog-nice.2715 uuid: 78e2f556-9829-42fe-963d-e19dfc43c0e9 Mar 3 2020
StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020

- Vanessa -

On Thu, Oct 22, 2020 at 7:51 AM gettimothy via Squeak-dev <[hidden email]> wrote:

Hi folks,

Version: Squeak6.0alphaUpdate: 20010

Working through the Roassal3 tests

in RSAbstractAnimation>>loops: aNumber

self assert: aNumber >= 1 description: 'The number of times to repeat this animation'. <----test fails here.

loops := aNumber

aNumber is Infinity (inspecting displays a Boxed Float)

Poking around a bit...

(BoxedFloat64 infinity) >= 1 -> false

then....

(BoxedFloat64 infinity) < 1 ->true

Is this expected?

If so, suggestions on how I should I make the test reflect reality?

thx in advance.

Squeak - Dev mailing list

Re: Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

I will check this first.

thx.

---- On Fri, 23 Oct 2020 01:42:52 -0400 Tom Beckmann <[hidden email]> wrote ----

Hi timothy,

here, too, I don't observe any issues. Is it possible that you loaded some Number/Math package from Pharo that could have introduced erroneous overrides?

All tests from Roassal3-Animation pass for me, except two that assume that `3 second` returns `0:00:03`, which it does in Pharo, while in Squeak it always returns `0:00:01`. Not sure which behavior I like more (I think I would personally prefer Squeak's behavior, iff it threw an error when I run `3 second` instead of silently discarding the two seconds). Regardless of that we should propose to change it to `#seconds`, as Roassal uses `#seconds` everywhere else in their code when referring to time spans >1 second.

Best,
Tom

On Thu, Oct 22, 2020 at 10:07 PM Vanessa Freudenberg <[hidden email]> wrote:
What does "BoxedFloat64 infinity print?

And what VM are you on? 32 or 64 bits?

FWIW, it works fine on this VM:

Open Smalltalk Cog[Spur] VM [CoInterpreterPrimitives VMMaker.oscog-nice.2715] 64 bit
Mac OS X built on Mar 3 2020 08:28:30 GMT Compiler: 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)
platform sources revision VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git
CoInterpreter VMMaker.oscog-nice.2715 uuid: 78e2f556-9829-42fe-963d-e19dfc43c0e9 Mar 3 2020
StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020

- Vanessa -

On Thu, Oct 22, 2020 at 7:51 AM gettimothy via Squeak-dev <[hidden email]> wrote:
Hi folks,

Version: Squeak6.0alphaUpdate: 20010

Working through the Roassal3 tests
in RSAbstractAnimation>>loops: aNumber
self assert: aNumber >= 1 description: 'The number of times to repeat this animation'. <----test fails here.
loops := aNumber
aNumber is Infinity (inspecting displays a Boxed Float)

Poking around a bit...

(BoxedFloat64 infinity) >= 1 -> false

then....

(BoxedFloat64 infinity) < 1 ->true

Is this expected?

If so, suggestions on how I should I make the test reflect reality?

thx in advance.

Squeak - Dev mailing list

Re: Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

In reply to this post by codefrau

Ok, what Tom said must have been the issue.

I Downloaded and configured a new linux image from http://files.squeak.org/trunk/Squeak6.0alpha-20010-64bit/

Name
Last Modified
Size
Type
Parent Directory/

-
Directory
Squeak6.0alpha-20010-64bit-202003021730-Linux.zip
2020-10-22 15:24
35.3M
File
Squeak6.0alpha-20010-64bit-202003021730-Windows.zip
2020-10-22 15:24
34.1M
File
Squeak6.0alpha-20010-64bit-202003021730-macOS.dmg
2020-10-22 15:24
29.4M
File
Squeak6.0alpha-20010-64bit-All-in-One.zip
2020-10-22 15:24
39.7M
File
Squeak6.0alpha-20010-64bit.zip
2020-10-22 15:24
19.1M
File

then ran:

BoxedFloat64 infinity Infinity

(BoxedFloat64 infinity) >= 1 true

(BoxedFloat64 infinity) < 1 false

Sorry for the noise.

---- On Thu, 22 Oct 2020 16:06:55 -0400 Vanessa Freudenberg <[hidden email]> wrote ----

What does "BoxedFloat64 infinity print?

And what VM are you on? 32 or 64 bits?

FWIW, it works fine on this VM:

Open Smalltalk Cog[Spur] VM [CoInterpreterPrimitives VMMaker.oscog-nice.2715] 64 bit
Mac OS X built on Mar 3 2020 08:28:30 GMT Compiler: 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)
platform sources revision VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git
CoInterpreter VMMaker.oscog-nice.2715 uuid: 78e2f556-9829-42fe-963d-e19dfc43c0e9 Mar 3 2020
StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020

- Vanessa -

On Thu, Oct 22, 2020 at 7:51 AM gettimothy via Squeak-dev <[hidden email]> wrote:
Hi folks,

Version: Squeak6.0alphaUpdate: 20010

Working through the Roassal3 tests
in RSAbstractAnimation>>loops: aNumber
self assert: aNumber >= 1 description: 'The number of times to repeat this animation'. <----test fails here.
loops := aNumber
aNumber is Infinity (inspecting displays a Boxed Float)

Poking around a bit...

(BoxedFloat64 infinity) >= 1 -> false

then....

(BoxedFloat64 infinity) < 1 ->true

Is this expected?

If so, suggestions on how I should I make the test reflect reality?

thx in advance.

Squeak - Dev mailing list

Re: Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

In reply to this post by Tom Beckmann

Hi Tom,

The problem has re-introduced itself during the Roassal3 installation process.

I will try to isolate the exact point.

BoxedFloat64 infinity Infinity

(BoxedFloat64 infinity) >= 1 false

(BoxedFloat64 infinity) < 1 true

cordially,

---- On Fri, 23 Oct 2020 01:42:52 -0400 Tom Beckmann <[hidden email]> wrote ----

Hi timothy,

here, too, I don't observe any issues. Is it possible that you loaded some Number/Math package from Pharo that could have introduced erroneous overrides?

All tests from Roassal3-Animation pass for me, except two that assume that `3 second` returns `0:00:03`, which it does in Pharo, while in Squeak it always returns `0:00:01`. Not sure which behavior I like more (I think I would personally prefer Squeak's behavior, iff it threw an error when I run `3 second` instead of silently discarding the two seconds). Regardless of that we should propose to change it to `#seconds`, as Roassal uses `#seconds` everywhere else in their code when referring to time spans >1 second.

Best,
Tom

On Thu, Oct 22, 2020 at 10:07 PM Vanessa Freudenberg <[hidden email]> wrote:
What does "BoxedFloat64 infinity print?

And what VM are you on? 32 or 64 bits?

FWIW, it works fine on this VM:

Open Smalltalk Cog[Spur] VM [CoInterpreterPrimitives VMMaker.oscog-nice.2715] 64 bit
Mac OS X built on Mar 3 2020 08:28:30 GMT Compiler: 4.2.1 Compatible Apple LLVM 8.1.0 (clang-802.0.42)
platform sources revision VM: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git Date: Mon Mar 2 18:30:55 2020 CommitHash: 6a0bc96 Plugins: 202003021730 https://github.com/OpenSmalltalk/opensmalltalk-vm.git
CoInterpreter VMMaker.oscog-nice.2715 uuid: 78e2f556-9829-42fe-963d-e19dfc43c0e9 Mar 3 2020
StackToRegisterMappingCogit VMMaker.oscog-eem.2719 uuid: e40f3e94-3a54-411b-9613-5d19114ea131 Mar 3 2020

- Vanessa -

On Thu, Oct 22, 2020 at 7:51 AM gettimothy via Squeak-dev <[hidden email]> wrote:
Hi folks,

Version: Squeak6.0alphaUpdate: 20010

Working through the Roassal3 tests
in RSAbstractAnimation>>loops: aNumber
self assert: aNumber >= 1 description: 'The number of times to repeat this animation'. <----test fails here.
loops := aNumber
aNumber is Infinity (inspecting displays a Boxed Float)

Poking around a bit...

(BoxedFloat64 infinity) >= 1 -> false

then....

(BoxedFloat64 infinity) < 1 ->true

Is this expected?

If so, suggestions on how I should I make the test reflect reality?

thx in advance.

Squeak - Dev mailing list

Re: Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

In reply to this post by Tom Beckmann

Ok,

Something seriously weird here.

I start with the "prisitine" image where all those tests pass.

Well, I just reopened that image and now they fail.

I am running from the Squeak-Launcher.

I will first investigate the VM, then the Squeak Launcher.

It may be a while, I am battling the covid, so I am a bit weak.

timrowledge

Re: Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

> On 2020-10-23, at 6:12 AM, gettimothy via Squeak-dev <[hidden email]> wrote:
>
> It may be a while, I am battling the covid, so I am a bit weak.

Take care and look after your health first!

tim
--
tim Rowledge; [hidden email]; http://www.rowledge.org/tim
Oxymorons: Tight slacks

Christoph Thiede

Re: Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

> On 2020-10-23, at 6:12 AM, gettimothy via Squeak-dev <[hidden email]> wrote:

> It may be a while, I am battling the covid, so I am a bit weak.

Get well soon!

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von tim Rowledge <[hidden email]>
Gesendet: Freitag, 23. Oktober 2020 18:40:33
An: The general-purpose Squeak developers list
Betreff: Re: [squeak-dev] Roassal3 tests: (BoxedFloat64 infinity) >= 1 -> false

Carpe Squeak!