ScriptLoader time to die?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

ScriptLoader time to die?

Frank Shearar-3
Like tears in rain.

It doesn't seem to be used by anything, there's a comment in it
suggesting it be folded into ReleaseBuilder, ...

frank

Reply | Threaded
Open this post in threaded view
|

Re: ScriptLoader time to die?

Bert Freudenberg

On 2013-05-03, at 10:44, Frank Shearar <[hidden email]> wrote:

> Like tears in rain.
>
> It doesn't seem to be used by anything, there's a comment in it
> suggesting it be folded into ReleaseBuilder, ...


It was only used by the 3.9 release team. Not needed anymore.

Another 45Deprecated candidate.

- Bert -



Reply | Threaded
Open this post in threaded view
|

Re: ScriptLoader time to die?

Nicolas Cellier
+1


2013/5/3 Bert Freudenberg <[hidden email]>

On 2013-05-03, at 10:44, Frank Shearar <[hidden email]> wrote:

> Like tears in rain.
>
> It doesn't seem to be used by anything, there's a comment in it
> suggesting it be folded into ReleaseBuilder, ...


It was only used by the 3.9 release team. Not needed anymore.

Another 45Deprecated candidate.

- Bert -






Reply | Threaded
Open this post in threaded view
|

Re: ScriptLoader time to die?

Frank Shearar-3
On 3 May 2013 12:15, Nicolas Cellier <[hidden email]> wrote:

> +1
>
>
> 2013/5/3 Bert Freudenberg <[hidden email]>
>>
>>
>> On 2013-05-03, at 10:44, Frank Shearar <[hidden email]> wrote:
>>
>> > Like tears in rain.
>> >
>> > It doesn't seem to be used by anything, there's a comment in it
>> > suggesting it be folded into ReleaseBuilder, ...
>>
>>
>> It was only used by the 3.9 release team. Not needed anymore.
>>
>> Another 45Deprecated candidate.
>>
>> - Bert -

OK. Minor complication: ScriptLoader is the only class in the
ScriptLoader package. What do we do with the empty package? Push a
config map without it? Or, just to be clear,
* recategorise the ScriptLoader class to '45Deprecated'
* Save 45Deprecated
* Save ScriptLoader package
* Update the latest config map from the image
* Remove ScriptLoader package from the map
* Post the new config map

?

frank

Reply | Threaded
Open this post in threaded view
|

Re: ScriptLoader time to die?

Bert Freudenberg

On 2013-05-03, at 13:41, Frank Shearar <[hidden email]> wrote:

> On 3 May 2013 12:15, Nicolas Cellier <[hidden email]> wrote:
>> +1
>>
>>
>> 2013/5/3 Bert Freudenberg <[hidden email]>
>>>
>>>
>>> On 2013-05-03, at 10:44, Frank Shearar <[hidden email]> wrote:
>>>
>>>> Like tears in rain.
>>>>
>>>> It doesn't seem to be used by anything, there's a comment in it
>>>> suggesting it be folded into ReleaseBuilder, ...
>>>
>>>
>>> It was only used by the 3.9 release team. Not needed anymore.
>>>
>>> Another 45Deprecated candidate.
>>>
>>> - Bert -
>
> OK. Minor complication: ScriptLoader is the only class in the
> ScriptLoader package. What do we do with the empty package?

Just commit it.

> Push a config map without it?

Not yet. Before doing that we need to make sure the "empty" package was loaded. So we need at least one config map with the empty package. But this could wait.

> Or, just to be clear,
> * recategorise the ScriptLoader class to '45Deprecated'
> * Save 45Deprecated
> * Save ScriptLoader package

Yes.

> * Update the latest config map from the image
> * Remove ScriptLoader package from the map
> * Post the new config map

You also need to increment the Squeak-Version package version by the number from the removed package to ensure continuity.

- Bert -



Reply | Threaded
Open this post in threaded view
|

Re: ScriptLoader time to die?

Frank Shearar-3
On 3 May 2013 12:49, Bert Freudenberg <[hidden email]> wrote:

>
> On 2013-05-03, at 13:41, Frank Shearar <[hidden email]> wrote:
>
>> On 3 May 2013 12:15, Nicolas Cellier <[hidden email]> wrote:
>>> +1
>>>
>>>
>>> 2013/5/3 Bert Freudenberg <[hidden email]>
>>>>
>>>>
>>>> On 2013-05-03, at 10:44, Frank Shearar <[hidden email]> wrote:
>>>>
>>>>> Like tears in rain.
>>>>>
>>>>> It doesn't seem to be used by anything, there's a comment in it
>>>>> suggesting it be folded into ReleaseBuilder, ...
>>>>
>>>>
>>>> It was only used by the 3.9 release team. Not needed anymore.
>>>>
>>>> Another 45Deprecated candidate.
>>>>
>>>> - Bert -
>>
>> OK. Minor complication: ScriptLoader is the only class in the
>> ScriptLoader package. What do we do with the empty package?
>
> Just commit it.
>
>> Push a config map without it?
>
> Not yet. Before doing that we need to make sure the "empty" package was loaded. So we need at least one config map with the empty package. But this could wait.
>
>> Or, just to be clear,
>> * recategorise the ScriptLoader class to '45Deprecated'
>> * Save 45Deprecated
>> * Save ScriptLoader package
>
> Yes.

Right. So I think I've followed the right steps, and the ScriptLoader
package should now be empty. I pushed a new config map because
45Deprecated would otherwise load before ScriptLoader.

>> * Update the latest config map from the image
>> * Remove ScriptLoader package from the map
>> * Post the new config map
>
> You also need to increment the Squeak-Version package version by the number from the removed package to ensure continuity.

I guess that's as simple as saving Squeak-Version to trunk?

frank

> - Bert -
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: ScriptLoader time to die?

Bert Freudenberg

On 2013-05-03, at 14:38, Frank Shearar <[hidden email]> wrote:

> On 3 May 2013 12:49, Bert Freudenberg <[hidden email]> wrote:
>>
>> On 2013-05-03, at 13:41, Frank Shearar <[hidden email]> wrote:
>>
>>> On 3 May 2013 12:15, Nicolas Cellier <[hidden email]> wrote:
>>>> +1
>>>>
>>>>
>>>> 2013/5/3 Bert Freudenberg <[hidden email]>
>>>>>
>>>>>
>>>>> On 2013-05-03, at 10:44, Frank Shearar <[hidden email]> wrote:
>>>>>
>>>>>> Like tears in rain.
>>>>>>
>>>>>> It doesn't seem to be used by anything, there's a comment in it
>>>>>> suggesting it be folded into ReleaseBuilder, ...
>>>>>
>>>>>
>>>>> It was only used by the 3.9 release team. Not needed anymore.
>>>>>
>>>>> Another 45Deprecated candidate.
>>>>>
>>>>> - Bert -
>>>
>>> OK. Minor complication: ScriptLoader is the only class in the
>>> ScriptLoader package. What do we do with the empty package?
>>
>> Just commit it.
>>
>>> Push a config map without it?
>>
>> Not yet. Before doing that we need to make sure the "empty" package was loaded. So we need at least one config map with the empty package. But this could wait.
>>
>>> Or, just to be clear,
>>> * recategorise the ScriptLoader class to '45Deprecated'
>>> * Save 45Deprecated
>>> * Save ScriptLoader package
>>
>> Yes.
>
> Right. So I think I've followed the right steps, and the ScriptLoader
> package should now be empty. I pushed a new config map because
> 45Deprecated would otherwise load before ScriptLoader.

Huh? If you moved stuff from ScriptLoader to 45Deprecated, then 45Deprecated should indeed come before ScriptLoader.

I'll see if I can find time on the weekend to resolve this.

>>> * Update the latest config map from the image
>>> * Remove ScriptLoader package from the map
>>> * Post the new config map
>>
>> You also need to increment the Squeak-Version package version by the number from the removed package to ensure continuity.
>
> I guess that's as simple as saving Squeak-Version to trunk?
>
> frank


With a manually entered new version number, yes, but you need to follow that up quickly with the new config map that removes the other package.

- Bert -



Reply | Threaded
Open this post in threaded view
|

Re: ScriptLoader time to die?

Frank Shearar-3
On 3 May 2013 13:42, Bert Freudenberg <[hidden email]> wrote:

>
> On 2013-05-03, at 14:38, Frank Shearar <[hidden email]> wrote:
>
>> On 3 May 2013 12:49, Bert Freudenberg <[hidden email]> wrote:
>>>
>>> On 2013-05-03, at 13:41, Frank Shearar <[hidden email]> wrote:
>>>
>>>> On 3 May 2013 12:15, Nicolas Cellier <[hidden email]> wrote:
>>>>> +1
>>>>>
>>>>>
>>>>> 2013/5/3 Bert Freudenberg <[hidden email]>
>>>>>>
>>>>>>
>>>>>> On 2013-05-03, at 10:44, Frank Shearar <[hidden email]> wrote:
>>>>>>
>>>>>>> Like tears in rain.
>>>>>>>
>>>>>>> It doesn't seem to be used by anything, there's a comment in it
>>>>>>> suggesting it be folded into ReleaseBuilder, ...
>>>>>>
>>>>>>
>>>>>> It was only used by the 3.9 release team. Not needed anymore.
>>>>>>
>>>>>> Another 45Deprecated candidate.
>>>>>>
>>>>>> - Bert -
>>>>
>>>> OK. Minor complication: ScriptLoader is the only class in the
>>>> ScriptLoader package. What do we do with the empty package?
>>>
>>> Just commit it.
>>>
>>>> Push a config map without it?
>>>
>>> Not yet. Before doing that we need to make sure the "empty" package was loaded. So we need at least one config map with the empty package. But this could wait.
>>>
>>>> Or, just to be clear,
>>>> * recategorise the ScriptLoader class to '45Deprecated'
>>>> * Save 45Deprecated
>>>> * Save ScriptLoader package
>>>
>>> Yes.
>>
>> Right. So I think I've followed the right steps, and the ScriptLoader
>> package should now be empty. I pushed a new config map because
>> 45Deprecated would otherwise load before ScriptLoader.
>
> Huh? If you moved stuff from ScriptLoader to 45Deprecated, then 45Deprecated should indeed come before ScriptLoader.
>
> I'll see if I can find time on the weekend to resolve this.
>
>>>> * Update the latest config map from the image
>>>> * Remove ScriptLoader package from the map
>>>> * Post the new config map
>>>
>>> You also need to increment the Squeak-Version package version by the number from the removed package to ensure continuity.
>>
>> I guess that's as simple as saving Squeak-Version to trunk?
>>
>> frank
>
>
> With a manually entered new version number, yes, but you need to follow that up quickly with the new config map that removes the other package.

With our current high rate of commits, I might just be able to do that
:) Should I do it now though, or give it a day for possible comment
from the North Americans?

frank

> - Bert -
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: ScriptLoader time to die?

Bert Freudenberg

On 2013-05-03, at 14:44, Frank Shearar <[hidden email]> wrote:

> On 3 May 2013 13:42, Bert Freudenberg <[hidden email]> wrote:
>>
>> On 2013-05-03, at 14:38, Frank Shearar <[hidden email]> wrote:
>>
>>> On 3 May 2013 12:49, Bert Freudenberg <[hidden email]> wrote:
>>>>
>>>> On 2013-05-03, at 13:41, Frank Shearar <[hidden email]> wrote:
>>>>
>>>>> On 3 May 2013 12:15, Nicolas Cellier <[hidden email]> wrote:
>>>>>> +1
>>>>>>
>>>>>>
>>>>>> 2013/5/3 Bert Freudenberg <[hidden email]>
>>>>>>>
>>>>>>>
>>>>>>> On 2013-05-03, at 10:44, Frank Shearar <[hidden email]> wrote:
>>>>>>>
>>>>>>>> Like tears in rain.
>>>>>>>>
>>>>>>>> It doesn't seem to be used by anything, there's a comment in it
>>>>>>>> suggesting it be folded into ReleaseBuilder, ...
>>>>>>>
>>>>>>>
>>>>>>> It was only used by the 3.9 release team. Not needed anymore.
>>>>>>>
>>>>>>> Another 45Deprecated candidate.
>>>>>>>
>>>>>>> - Bert -
>>>>>
>>>>> OK. Minor complication: ScriptLoader is the only class in the
>>>>> ScriptLoader package. What do we do with the empty package?
>>>>
>>>> Just commit it.
>>>>
>>>>> Push a config map without it?
>>>>
>>>> Not yet. Before doing that we need to make sure the "empty" package was loaded. So we need at least one config map with the empty package. But this could wait.
>>>>
>>>>> Or, just to be clear,
>>>>> * recategorise the ScriptLoader class to '45Deprecated'
>>>>> * Save 45Deprecated
>>>>> * Save ScriptLoader package
>>>>
>>>> Yes.
>>>
>>> Right. So I think I've followed the right steps, and the ScriptLoader
>>> package should now be empty. I pushed a new config map because
>>> 45Deprecated would otherwise load before ScriptLoader.
>>
>> Huh? If you moved stuff from ScriptLoader to 45Deprecated, then 45Deprecated should indeed come before ScriptLoader.
>>
>> I'll see if I can find time on the weekend to resolve this.
>>
>>>>> * Update the latest config map from the image
>>>>> * Remove ScriptLoader package from the map
>>>>> * Post the new config map
>>>>
>>>> You also need to increment the Squeak-Version package version by the number from the removed package to ensure continuity.
>>>
>>> I guess that's as simple as saving Squeak-Version to trunk?
>>>
>>> frank
>>
>>
>> With a manually entered new version number, yes, but you need to follow that up quickly with the new config map that removes the other package.
>
> With our current high rate of commits, I might just be able to do that
> :) Should I do it now though, or give it a day for possible comment
> from the North Americans?
>
> frank

Doesn't hurt to wait.

- Bert -