Should removed classes become Undeclared?

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
63 messages Options
1234
Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

Göran Krampe
"Frank Shearar" <[hidden email]> wrote:
> Is there a way to split up a ChangeSet into a set of per-package change
> sets? Then I can post those to Mantis instead of MCDs.
>
> frank

Yes, I included such functionality in PackageInfoExtras (in the
changesorter menues) - but I am afraid it is slightly broken in the
current version on SM - and right now I don't recall exactly what it
was.

My original changeset with this function works IIRC. It is on Mantis:

        http://bugs.impara.de/view.php?id=1730

regards, Göran

Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

stéphane ducasse-2
In reply to this post by Frank Shearar
Thanks frank and we will merge that in 3.9 as soon as this is done.

Stef

On 13 févr. 06, at 21:28, Frank Shearar wrote:

> "Dan Ingalls" <[hidden email]> wrote:
> <snip>
>> I regret that I don't have time to fix these right now.  However, if
>> there is a well-intentioned soul out there, he or she will perhaps
>> find the method below to be quite useful.  It found 165 methods in my
>> system with this pattern.
>
> I'll do it, in my (virgin) 3.9a-6721.
>
> frank
>


Reply | Threaded
Open this post in threaded view
|

Re: Bug: Use of == for arithmetic equality

stéphane ducasse-2
In reply to this post by Dan Ingalls
Hi dan

this is really nice to see coming back to real life :).
Can you tell us a bit more about this new VM?
How does it relate to pepsi?

Stef

PS: I still have the dream that I could learn
VM by reading the code of a nice one and then do a lecture
on that,  so your remark on newbie learning is always what
push me to clean the system (remembering your Byte'81 quote
on a so simple system that a single person could understand it)

PSPS note that I use simple and not small because cool abstractions
really build simple knowledge :)

Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

stéphane ducasse-2
In reply to this post by Frank Shearar
This is really strange.
I do not have time now to check but we will.

Stef


> Er, when I make these MCDs (mark the repository as storing diffs,  
> hit the
> Save button) my image (3.9a-6721) pops up a never-ending sequence of
> "Diffing..." messages, but never seems to stop. I mean, I'm trying  
> to save
> the Collections mcd, which altered about 10 or so methods, and the  
> saving
> process has already taken 7 minutes! Am I doing something crazily  
> wrong?
>
> My previous attempt was on the Traits package, and that took at  
> least an
> hour before I gave up.
>
> Is there a way to split up a ChangeSet into a set of per-package  
> change
> sets? Then I can post those to Mantis instead of MCDs.
>
> frank
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

Adrian Lienhard
Hi Frank,

I suggest to just use MCZ (no diffing). Monticello nicely deals with  
merging different versions (compared to changesets vs fileOuts).

Adrian

On Feb 14, 2006, at 11:12 , stéphane ducasse wrote:

> This is really strange.
> I do not have time now to check but we will.
>
> Stef
>
>
>> Er, when I make these MCDs (mark the repository as storing diffs,  
>> hit the
>> Save button) my image (3.9a-6721) pops up a never-ending sequence of
>> "Diffing..." messages, but never seems to stop. I mean, I'm trying  
>> to save
>> the Collections mcd, which altered about 10 or so methods, and the  
>> saving
>> process has already taken 7 minutes! Am I doing something crazily  
>> wrong?
>>
>> My previous attempt was on the Traits package, and that took at  
>> least an
>> hour before I gave up.
>>
>> Is there a way to split up a ChangeSet into a set of per-package  
>> change
>> sets? Then I can post those to Mantis instead of MCDs.
>>
>> frank
>>
>>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

Frank Shearar
As per Adrian's suggestion I've uploaded all the MCZs to the Mantis bug
report (http://bugs.impara.de/view.php?id=2788) - except for Morphic. The
Upload File section quotes a maximum file size of 2,000k, and Morphic-fbs.66
is 1,084,635 bytes, yet Mantis complains that that file's too large. Could
it be that the maximum file size is actually 1000K? The next-largest file I
uploaded was 792K.

Any suggestions how to get the Morphic file up? I'd love to make an MCD from
Morphic-fbs.66 and Morphic-md.65, for instance. Ooh, hang on! I see a
Morphic-fbs.66(md.65).mcd file in my package-cache! OK, I've uploaded that
to the bug report. Hopefully that'll work for propogating my changes.

frank

----- Original Message -----
From: "Adrian Lienhard" <[hidden email]>
To: "The general-purpose Squeak developers list"
<[hidden email]>
Sent: Tuesday, February 14, 2006 12:17 PM
Subject: Re: Use of == for arithmetic equality


Hi Frank,

I suggest to just use MCZ (no diffing). Monticello nicely deals with
merging different versions (compared to changesets vs fileOuts).

Adrian

On Feb 14, 2006, at 11:12 , stéphane ducasse wrote:

> This is really strange.
> I do not have time now to check but we will.
>
> Stef
>
>
>> Er, when I make these MCDs (mark the repository as storing diffs,
>> hit the
>> Save button) my image (3.9a-6721) pops up a never-ending sequence of
>> "Diffing..." messages, but never seems to stop. I mean, I'm trying
>> to save
>> the Collections mcd, which altered about 10 or so methods, and the
>> saving
>> process has already taken 7 minutes! Am I doing something crazily
>> wrong?
>>
>> My previous attempt was on the Traits package, and that took at
>> least an
>> hour before I gave up.
>>
>> Is there a way to split up a ChangeSet into a set of per-package
>> change
>> sets? Then I can post those to Mantis instead of MCDs.
>>
>> frank
>>
>>
>
>




Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

Bert Freudenberg-3
Actually, you should have uploaded the MCZs to

        http://source.squeakfoundation.org/inbox.html

Which works nice and easy using Monticello itself ...

- Bert -

Am 14.02.2006 um 12:30 schrieb Frank Shearar:

> As per Adrian's suggestion I've uploaded all the MCZs to the Mantis  
> bug
> report (http://bugs.impara.de/view.php?id=2788) - except for  
> Morphic. The
> Upload File section quotes a maximum file size of 2,000k, and  
> Morphic-fbs.66
> is 1,084,635 bytes, yet Mantis complains that that file's too  
> large. Could
> it be that the maximum file size is actually 1000K? The next-
> largest file I
> uploaded was 792K.
>
> Any suggestions how to get the Morphic file up? I'd love to make an  
> MCD from
> Morphic-fbs.66 and Morphic-md.65, for instance. Ooh, hang on! I see a
> Morphic-fbs.66(md.65).mcd file in my package-cache! OK, I've  
> uploaded that
> to the bug report. Hopefully that'll work for propogating my changes.
>
> frank
>
> ----- Original Message -----
> From: "Adrian Lienhard" <[hidden email]>
> To: "The general-purpose Squeak developers list"
> <[hidden email]>
> Sent: Tuesday, February 14, 2006 12:17 PM
> Subject: Re: Use of == for arithmetic equality
>
>
> Hi Frank,
>
> I suggest to just use MCZ (no diffing). Monticello nicely deals with
> merging different versions (compared to changesets vs fileOuts).
>
> Adrian
>
> On Feb 14, 2006, at 11:12 , stéphane ducasse wrote:
>
>> This is really strange.
>> I do not have time now to check but we will.
>>
>> Stef
>>
>>
>>> Er, when I make these MCDs (mark the repository as storing diffs,
>>> hit the
>>> Save button) my image (3.9a-6721) pops up a never-ending sequence of
>>> "Diffing..." messages, but never seems to stop. I mean, I'm trying
>>> to save
>>> the Collections mcd, which altered about 10 or so methods, and the
>>> saving
>>> process has already taken 7 minutes! Am I doing something crazily
>>> wrong?
>>>
>>> My previous attempt was on the Traits package, and that took at
>>> least an
>>> hour before I gave up.
>>>
>>> Is there a way to split up a ChangeSet into a set of per-package
>>> change
>>> sets? Then I can post those to Mantis instead of MCDs.
>>>
>>> frank
>>>
>>>
>>
>>
>
>
>




Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

Frank Shearar
Ah, OK. I thought that fixes were supposed to go to Mantis first, then to
inbox after the fixes had been vetted. I'm sorry if I've made more work for
everyone!

Perhaps I should leave the files where they are though; otherwise we'll end
up with two sets of fixes and people merging the fixes might get confused?
Or would you prefer I leave a note in Mantis, and save all the changes to
inbox?

frank
----- Original Message -----
From: "Bert Freudenberg" <[hidden email]>
To: "The general-purpose Squeak developers list"
<[hidden email]>
Sent: Tuesday, February 14, 2006 1:41 PM
Subject: Re: Use of == for arithmetic equality


Actually, you should have uploaded the MCZs to

http://source.squeakfoundation.org/inbox.html

Which works nice and easy using Monticello itself ...

- Bert -

Am 14.02.2006 um 12:30 schrieb Frank Shearar:

> As per Adrian's suggestion I've uploaded all the MCZs to the Mantis
> bug
> report (http://bugs.impara.de/view.php?id=2788) - except for
> Morphic. The
> Upload File section quotes a maximum file size of 2,000k, and
> Morphic-fbs.66
> is 1,084,635 bytes, yet Mantis complains that that file's too
> large. Could
> it be that the maximum file size is actually 1000K? The next-
> largest file I
> uploaded was 792K.
>
> Any suggestions how to get the Morphic file up? I'd love to make an
> MCD from
> Morphic-fbs.66 and Morphic-md.65, for instance. Ooh, hang on! I see a
> Morphic-fbs.66(md.65).mcd file in my package-cache! OK, I've
> uploaded that
> to the bug report. Hopefully that'll work for propogating my changes.
>
> frank
>
> ----- Original Message -----
> From: "Adrian Lienhard" <[hidden email]>
> To: "The general-purpose Squeak developers list"
> <[hidden email]>
> Sent: Tuesday, February 14, 2006 12:17 PM
> Subject: Re: Use of == for arithmetic equality
>
>
> Hi Frank,
>
> I suggest to just use MCZ (no diffing). Monticello nicely deals with
> merging different versions (compared to changesets vs fileOuts).
>
> Adrian
>
> On Feb 14, 2006, at 11:12 , stéphane ducasse wrote:
>
>> This is really strange.
>> I do not have time now to check but we will.
>>
>> Stef
>>
>>
>>> Er, when I make these MCDs (mark the repository as storing diffs,
>>> hit the
>>> Save button) my image (3.9a-6721) pops up a never-ending sequence of
>>> "Diffing..." messages, but never seems to stop. I mean, I'm trying
>>> to save
>>> the Collections mcd, which altered about 10 or so methods, and the
>>> saving
>>> process has already taken 7 minutes! Am I doing something crazily
>>> wrong?
>>>
>>> My previous attempt was on the Traits package, and that took at
>>> least an
>>> hour before I gave up.
>>>
>>> Is there a way to split up a ChangeSet into a set of per-package
>>> change
>>> sets? Then I can post those to Mantis instead of MCDs.
>>>
>>> frank
>>>
>>>
>>
>>
>
>
>






Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

Cees De Groot
On 2/14/06, Frank Shearar <[hidden email]> wrote:
> Ah, OK. I thought that fixes were supposed to go to Mantis first, then to
> inbox after the fixes had been vetted. I'm sorry if I've made more work for
> everyone!
>
Yes, you're right. And Bert isn't ;-). Package teams should be the
only ones that publish to the integration inbox, because they are the
ones that decide whether a package version is integration-ready or
not. So putting them on Mantis is the correct action (Mantis is in
effect the inbox of the package teams).

Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

stéphane ducasse-2
In reply to this post by Frank Shearar

On 14 févr. 06, at 13:02, Frank Shearar wrote:

> Or would you prefer I leave a note in Mantis, and save all the  
> changes to
> inbox?

Is a good way to work.



Reply | Threaded
Open this post in threaded view
|

Re: Use of == for arithmetic equality

stéphane ducasse-2
In reply to this post by Cees De Groot
sure but this does not work when you have cross cutting changes.
For cross cutting changes like the fix of lukas on TextAnchor if we  
would have waited
for just the feedback of the teams involved this would not be in the  
image yet.

Stef

On 14 févr. 06, at 13:06, Cees De Groot wrote:

> On 2/14/06, Frank Shearar <[hidden email]> wrote:
>> Ah, OK. I thought that fixes were supposed to go to Mantis first,  
>> then to
>> inbox after the fixes had been vetted. I'm sorry if I've made more  
>> work for
>> everyone!
>>
> Yes, you're right. And Bert isn't ;-). Package teams should be the
> only ones that publish to the integration inbox, because they are the
> ones that decide whether a package version is integration-ready or
> not. So putting them on Mantis is the correct action (Mantis is in
> effect the inbox of the package teams).
>
>


Reply | Threaded
Open this post in threaded view
|

Posting Fixes (was Re: Use of == for arithmetic equality)

Bert Freudenberg-3
In reply to this post by Cees De Groot
Am 14.02.2006 um 13:06 schrieb Cees De Groot:

> On 2/14/06, Frank Shearar <[hidden email]> wrote:
>> Ah, OK. I thought that fixes were supposed to go to Mantis first,  
>> then to
>> inbox after the fixes had been vetted. I'm sorry if I've made more  
>> work for
>> everyone!
>>
> Yes, you're right. And Bert isn't ;-). Package teams should be the
> only ones that publish to the integration inbox, because they are the
> ones that decide whether a package version is integration-ready or
> not. So putting them on Mantis is the correct action (Mantis is in
> effect the inbox of the package teams).

Well, the wiki entry at http://source.squeakfoundation.org/inbox.html 
still says

"This is a place for code to be posted for possible inclusion in  
3.9alpha (and future Squeak versions). The code can be referenced  
from a Mantis submission."

Seems I didn't notice the change of rules in the mean time.

Also, I'd prefer directly publishing to a MC repository rather than  
uploading to Mantis.

- Bert -


Reply | Threaded
Open this post in threaded view
|

Re: Posting Fixes (was Re: Use of == for arithmetic equality)

Cees De Groot
On 2/14/06, Bert Freudenberg <[hidden email]> wrote:
> Also, I'd prefer directly publishing to a MC repository rather than
> uploading to Mantis.
>
Absolutely. I'd publish that sort of stuff in my own repository in
such a case and add pointers to Mantis.

Reply | Threaded
Open this post in threaded view
|

Re: Posting Fixes (was Re: Use of == for arithmetic equality)

Frank Shearar
"Cees De Groot" <[hidden email]> wrote:

> On 2/14/06, Bert Freudenberg <[hidden email]> wrote:
> > Also, I'd prefer directly publishing to a MC repository rather than
> > uploading to Mantis.
> >
> Absolutely. I'd publish that sort of stuff in my own repository in
> such a case and add pointers to Mantis.

Er, so should I save the in-image package MCZs to the inbox repository? Or
will whoever manages the inbox grab the MCZs from the Mantis bug report?

frank



Reply | Threaded
Open this post in threaded view
|

Re: Posting Fixes (was Re: Use of == for arithmetic equality)

Cees De Groot
On 2/14/06, Frank Shearar <[hidden email]> wrote:
> Er, so should I save the in-image package MCZs to the inbox repository? Or
> will whoever manages the inbox grab the MCZs from the Mantis bug report?
>
Neither. The regular flow is community -> mantis -> package team ->
inbox -> release team. In that way, we ensure that the package team
controls what is released and when, plus that they don't need to look
left and right for inbound stuff. And it keeps the inbox clean (which
helps the release team in evaluating how much stuff is available
there).

It's all a bit harder with this new system for cross-cutting patches,
but that's the trade-off we made when moving to the team model (and,
with it, giving the team ultimate responsibility for what is released
- responsibility and control go hand in hand here, as they should)

Reply | Threaded
Open this post in threaded view
|

Re: Posting Fixes (was Re: Use of == for arithmetic equality)

Frank Shearar
> "Cees De Groot" <[hidden email]> answered:

> On 2/14/06, Frank Shearar <[hidden email]> wrote:
> > Er, so should I save the in-image package MCZs to the inbox repository?
Or
> > will whoever manages the inbox grab the MCZs from the Mantis bug report?
> >
> Neither. The regular flow is community -> mantis -> package team ->
> inbox -> release team. In that way, we ensure that the package team
> controls what is released and when, plus that they don't need to look
> left and right for inbound stuff. And it keeps the inbox clean (which
> helps the release team in evaluating how much stuff is available
> there).

OK, which means that I don't need to do anything further then, yes?

frank




Reply | Threaded
Open this post in threaded view
|

Re: Posting Fixes (was Re: Use of == for arithmetic equality)

stéphane ducasse-2
In reply to this post by Frank Shearar
Hi frank

publish in the inbox and we will take them from there.

Stef

On 14 févr. 06, at 16:02, Frank Shearar wrote:

> "Cees De Groot" <[hidden email]> wrote:
>
>> On 2/14/06, Bert Freudenberg <[hidden email]> wrote:
>>> Also, I'd prefer directly publishing to a MC repository rather than
>>> uploading to Mantis.
>>>
>> Absolutely. I'd publish that sort of stuff in my own repository in
>> such a case and add pointers to Mantis.
>
> Er, so should I save the in-image package MCZs to the inbox  
> repository? Or
> will whoever manages the inbox grab the MCZs from the Mantis bug  
> report?
>
> frank
>
>
>


Reply | Threaded
Open this post in threaded view
|

Re: Posting Fixes (was Re: Use of == for arithmetic equality)

stéphane ducasse-2
In reply to this post by Cees De Groot

On 14 févr. 06, at 16:13, Cees De Groot wrote:

> On 2/14/06, Frank Shearar <[hidden email]> wrote:
>> Er, so should I save the in-image package MCZs to the inbox  
>> repository? Or
>> will whoever manages the inbox grab the MCZs from the Mantis bug  
>> report?
>>
> Neither. The regular flow is community -> mantis -> package team ->
> inbox -> release team. In that way, we ensure that the package team
> controls what is released and when, plus that they don't need to look
> left and right for inbound stuff. And it keeps the inbox clean (which
> helps the release team in evaluating how much stuff is available
> there).
>
> It's all a bit harder with this new system for cross-cutting patches,
> but that's the trade-off we made when moving to the team model (and,
> with it, giving the team ultimate responsibility for what is released
> - responsibility and control go hand in hand here, as they should)

Sure cees
this is working well for simple package oriented fixes.
But now it would be good that we get the changes! Look at the Network
team for example. Should frank stack that in the team and we get  
something
in the future (instead of now and getting done).
And each team can do a merge after. Else we can have endless  
discussions.
See the Fix of TextAnchor of lukas.

Stef


Reply | Threaded
Open this post in threaded view
|

Re: Posting Fixes (was Re: Use of == for arithmetic equality)

Andreas.Raab
stéphane ducasse wrote:
> Sure cees
> this is working well for simple package oriented fixes.
> But now it would be good that we get the changes! Look at the Network
> team for example. Should frank stack that in the team and we get something
> in the future (instead of now and getting done).

Given that this code does neither have any cross-cutting requirements
and doesn't even fix anything that's broken I don't see why you have the
urge to push this in right now. As a matter of fact, I'm somewhat
concerned about these changes and would like them to be reviewed - there
are various places where the pattern "foo == 0" is absolutely
appropriate and where #= should *not* be used and I wonder whether these
places have been taken into account properly.

> And each team can do a merge after. Else we can have endless discussions.
> See the Fix of TextAnchor of lukas.

Where was this endless discussion?

Cheers,
   - Andreas

Reply | Threaded
Open this post in threaded view
|

Re: Posting Fixes (was Re: Use of == for arithmetic equality)

Frank Shearar
In reply to this post by stéphane ducasse-2
Great. I've just started, with the Collections package.

frank
----- Original Message -----
From: "stéphane ducasse" <[hidden email]>
To: "The general-purpose Squeak developers list"
<[hidden email]>
Sent: Tuesday, February 14, 2006 5:19 PM
Subject: Re: Posting Fixes (was Re: Use of == for arithmetic equality)


Hi frank

publish in the inbox and we will take them from there.

Stef

On 14 févr. 06, at 16:02, Frank Shearar wrote:

> "Cees De Groot" <[hidden email]> wrote:
>
>> On 2/14/06, Bert Freudenberg <[hidden email]> wrote:
>>> Also, I'd prefer directly publishing to a MC repository rather than
>>> uploading to Mantis.
>>>
>> Absolutely. I'd publish that sort of stuff in my own repository in
>> such a case and add pointers to Mantis.
>
> Er, so should I save the in-image package MCZs to the inbox
> repository? Or
> will whoever manages the inbox grab the MCZs from the Mantis bug
> report?
>
> frank
>
>
>




1234