Small UI fix needed in OCompletion - ECPreferences>> menuSelectionColor

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Small UI fix needed in OCompletion - ECPreferences>> menuSelectionColor

Hannes Hirzel
Hello

After loading the Vivide Framework / Toolset [1], [2], [3] into a
recent trunk image I got a complaint about the menuSelection color.
Marcel and I could identify that ECPreferences, package
'Ocompletion-ECSqueak' [4] needs to be fixed.

ECPreferences>>
menuSelectionColor

        Smalltalk at: #UITheme ifPresent: [ :uiTheme |
                "Pharo"
                ^uiTheme current settings selectionColor ].
        Smalltalk at: #Preferences ifPresent: [ :preferences |
                "Squeak"
                ^preferences menuSelectionColor ]


Could somebody with access rights (Levente?) help

Kind regards
Hannes


[1] https://github.com/hpi-swa/vivide/
[2] https://github.com/hpi-swa/widgets
[3] https://www.hpi.uni-potsdam.de/hirschfeld/artefacts/vivide/
[4] http://www.squeaksource.com/OCompletion

Reply | Threaded
Open this post in threaded view
|

Re: Small UI fix needed in OCompletion - ECPreferences>> menuSelectionColor

Levente Uzonyi
Hi Hannes,

I think the snippet below is from an old version of OCompletion. Please
use the latest from 2016.

Levente

On Fri, 6 Oct 2017, H. Hirzel wrote:

> Hello
>
> After loading the Vivide Framework / Toolset [1], [2], [3] into a
> recent trunk image I got a complaint about the menuSelection color.
> Marcel and I could identify that ECPreferences, package
> 'Ocompletion-ECSqueak' [4] needs to be fixed.
>
> ECPreferences>>
> menuSelectionColor
>
>        Smalltalk at: #UITheme ifPresent: [ :uiTheme |
>                "Pharo"
>                ^uiTheme current settings selectionColor ].
>        Smalltalk at: #Preferences ifPresent: [ :preferences |
>                "Squeak"
>                ^preferences menuSelectionColor ]
>
>
> Could somebody with access rights (Levente?) help
>
> Kind regards
> Hannes
>
>
> [1] https://github.com/hpi-swa/vivide/
> [2] https://github.com/hpi-swa/widgets
> [3] https://www.hpi.uni-potsdam.de/hirschfeld/artefacts/vivide/
> [4] http://www.squeaksource.com/OCompletion