Smalltalk › Squeak › Squeak - Dev

SocketStream changes for 4.1... too late?

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

6 messages Options

Göran Krampe

SocketStream changes for 4.1... too late?

Hi!

Someone asked me again about large file upload support on the Seaside
list and I pointed to the code I wrote in 2008 when "competing" with
Janko/Swazoo for upload speed. :)

Now... that code has enhancements for SocketStream which of course
should go in there.

Question: Is it too late in the game to try to push it?

I haven't gone through it in detail, wanted to check first. The original
cs is attached.

regards, Göran

StreamedUploadZeroCopy.2.cs.gz (6K) Download Attachment

Bert Freudenberg

Re: SocketStream changes for 4.1... too late?

On 24.03.2010, at 09:55, Göran Krampe wrote:

>
> Hi!
>
> Someone asked me again about large file upload support on the Seaside
> list and I pointed to the code I wrote in 2008 when "competing" with
> Janko/Swazoo for upload speed. :)
>
> Now... that code has enhancements for SocketStream which of course
> should go in there.
>
> Question: Is it too late in the game to try to push it?

Not yet. :)

> I haven't gone through it in detail, wanted to check first. The original
> cs is attached.
>
> regards, Göran
>
> <StreamedUploadZeroCopy.2.cs.gz>

- Bert -

Nicolas Cellier

Re: SocketStream changes for 4.1... too late?

2010/3/24 Bert Freudenberg <[hidden email]>:

> On 24.03.2010, at 09:55, Göran Krampe wrote:
>>
>> Hi!
>>
>> Someone asked me again about large file upload support on the Seaside
>> list and I pointed to the code I wrote in 2008 when "competing" with
>> Janko/Swazoo for upload speed. :)
>>
>> Now... that code has enhancements for SocketStream which of course
>> should go in there.
>>
>> Question: Is it too late in the game to try to push it?
>
> Not yet. :)
>

Please with := instead of _ :)

Nicolas

>> I haven't gone through it in detail, wanted to check first. The original
>> cs is attached.
>>
>> regards, Göran
>>
>> <StreamedUploadZeroCopy.2.cs.gz>
>
>
> - Bert -
>
>
>
>

Göran Krampe

Re: SocketStream changes for 4.1... too late?

Nicolas Cellier wrote:

> 2010/3/24 Bert Freudenberg <[hidden email]>:
>> On 24.03.2010, at 09:55, Göran Krampe wrote:
>>> Hi!
>>>
>>> Someone asked me again about large file upload support on the Seaside
>>> list and I pointed to the code I wrote in 2008 when "competing" with
>>> Janko/Swazoo for upload speed. :)
>>>
>>> Now... that code has enhancements for SocketStream which of course
>>> should go in there.
>>>
>>> Question: Is it too late in the game to try to push it?
>> Not yet. :)
>>
>
> Please with := instead of _ :)

Yes of course - it was the *original* cs. I would need to go through the
changes and understand them (again!) and verify that they are correct to
do in current trunk etc.

regards, Göran

Andreas.Raab

Re: SocketStream changes for 4.1... too late?

In reply to this post by Göran Krampe

On 3/24/2010 1:55 AM, Göran Krampe wrote:
> Question: Is it too late in the game to try to push it?

We've got three more days 'til feature freeze. If you feel comfortable
that the changes are robust and well-tested go for it. If you need
someone to review them first, push them into the inbox and let people
know what to check for.

Cheers,
- Andreas

Göran Krampe

Re: SocketStream changes for 4.1... too late?

Andreas Raab wrote:
> On 3/24/2010 1:55 AM, Göran Krampe wrote:
>> Question: Is it too late in the game to try to push it?
>
> We've got three more days 'til feature freeze. If you feel comfortable
> that the changes are robust and well-tested go for it. If you need
> someone to review them first, push them into the inbox and let people
> know what to check for.

Yeah, I will see if I can make it. No big deal.

regards, Göran