Smalltalk › Squeak › Squeak - Dev

Solarized dark theme: text selection colour a little hard to see

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

9 messages Options

Tony Garnock-Jones-3

Solarized dark theme: text selection colour a little hard to see

In my image, I've replaced SolarizedTheme class >>
#darkBackgroundHighlights with the following, since with the default I
find it very difficult to spot which list item is selected, where the
text selection is, etc etc:

darkBackgroundHighlights
^ self base02 lighter

(The original had just "^ self base02".)

Does anyone else suffer similarly with the default? Should something
like my change make it into the master image?

Tony

Tobias Pape

Re: Solarized dark theme: text selection colour a little hard to see

> On 15.03.2017, at 02:01, Tony Garnock-Jones <[hidden email]> wrote:
>
> In my image, I've replaced SolarizedTheme class >>
> #darkBackgroundHighlights with the following, since with the default I
> find it very difficult to spot which list item is selected, where the
> text selection is, etc etc:
>
> darkBackgroundHighlights
> ^ self base02 lighter
>
> (The original had just "^ self base02".)
>
> Does anyone else suffer similarly with the default? Should something
> like my change make it into the master image?
>

Personally, I think so, yes!

Hannes Hirzel

Re: Solarized dark theme: text selection colour a little hard to see

I agree with Tony. It should be changed.

--HH

On 3/15/17, Tobias Pape <[hidden email]> wrote:

>
>> On 15.03.2017, at 02:01, Tony Garnock-Jones <[hidden email]> wrote:
>>
>> In my image, I've replaced SolarizedTheme class >>
>> #darkBackgroundHighlights with the following, since with the default I
>> find it very difficult to spot which list item is selected, where the
>> text selection is, etc etc:
>>
>> darkBackgroundHighlights
>> ^ self base02 lighter
>>
>> (The original had just "^ self base02".)
>>
>> Does anyone else suffer similarly with the default? Should something
>> like my change make it into the master image?
>>
>
> Personally, I think so, yes!
>
>
>
>
>

Tony Garnock-Jones-3

Re: Solarized dark theme: text selection colour a little hard to see

Hi all,

On 03/15/2017 05:59 AM, H. Hirzel wrote:
> I agree with Tony. It should be changed.

On 3/15/17, Tobias Pape <[hidden email]> wrote:
> Personally, I think so, yes!

OK! Thanks, Hannes and Tobias. I'll prepare something for the Inbox.

Aesthetically, is it better to have darkBackgroundHighlights answer a
lighter colour, influencing the *many* places it is used in the theme,
or to instead have "... darkBackgroundHighlights lighter" in certain
places relating to selections of various kinds?

Absent replies, I'll experiment and upload what I feel is best.

(I guess this is kind of a bike-shed discussion! "What colour shall we
paint the bike-shed^Wtext selection?")

Tony

cbc

Re: Solarized dark theme: text selection colour a little hard to see

On Wed, Mar 15, 2017 at 10:38 AM, Tony Garnock-Jones <[hidden email]> wrote:

Hi all,

On 03/15/2017 05:59 AM, H. Hirzel wrote:
> I agree with Tony. It should be changed.

On 3/15/17, Tobias Pape <[hidden email]> wrote:
> Personally, I think so, yes!

OK! Thanks, Hannes and Tobias. I'll prepare something for the Inbox.

Aesthetically, is it better to have darkBackgroundHighlights answer a
lighter colour, influencing the *many* places it is used in the theme,
or to instead have "... darkBackgroundHighlights lighter" in certain
places relating to selections of various kinds?

Absent replies, I'll experiment and upload what I feel is best.

Please find something that works well for you.

As a point of feedback, I find even your original change is still not noticeable by me (on windows with the LCD monitor that I use - I've had similar problems in the past, too). That said, I also prefer the Monokai dark, so this doesn't directly impact me, either.

-cbc

Tony Garnock-Jones-3

Re: Solarized dark theme: text selection colour a little hard to see

On 03/15/2017 06:28 PM, Chris Cunningham wrote:
> As a point of feedback, I find even your original change is still not
> noticeable by me (on windows with the LCD monitor that I use - I've had
> similar problems in the past, too). That said, I also prefer the Monokai
> dark, so this doesn't directly impact me, either.

Thank you! That's useful feedback. I will experiment with a more drastic
change :-)

Paul DeBruicker

Re: Solarized dark theme: text selection colour a little hard to see

Hi Tony,

I wrote a little bit about color picking to the pharo list. Maybe you'd find it helpful in your current efforts:

http://forum.world.st/These-beautiful-tooltips-tp4932206p4932319.html

Tony Garnock-Jones-3 wrote

On 03/15/2017 06:28 PM, Chris Cunningham wrote:
> As a point of feedback, I find even your original change is still not
> noticeable by me (on windows with the LCD monitor that I use - I've had
> similar problems in the past, too). That said, I also prefer the Monokai
> dark, so this doesn't directly impact me, either.

Thank you! That's useful feedback. I will experiment with a more drastic
change :-)

marcel.taeumel

Re: Solarized dark theme: text selection colour a little hard to see

In reply to this post by Tony Garnock-Jones-3

Tony Garnock-Jones-3 wrote

On 03/15/2017 06:28 PM, Chris Cunningham wrote:
> As a point of feedback, I find even your original change is still not
> noticeable by me (on windows with the LCD monitor that I use - I've had
> similar problems in the past, too). That said, I also prefer the Monokai
> dark, so this doesn't directly impact me, either.

Thank you! That's useful feedback. I will experiment with a more drastic
change :-)

Hi Tony,

you can also try some accent colors with transparency. :)

UserInterfaceTheme current
set: #selectionColor for: PluggableTextMorph to: (SolarizedTheme blue alpha: 0.35);
set: #unfocusedSelectionModifier for: PluggableTextMorph to: [[:c | c alpha: 0.2]];
apply.

UserInterfaceTheme current
set: #selectionColor for: PluggableTextMorph to: (SolarizedTheme darkBackgroundHighlights lighter);
set: #unfocusedSelectionModifier for: PluggableTextMorph to: [[:c | c darker ]];
apply.

Best,
Marcel

Chris Muller-3

Re: Solarized dark theme: text selection colour a little hard to see

Nice to see other folks appreciating the dark themes too.

I'm still rockin' the Community Dark theme. :)

On Thu, Jun 29, 2017 at 7:34 AM, marcel.taeumel <[hidden email]> wrote:

> Tony Garnock-Jones-3 wrote
>> On 03/15/2017 06:28 PM, Chris Cunningham wrote:
>>> As a point of feedback, I find even your original change is still not
>>> noticeable by me (on windows with the LCD monitor that I use - I've had
>>> similar problems in the past, too). That said, I also prefer the Monokai
>>> dark, so this doesn't directly impact me, either.
>>
>> Thank you! That's useful feedback. I will experiment with a more drastic
>> change :-)
>
> Hi Tony,
>
> you can also try some accent colors with transparency. :)
>
> UserInterfaceTheme current
> set: #selectionColor for: PluggableTextMorph to: (SolarizedTheme blue
> alpha: 0.35);
> set: #unfocusedSelectionModifier for: PluggableTextMorph to: [[:c | c
> alpha: 0.2]];
> apply.
>
> UserInterfaceTheme current
> set: #selectionColor for: PluggableTextMorph to: (SolarizedTheme
> darkBackgroundHighlights lighter);
> set: #unfocusedSelectionModifier for: PluggableTextMorph to: [[:c | c
> darker ]];
> apply.
>
> Best,
> Marcel
>
>
>
> --
> View this message in context: http://forum.world.st/Solarized-dark-theme-text-selection-colour-a-little-hard-to-see-tp4938685p4952917.html
> Sent from the Squeak - Dev mailing list archive at Nabble.com.
>