Smalltalk › Pharo › Pharo Smalltalk Users

Spec Label is Black on Dark theme

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

Brad Selfridge

Spec Label is Black on Dark theme

How does one change Spec labels so that they don't show as black on Dark Theme but do show as black on standard Pharo theme?

Brad Selfridge

Nicolai Hess-3-2

Re: Spec Label is Black on Dark theme

2016-08-30 20:01 GMT+02:00 Brad Selfridge <[hidden email]>:

How does one change Spec labels so that they don't show as black on Dark
Theme but do show as black on standard Pharo theme?

Looks like ListModel should overwrite #defaultColor

defaultColor
^ Smalltalk ui theme textColor

But I am not sure how spec is supposed to work with theming, maybe only the widget adapter should do this.

-----
Brad Selfridge
--
View this message in context: http://forum.world.st/Spec-Label-is-Black-on-Dark-theme-tp4913253.html
Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.

Peter Uhnak

Re: Spec Label is Black on Dark theme

On Tue, Aug 30, 2016 at 10:16:03PM +0200, Nicolai Hess wrote:

> 2016-08-30 20:01 GMT+02:00 Brad Selfridge <[hidden email]>:
>
> > How does one change Spec labels so that they don't show as black on Dark
> > Theme but do show as black on standard Pharo theme?
> >
> >
> >
> Looks like ListModel should overwrite #defaultColor
>
> defaultColor
> ^ Smalltalk ui theme textColor
>
> But I am not sure how spec is supposed to work with theming, maybe only the
> widget adapter should do this.

Spec should not do any coloring anywhere, that should be done by the underlying Moprhic.

However I think there was an issue with disabled label being render black (I had this issue in Merlin Wizard, which is in pure morphic).

But don't really have time to look into that deeply.

P

stepharo

Re: Spec Label is Black on Dark theme

In reply to this post by Nicolai Hess-3-2

Le 30/8/16 à 22:16, Nicolai Hess a écrit :

2016-08-30 20:01 GMT+02:00 Brad Selfridge <[hidden email]>:

How does one change Spec labels so that they don't show as black on Dark
Theme but do show as black on standard Pharo theme?

Looks like ListModel should overwrite #defaultColor

defaultColor
^ Smalltalk ui theme textColor

But I am not sure how spec is supposed to work with theming, maybe only the widget adapter should do this.

Me neither :)
and we never thought about it.
Now I would introduce theme in a point high in the hierarchy and provide way to set it and avoid this plague: Smalltalk ui theme

Stef

-----
Brad Selfridge
--
View this message in context: http://forum.world.st/Spec-Label-is-Black-on-Dark-theme-tp4913253.html
Sent from the Pharo Smalltalk Users mailing list archive at Nabble.com.