[Squeak 4.0] MVC Controller context menu lock up bug

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[Squeak 4.0] MVC Controller context menu lock up bug

Sam Adams-2

Downloaded everything.
1) Launched Squeak4.0-basic.image against Squeak 4.2.3beta1U.app VM
2) ctrl-click on desktop for menu
3) opened a new MVC project
4) entered new MVC project
5) ctrl-click on desktop for menu
6) opened a workspace
7) ctrl-clicked inside workspace for menu
8) system locks up... ctrl-period ineffective ... Application menu slow to respond ... File>>quit do not save

Note I tried this with several MVC tools. List menus come up fine. All text view menus tested (Workspace, Transcript, Browser, MethodFinder) locked up.
Everything seems to be working fine in Morphic tools.

Regards,
Sam


Sam S. Adams, IBM Distinguished Engineer, IBM Research
Mobile: 919-696-6064, email: [hidden email]
Asst: Kenndra K. Quiles. (732) 926-2292 Fax: (732) 926-2455, email: [hidden email]
<<Hebrews 11:6, Proverbs 3:5-6, Romans 1:16-17, I Corinthians 1:10>>


Reply | Threaded
Open this post in threaded view
|

Re: [Squeak 4.0] MVC Controller context menu lock up bug

Casey Ransberger
Yep, that sounds about right. Same stuff happened whenever I tried
playing around with MVC in 3.10.2, so I'd expect the same bugs in 4.0
(as they're virtually the same.)

On Tue, Mar 16, 2010 at 8:45 AM, Sam Adams <[hidden email]> wrote:

> Downloaded everything.
> 1) Launched Squeak4.0-basic.image against Squeak 4.2.3beta1U.app VM
> 2) ctrl-click on desktop for menu
> 3) opened a new MVC project
> 4) entered new MVC project
> 5) ctrl-click on desktop for menu
> 6) opened a workspace
> 7) ctrl-clicked inside workspace for menu
> 8) system locks up... ctrl-period ineffective ... Application menu slow to
> respond ... File>>quit do not save
>
> Note I tried this with several MVC tools. List menus come up fine. All text
> view menus tested (Workspace, Transcript, Browser, MethodFinder) locked up.
> Everything seems to be working fine in Morphic tools.
>
> Regards,
> Sam
>
>
> Sam S. Adams, IBM Distinguished Engineer, IBM Research
> Mobile: 919-696-6064, email: [hidden email]
> Asst: Kenndra K. Quiles. (732) 926-2292 Fax: (732) 926-2455, email:
> [hidden email]
> <<Hebrews 11:6, Proverbs 3:5-6, Romans 1:16-17, I Corinthians 1:10>>
>
>
>
>



--
Casey Ransberger

Reply | Threaded
Open this post in threaded view
|

Re: [Squeak 4.0] MVC Controller context menu lock up bug

Sam Adams-2

fixed in (See attached file: mvc-menu-fix-ssa.1.cs)

Files in cleanly into 4.0 and fixes the problem, which was a combination of the Debugger Notifier launch breaking in an MVC project while the text editor's CustomMenu was failing to understand addAllFrom:, which was only implemented for MenuMorph.

MVC works fine now. ;-)

Regards,
Sam


Sam S. Adams, IBM Distinguished Engineer, IBM Research
Mobile: 919-696-6064, email: [hidden email]
Asst: Kenndra K. Quiles. (732) 926-2292 Fax: (732) 926-2455, email: [hidden email]
<<Hebrews 11:6, Proverbs 3:5-6, Romans 1:16-17, I Corinthians 1:10>>


[hidden email] wrote on 03/16/2010 11:48:52 AM:

> Casey Ransberger <[hidden email]>

> Sent by: [hidden email]
>

> 03/16/2010 11:48 AM
>
> Please respond to
> The general-purpose Squeak developers list <squeak-
> [hidden email]>

>
> To

>
> The general-purpose Squeak developers list <squeak-
> [hidden email]>

>
> cc

>
> Subject

>
> Re: [squeak-dev] [Squeak 4.0] MVC Controller context menu lock up bug

>
> Yep, that sounds about right. Same stuff happened whenever I tried
> playing around with MVC in 3.10.2, so I'd expect the same bugs in 4.0
> (as they're virtually the same.)
>
> On Tue, Mar 16, 2010 at 8:45 AM, Sam Adams <[hidden email]> wrote:
> > Downloaded everything.
> > 1) Launched Squeak4.0-basic.image against Squeak 4.2.3beta1U.app VM
> > 2) ctrl-click on desktop for menu
> > 3) opened a new MVC project
> > 4) entered new MVC project
> > 5) ctrl-click on desktop for menu
> > 6) opened a workspace
> > 7) ctrl-clicked inside workspace for menu
> > 8) system locks up... ctrl-period ineffective ... Application menu slow to
> > respond ... File>>quit do not save
> >
> > Note I tried this with several MVC tools. List menus come up fine. All text
> > view menus tested (Workspace, Transcript, Browser, MethodFinder) locked up.
> > Everything seems to be working fine in Morphic tools.
> >
> > Regards,
> > Sam
> >
> >
> > Sam S. Adams, IBM Distinguished Engineer, IBM Research
> > Mobile: 919-696-6064, email: [hidden email]
> > Asst: Kenndra K. Quiles. (732) 926-2292 Fax: (732) 926-2455, email:
> > [hidden email]
> > <<Hebrews 11:6, Proverbs 3:5-6, Romans 1:16-17, I Corinthians 1:10>>
> >
> >
> >
> >
>
>
>
> --
> Casey Ransberger
>



mvc-menu-fix-ssa.1.cs (7K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [Squeak 4.0] MVC Controller context menu lock up bug

Levente Uzonyi-2
On Tue, 16 Mar 2010, Sam Adams wrote:

>
> fixed in (See attached file: mvc-menu-fix-ssa.1.cs)
>
> Files in cleanly into 4.0 and fixes the problem, which was a combination of
> the Debugger Notifier launch breaking in an MVC project while the text
> editor's CustomMenu was failing to understand addAllFrom:, which was only
> implemented for MenuMorph.
>
> MVC works fine now.  ;-)

That's nice, but this issue is already solved in the Trunk. The latest
developement snapshot is available here:
http://ftp.squeak.org/trunk/Squeak3.11-9622-alpha.zip
Press the yellow Load Code Updates button to get the latest
updates/fixes.


Levente

>
> Regards,
> Sam
>
>
Sam S. Adams, IBM Distinguished Engineer, IBM Research

> Mobile: 919-696-6064, email: [hidden email]
> Asst: Kenndra K. Quiles. (732) 926-2292 Fax: (732) 926-2455, email:
> [hidden email]
> <<Hebrews 11:6, Proverbs 3:5-6, Romans 1:16-17, I Corinthians 1:10>>
>
>
> [hidden email] wrote on 03/16/2010 11:48:52
> AM:
>
>> Casey Ransberger <[hidden email]>
>> Sent by: [hidden email]
>>
>> 03/16/2010 11:48 AM
>>
>> Please respond to
>> The general-purpose Squeak developers list <squeak-
>> [hidden email]>
>>
>> To
>>
>> The general-purpose Squeak developers list <squeak-
>> [hidden email]>
>>
>> cc
>>
>> Subject
>>
>> Re: [squeak-dev] [Squeak 4.0] MVC Controller context menu lock up bug
>>
>> Yep, that sounds about right. Same stuff happened whenever I tried
>> playing around with MVC in 3.10.2, so I'd expect the same bugs in 4.0
>> (as they're virtually the same.)
>>
>> On Tue, Mar 16, 2010 at 8:45 AM, Sam Adams <[hidden email]> wrote:
>>> Downloaded everything.
>>> 1) Launched Squeak4.0-basic.image against Squeak 4.2.3beta1U.app VM
>>> 2) ctrl-click on desktop for menu
>>> 3) opened a new MVC project
>>> 4) entered new MVC project
>>> 5) ctrl-click on desktop for menu
>>> 6) opened a workspace
>>> 7) ctrl-clicked inside workspace for menu
>>> 8) system locks up... ctrl-period ineffective ... Application menu slow
> to
>>> respond ... File>>quit do not save
>>>
>>> Note I tried this with several MVC tools. List menus come up fine. All
> text
>>> view menus tested (Workspace, Transcript, Browser, MethodFinder) locked
> up.
>>> Everything seems to be working fine in Morphic tools.
>>>
>>> Regards,
>>> Sam
>>>
>>>
>>> Sam S. Adams, IBM Distinguished Engineer, IBM Research
>>> Mobile: 919-696-6064, email: [hidden email]
>>> Asst: Kenndra K. Quiles. (732) 926-2292 Fax: (732) 926-2455, email:
>>> [hidden email]
>>> <<Hebrews 11:6, Proverbs 3:5-6, Romans 1:16-17, I Corinthians 1:10>>
>>>
>>>
>>>
>>>
>>
>>
>>
>> --
>> Casey Ransberger
>>

Reply | Threaded
Open this post in threaded view
|

Re: [Squeak 4.0] MVC Controller context menu lock up bug

David T. Lewis
On Wed, Mar 17, 2010 at 01:08:47AM +0100, Levente Uzonyi wrote:

> On Tue, 16 Mar 2010, Sam Adams wrote:
>
> >
> >fixed in (See attached file: mvc-menu-fix-ssa.1.cs)
> >
> >Files in cleanly into 4.0 and fixes the problem, which was a combination of
> >the Debugger Notifier launch breaking in an MVC project while the text
> >editor's CustomMenu was failing to understand addAllFrom:, which was only
> >implemented for MenuMorph.
> >
> >MVC works fine now.  ;-)
>
> That's nice, but this issue is already solved in the Trunk. The latest
> developement snapshot is available here:
> http://ftp.squeak.org/trunk/Squeak3.11-9622-alpha.zip
> Press the yellow Load Code Updates button to get the latest
> updates/fixes.

Umm ... yes, but MVC is quite badly broken in trunk, and any help
in bringing it back to health, especially from someone experienced
in MVC, will be *very* welcome.

Dave


Reply | Threaded
Open this post in threaded view
|

Re: [Squeak 4.0] MVC Controller context menu lock up bug

Levente Uzonyi-2
On Tue, 16 Mar 2010, David T. Lewis wrote:

> On Wed, Mar 17, 2010 at 01:08:47AM +0100, Levente Uzonyi wrote:
>> On Tue, 16 Mar 2010, Sam Adams wrote:
>>
>>>
>>> fixed in (See attached file: mvc-menu-fix-ssa.1.cs)
>>>
>>> Files in cleanly into 4.0 and fixes the problem, which was a combination of
>>> the Debugger Notifier launch breaking in an MVC project while the text
>>> editor's CustomMenu was failing to understand addAllFrom:, which was only
>>> implemented for MenuMorph.
>>>
>>> MVC works fine now.  ;-)
>>
>> That's nice, but this issue is already solved in the Trunk. The latest
>> developement snapshot is available here:
>> http://ftp.squeak.org/trunk/Squeak3.11-9622-alpha.zip
>> Press the yellow Load Code Updates button to get the latest
>> updates/fixes.
>
> Umm ... yes, but MVC is quite badly broken in trunk, and any help
> in bringing it back to health, especially from someone experienced
> in MVC, will be *very* welcome.

That's right, but adding fixes to 4.0 is pointless, since we are almost
at 4.1.


Levente

>
> Dave
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: [Squeak 4.0] MVC Controller context menu lock up bug

David T. Lewis
On Wed, Mar 17, 2010 at 02:13:49AM +0100, Levente Uzonyi wrote:

> On Tue, 16 Mar 2010, David T. Lewis wrote:
>
> >On Wed, Mar 17, 2010 at 01:08:47AM +0100, Levente Uzonyi wrote:
> >>On Tue, 16 Mar 2010, Sam Adams wrote:
> >>
> >>>
> >>>fixed in (See attached file: mvc-menu-fix-ssa.1.cs)
> >>>
> >>>Files in cleanly into 4.0 and fixes the problem, which was a combination
> >>>of
> >>>the Debugger Notifier launch breaking in an MVC project while the text
> >>>editor's CustomMenu was failing to understand addAllFrom:, which was only
> >>>implemented for MenuMorph.
> >>>
> >>>MVC works fine now.  ;-)
> >>
> >>That's nice, but this issue is already solved in the Trunk. The latest
> >>developement snapshot is available here:
> >>http://ftp.squeak.org/trunk/Squeak3.11-9622-alpha.zip
> >>Press the yellow Load Code Updates button to get the latest
> >>updates/fixes.
> >
> >Umm ... yes, but MVC is quite badly broken in trunk, and any help
> >in bringing it back to health, especially from someone experienced
> >in MVC, will be *very* welcome.
>
> That's right, but adding fixes to 4.0 is pointless, since we are almost
> at 4.1.

Fully agree.

Adding fixes to 4.0 is pointless. Fixing MVC in trunk is a Good Thing.

Dave

Reply | Threaded
Open this post in threaded view
|

Re: [Squeak 4.0] MVC Controller context menu lock up bug

Sam Adams-2
In reply to this post by Levente Uzonyi-2

Yep, I've not been involved for a long time.
But I am willing to help keep MVC alive and well as Squeak moves forward.
Happy to learn the new process. Where do I start?
Is there a master issue/bug list from the MVC side I can attack, or do I need to discover them via use?
I can already see the class/instance/comment buttons in the MVC browser are in need of repair.
I imagine there are many of the newer tools that have no support in MVC either. Priorities?
Regards,
Sam


Sam S. Adams, IBM Distinguished Engineer, IBM Research
Mobile: 919-696-6064, email: [hidden email]
Asst: Kenndra K. Quiles. (732) 926-2292 Fax: (732) 926-2455, email: [hidden email]
<<Hebrews 11:6, Proverbs 3:5-6, Romans 1:16-17, I Corinthians 1:10>>


[hidden email] wrote on 03/16/2010 09:13:49 PM:

> Levente Uzonyi <[hidden email]>

> Sent by: [hidden email]
>

> 03/16/2010 09:13 PM
>
> Please respond to
> The general-purpose Squeak developers list <squeak-
> [hidden email]>

>
> To

>
> The general-purpose Squeak developers list <squeak-
> [hidden email]>

>
> cc

>
> Subject

>
> Re: [squeak-dev] [Squeak 4.0] MVC Controller context menu lock up bug

>
> On Tue, 16 Mar 2010, David T. Lewis wrote:
>
> > On Wed, Mar 17, 2010 at 01:08:47AM +0100, Levente Uzonyi wrote:
> >> On Tue, 16 Mar 2010, Sam Adams wrote:
> >>
> >>>
> >>> fixed in (See attached file: mvc-menu-fix-ssa.1.cs)
> >>>
> >>> Files in cleanly into 4.0 and fixes the problem, which was a
> combination of
> >>> the Debugger Notifier launch breaking in an MVC project while the text
> >>> editor's CustomMenu was failing to understand addAllFrom:, which was only
> >>> implemented for MenuMorph.
> >>>
> >>> MVC works fine now.  ;-)
> >>
> >> That's nice, but this issue is already solved in the Trunk. The latest
> >> developement snapshot is available here:
> >> http://ftp.squeak.org/trunk/Squeak3.11-9622-alpha.zip
> >> Press the yellow Load Code Updates button to get the latest
> >> updates/fixes.
> >
> > Umm ... yes, but MVC is quite badly broken in trunk, and any help
> > in bringing it back to health, especially from someone experienced
> > in MVC, will be *very* welcome.
>
> That's right, but adding fixes to 4.0 is pointless, since we are almost
> at 4.1.
>
>
> Levente
>
> >
> > Dave
> >
> >
> >
>


Reply | Threaded
Open this post in threaded view
|

Re: [Squeak 4.0] MVC Controller context menu lock up bug

David T. Lewis
On Tue, Mar 16, 2010 at 09:40:26PM -0400, Sam Adams wrote:
> Yep, I've not been involved for a long time.
> But I am willing to help keep MVC alive and well as Squeak moves forward.
> Happy to learn the new process.  Where do I start?
> Is there a master issue/bug list from the MVC side I can attack, or do I
> need to discover them via use?
> I can already see the class/instance/comment buttons in the MVC browser are
> in need of repair.
> I imagine there are many of the newer tools that have no support in MVC
> either.  Priorities?

Sam,

Thanks for your interest. The Squeak community development process is
described here:

  http://squeakboard.wordpress.com/category/development/

Progress over the last year or so has been rapid, and the evolving
Squeak image is referred to as the "Squeak trunk", which is maintained
using the Monticello version control system here:

  http://source.squeak.org/@vaeYlRCfuCGzQQS2/VUsLzpdo
or:
  http://source.squeak.org/trunk/

The official bug tracking system is a Mantis system at bugs.squeak.org.
This has an issue category for "MVC", but is haphazardly updated and is
not the best place to begin (but it is still important for reporting
issues, posting fixes, and tracking issues to resolution).

The best place to start is with a recent snapshot of the trunk development
image:

  ftp://ftp.squeak.org/trunk/Squeak3.11-9622-alpha.zip

This image opens in Morphic, but you can open an MVC project to be
back in familiar, if not fully functional, territory. You will quickly
discover some opportunities for improvement ;)

The traditional update stream (based on change sets) is replaced by
an newer update stream wired in to the trunk repository. You will
see a "Load Code Updates" button to trigger the update, or just
evaluate "Utilities updateFromServer". This brings your image up
to the latest trunk development. This is safe to do at any time;
in the occasional cases where someone's update breaks the system,
it is usually fixed within hours.

Overall, MVC has suffered some bit rot over the last few years.
The things that I would judge to be highest priority concerns are:

1) "self halt" hangs the system because of failure to open a debugger
window. This may be related to changes in process scheduling that
somehow were not updated to keep the controller loop working correctly,
or it may be related to changes to debugger view construction. Whatever
the cause, it is a catch-22 for MVC debugging, because you can't
debug much of anything without a working debugger.

2) Keystroke input processing is slow and erratic, particularly
when running under a Unix VM. This is probably related to various
changes to input event processing for which MVC has not been properly
updated.

3) ToolBuilder support. Construction of views for some of the basic
tools is now done with ToolBuilder, which generalizes the construction
of views under MVC and Morphic (and hopefully other frameworks). Some
of the tool support for MVC may be incompletely implemented.

I would note also that work has been under way to partition Squeak
into reloadable packages, such that (for example) you could unload
all of MVC or all of Morphic to achieve a reduced image, and reload
these packages as needed. It is currently possible to unload and
reload all of MVC (hence achieving a Morphic-only environment), and
it hopefully will be possible in the future to similarly unload
and reload all of Morphic to obtain an MVC-only environment.

If you are able to address any problems with MVC in Squeak trunk,
change sets posted to the squeak-dev list will be gratefully received.
Posting to bug reports on Mantis is even better, and contributing
directly to the Squeak trunk is best of all. But a change set is
fine, and very welcome indeed.

Thanks,
Dave


Reply | Threaded
Open this post in threaded view
|

Re: [Squeak 4.0] MVC Controller context menu lock up bug

Bert Freudenberg
On 17.03.2010, at 04:37, David T. Lewis wrote:

>
> On Tue, Mar 16, 2010 at 09:40:26PM -0400, Sam Adams wrote:
>> Yep, I've not been involved for a long time.
>> But I am willing to help keep MVC alive and well as Squeak moves forward.
>> Happy to learn the new process.  Where do I start?
>> Is there a master issue/bug list from the MVC side I can attack, or do I
>> need to discover them via use?
>> I can already see the class/instance/comment buttons in the MVC browser are
>> in need of repair.
>> I imagine there are many of the newer tools that have no support in MVC
>> either.  Priorities?
>
> Sam,
>
> Thanks for your interest. The Squeak community development process is
> described here:
>
>  http://squeakboard.wordpress.com/category/development/
>
> Progress over the last year or so has been rapid, and the evolving
> Squeak image is referred to as the "Squeak trunk", which is maintained
> using the Monticello version control system here:
>
>  http://source.squeak.org/@vaeYlRCfuCGzQQS2/VUsLzpdo
> or:
>  http://source.squeak.org/trunk/
>
> The official bug tracking system is a Mantis system at bugs.squeak.org.
> This has an issue category for "MVC", but is haphazardly updated and is
> not the best place to begin (but it is still important for reporting
> issues, posting fixes, and tracking issues to resolution).
>
> The best place to start is with a recent snapshot of the trunk development
> image:
>
>  ftp://ftp.squeak.org/trunk/Squeak3.11-9622-alpha.zip
>
> This image opens in Morphic, but you can open an MVC project to be
> back in familiar, if not fully functional, territory. You will quickly
> discover some opportunities for improvement ;)
>
> The traditional update stream (based on change sets) is replaced by
> an newer update stream wired in to the trunk repository. You will
> see a "Load Code Updates" button to trigger the update, or just
> evaluate "Utilities updateFromServer". This brings your image up
> to the latest trunk development. This is safe to do at any time;
> in the occasional cases where someone's update breaks the system,
> it is usually fixed within hours.
>
> Overall, MVC has suffered some bit rot over the last few years.
> The things that I would judge to be highest priority concerns are:
>
> 1) "self halt" hangs the system because of failure to open a debugger
> window. This may be related to changes in process scheduling that
> somehow were not updated to keep the controller loop working correctly,
> or it may be related to changes to debugger view construction. Whatever
> the cause, it is a catch-22 for MVC debugging, because you can't
> debug much of anything without a working debugger.
>
> 2) Keystroke input processing is slow and erratic, particularly
> when running under a Unix VM. This is probably related to various
> changes to input event processing for which MVC has not been properly
> updated.
>
> 3) ToolBuilder support. Construction of views for some of the basic
> tools is now done with ToolBuilder, which generalizes the construction
> of views under MVC and Morphic (and hopefully other frameworks). Some
> of the tool support for MVC may be incompletely implemented.
>
> I would note also that work has been under way to partition Squeak
> into reloadable packages, such that (for example) you could unload
> all of MVC or all of Morphic to achieve a reduced image, and reload
> these packages as needed. It is currently possible to unload and
> reload all of MVC (hence achieving a Morphic-only environment), and
> it hopefully will be possible in the future to similarly unload
> and reload all of Morphic to obtain an MVC-only environment.
>
> If you are able to address any problems with MVC in Squeak trunk,
> change sets posted to the squeak-dev list will be gratefully received.
> Posting to bug reports on Mantis is even better, and contributing
> directly to the Squeak trunk is best of all. But a change set is
> fine, and very welcome indeed.
>
> Thanks,
> Dave


Very nice summary Dave!

I'd add that "contributing directly to the Squeak trunk" is easy - just publish your changed packages to the Inbox repo and announce here.

Looks like we need to update this wrt updating and inbox usage:
http://squeakboard.wordpress.com/category/development/
Or better even put something similar up on squeak.org. Takers? :)

- Bert -