Smalltalk › Squeak › Squeak - Dev

Squeak 5.0 Strange Commit Behavior

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

16 messages Options

marcel.taeumel

Squeak 5.0 Strange Commit Behavior

Hi there!

I just wanted to commit the regression fixes for the debugger (warnings etc.) as it is currently fixed in trunk only.

Turn out, that I get strange warnings about "[...] to serialize an empty MCZ") ... blah.

Now, everything looks changed! (See screenshot)

What's going on? How to proceed?

Best,
Marcel

David T. Lewis

Re: Squeak 5.0 Strange Commit Behavior

On Mon, Nov 02, 2015 at 04:10:47AM -0800, marcel.taeumel wrote:

I think you are working in a 4.6 image, right? The squeak46 repository had
quite a few bad MCZ files in it, presumably damaged due to some bug that
existed at the time of the 4.6 release. I think that I have replaced all of
the damaged MCZ files with good copies from trunk.

You may have copies of some of those bad MCZ files in your local package
cache. It may be necessary to do "MCFileBasedRepository flushAllCaches" and
reopen your MC browsers in order to fully clear the problem.

You may also be interested in http://www.squeaksource.com/TrunkUpdateStreamV3.
I have been tracking trunk in a 4.6 image there, and it may be easier to view
the kernel diffs there.

Dave

marcel.taeumel

Re: Squeak 5.0 Strange Commit Behavior

Hi David,

this is a fresh all-in-one 5.0 image.

Best,
Marcel

Chris Muller-3

Re: Squeak 5.0 Strange Commit Behavior

In reply to this post by marcel.taeumel

I'm not positive, but I suspect the bug is related to when trying to
save a mcz file with the an existing name in that repository that is
already used by a different version. Maybe the error-handling of that
scenario causes the one in the package-cache to be saved empty?

Not sure, but the blah warning was intended to help us track down the
root cause of empty mcz's getting saved. If you're hitting it, we
probably want to know why.

On Mon, Nov 2, 2015 at 6:10 AM, marcel.taeumel <[hidden email]> wrote:

> Hi there!
>
> I just wanted to commit the regression fixes for the debugger (warnings
> etc.) as it is currently fixed in trunk only.
>
> Turn out, that I get strange warnings about "[...] to serialize an empty
> MCZ") ... blah.
>
> Now, everything looks changed! (See screenshot)
>
> <http://forum.world.st/file/n4858951/squeak-50-bug.png>
>
> What's going on? How to proceed?
>
> Best,
> Marcel
>
>
>
>
> --
> View this message in context: http://forum.world.st/Squeak-5-0-Strange-Commit-Behavior-tp4858951.html
> Sent from the Squeak - Dev mailing list archive at Nabble.com.
>

marcel.taeumel

Re: Squeak 5.0 Strange Commit Behavior

Hi Chris,

it seems that Kernel-cmm.937 and System-cmm.756 are "broken". The diff from my changes to Kernel-cmm.936 and System-cmm.755, which are the previous versions, looks fine.

Considering that MCZs save the full snapshot anyway ... should I just commit? =)

The Tools-cmm.629 looks fine and diffs fine.

I touched all packages with this code:

repo := MCRepositoryGroup default repositories detect: [:repo | repo description endsWith: 'squeak50'].

PackageOrganizer default packages do: [:pkg |
[(pkg mcPackage workingCopy changesRelativeToRepository: repo)
isEmpty ifFalse: [pkg mcPackage workingCopy modified: true]]
on: Warning do: [:warning |
Transcript showln: pkg name; showln: warning messageText.
warning resume]].

This is what I got:

Best,
Marcel

Levente Uzonyi-2

Re: Squeak 5.0 Strange Commit Behavior

If Dave has fixed all packages in the 4.6 repository, and the packages in
the 4.6 and the 5.0 repositories are meant to be the same, then wouldn't
it be easier to just copy over these packages from the 4.6 repository?

Levente

On Tue, 3 Nov 2015, marcel.taeumel wrote:

> Hi Chris,
>
> it seems that Kernel-cmm.937 and System-cmm.756 are "broken". The diff from
> my changes to Kernel-cmm.936 and System-cmm.755, which are the previous
> versions, looks fine.
>
> Considering that MCZs save the full snapshot anyway ... should I just
> commit? =)
>
> The Tools-cmm.629 looks fine and diffs fine.
>
> I touched all packages with this code:
>
> repo := MCRepositoryGroup default repositories detect: [:repo | repo
> description endsWith: 'squeak50'].
>
> PackageOrganizer default packages do: [:pkg |
> [(pkg mcPackage workingCopy changesRelativeToRepository: repo)
> isEmpty ifFalse: [pkg mcPackage workingCopy modified: true]]
> on: Warning do: [:warning |
> Transcript showln: pkg name; showln: warning messageText.
> warning resume]].
>
> This is what I got:
>
> <http://forum.world.st/file/n4859057/squeak-50-empty-mcz.png>
>
> Best,
> Marcel
>
>
>
> --
> View this message in context: http://forum.world.st/Squeak-5-0-Strange-Commit-Behavior-tp4858951p4859057.html
> Sent from the Squeak - Dev mailing list archive at Nabble.com.
>
>

Eliot Miranda-2

Re: Squeak 5.0 Strange Commit Behavior

Hi Levente,

> On Nov 3, 2015, at 3:10 AM, Levente Uzonyi <[hidden email]> wrote:
>
> If Dave has fixed all packages in the 4.6 repository, and the packages in the 4.6 and the 5.0 repositories are meant to be the same, then wouldn't it be easier to just copy over these packages from the 4.6 repository?

Remember that Collections, Compiler, Kernel and System are the four packages that are definitely different between Spur/5.0 and V3/4.6. So can people check their package caches and find non-empty versions? I'll do this first thing. I expect I have ok versions because I've not used 4.6 yet.

>
> Levente
>
>> On Tue, 3 Nov 2015, marcel.taeumel wrote:
>>
>> Hi Chris,
>>
>> it seems that Kernel-cmm.937 and System-cmm.756 are "broken". The diff from
>> my changes to Kernel-cmm.936 and System-cmm.755, which are the previous
>> versions, looks fine.
>>
>> Considering that MCZs save the full snapshot anyway ... should I just
>> commit? =)
>>
>> The Tools-cmm.629 looks fine and diffs fine.
>>
>> I touched all packages with this code:
>>
>> repo := MCRepositoryGroup default repositories detect: [:repo | repo
>> description endsWith: 'squeak50'].
>>
>> PackageOrganizer default packages do: [:pkg |
>> [(pkg mcPackage workingCopy changesRelativeToRepository: repo)
>> isEmpty ifFalse: [pkg mcPackage workingCopy modified: true]]
>> on: Warning do: [:warning |
>> Transcript showln: pkg name; showln: warning messageText.
>> warning resume]].
>>
>> This is what I got:
>>
>> <http://forum.world.st/file/n4859057/squeak-50-empty-mcz.png>
>>
>> Best,
>> Marcel
>>
>>
>>
>> --
>> View this message in context: http://forum.world.st/Squeak-5-0-Strange-Commit-Behavior-tp4858951p4859057.html
>> Sent from the Squeak - Dev mailing list archive at Nabble.com.
>

Levente Uzonyi-2

Re: Squeak 5.0 Strange Commit Behavior

My bad. It's still too early in the morning.

Levente

On Tue, 3 Nov 2015, Eliot Miranda wrote:

> Hi Levente,
>
>> On Nov 3, 2015, at 3:10 AM, Levente Uzonyi <[hidden email]> wrote:
>>
>> If Dave has fixed all packages in the 4.6 repository, and the packages in the 4.6 and the 5.0 repositories are meant to be the same, then wouldn't it be easier to just copy over these packages from the 4.6 repository?
>
> Remember that Collections, Compiler, Kernel and System are the four packages that are definitely different between Spur/5.0 and V3/4.6. So can people check their package caches and find non-empty versions? I'll do this first thing. I expect I have ok versions because I've not used 4.6 yet.
>
>>
>> Levente
>>
>>> On Tue, 3 Nov 2015, marcel.taeumel wrote:
>>>
>>> Hi Chris,
>>>
>>> it seems that Kernel-cmm.937 and System-cmm.756 are "broken". The diff from
>>> my changes to Kernel-cmm.936 and System-cmm.755, which are the previous
>>> versions, looks fine.
>>>
>>> Considering that MCZs save the full snapshot anyway ... should I just
>>> commit? =)
>>>
>>> The Tools-cmm.629 looks fine and diffs fine.
>>>
>>> I touched all packages with this code:
>>>
>>> repo := MCRepositoryGroup default repositories detect: [:repo | repo
>>> description endsWith: 'squeak50'].
>>>
>>> PackageOrganizer default packages do: [:pkg |
>>> [(pkg mcPackage workingCopy changesRelativeToRepository: repo)
>>> isEmpty ifFalse: [pkg mcPackage workingCopy modified: true]]
>>> on: Warning do: [:warning |
>>> Transcript showln: pkg name; showln: warning messageText.
>>> warning resume]].
>>>
>>> This is what I got:
>>>
>>> <http://forum.world.st/file/n4859057/squeak-50-empty-mcz.png>
>>>
>>> Best,
>>> Marcel
>>>
>>>
>>>
>>> --
>>> View this message in context: http://forum.world.st/Squeak-5-0-Strange-Commit-Behavior-tp4858951p4859057.html
>>> Sent from the Squeak - Dev mailing list archive at Nabble.com.
>>
>
>

David T. Lewis

Re: Squeak 5.0 Strange Commit Behavior

In reply to this post by marcel.taeumel

On Tue, Nov 03, 2015 at 01:34:15AM -0800, marcel.taeumel wrote:
> Hi Chris,
>
> it seems that Kernel-cmm.937 and System-cmm.756 are "broken". The diff from
> my changes to Kernel-cmm.936 and System-cmm.755, which are the previous
> versions, looks fine.
>
> Considering that MCZs save the full snapshot anyway ... should I just
> commit? =)

I expect you can commit without problems. To be extra safe, you can commit
to your own package-cache, then copy the result from package-cache to trunk
if you are happy with the result.

Dave

>
> The Tools-cmm.629 looks fine and diffs fine.
>
> I touched all packages with this code:
>
> repo := MCRepositoryGroup default repositories detect: [:repo | repo
> description endsWith: 'squeak50'].
>
> PackageOrganizer default packages do: [:pkg |
> [(pkg mcPackage workingCopy changesRelativeToRepository: repo)
> isEmpty ifFalse: [pkg mcPackage workingCopy modified: true]]
> on: Warning do: [:warning |
> Transcript showln: pkg name; showln: warning messageText.
> warning resume]].
>
> This is what I got:
>
> <http://forum.world.st/file/n4859057/squeak-50-empty-mcz.png>
>
> Best,
> Marcel
>
>
>
> --
> View this message in context: http://forum.world.st/Squeak-5-0-Strange-Commit-Behavior-tp4858951p4859057.html
> Sent from the Squeak - Dev mailing list archive at Nabble.com.

marcel.taeumel

Re: Squeak 5.0 Strange Commit Behavior

In reply to this post by Eliot Miranda-2

Thanks for looking!

Best,
Marcel

Eliot Miranda-2

Re: Squeak 5.0 Strange Commit Behavior

In reply to this post by Levente Uzonyi-2

On Tue, Nov 3, 2015 at 7:08 AM, Levente Uzonyi <[hidden email]> wrote:

My bad. It's still too early in the morning.

:) I can join you. Today I put my freshly ground coffee into my mug, not the caffetiere :-/

Levente

On Tue, 3 Nov 2015, Eliot Miranda wrote:

Hi Levente,

On Nov 3, 2015, at 3:10 AM, Levente Uzonyi <[hidden email]> wrote:

If Dave has fixed all packages in the 4.6 repository, and the packages in the 4.6 and the 5.0 repositories are meant to be the same, then wouldn't it be easier to just copy over these packages from the 4.6 repository?

Remember that Collections, Compiler, Kernel and System are the four packages that are definitely different between Spur/5.0 and V3/4.6. So can people check their package caches and find non-empty versions? I'll do this first thing. I expect I have ok versions because I've not used 4.6 yet.

Levente

On Tue, 3 Nov 2015, marcel.taeumel wrote:

Hi Chris,

it seems that Kernel-cmm.937 and System-cmm.756 are "broken". The diff from
my changes to Kernel-cmm.936 and System-cmm.755, which are the previous
versions, looks fine.

Considering that MCZs save the full snapshot anyway ... should I just
commit? =)

The Tools-cmm.629 looks fine and diffs fine.

I touched all packages with this code:

repo := MCRepositoryGroup default repositories detect: [:repo | repo
description endsWith: 'squeak50'].

PackageOrganizer default packages do: [:pkg |
[(pkg mcPackage workingCopy changesRelativeToRepository: repo)
isEmpty ifFalse: [pkg mcPackage workingCopy modified: true]]
on: Warning do: [:warning |
Transcript showln: pkg name; showln: warning messageText.
warning resume]].

This is what I got:

<http://forum.world.st/file/n4859057/squeak-50-empty-mcz.png>

Best,
Marcel

--
View this message in context: http://forum.world.st/Squeak-5-0-Strange-Commit-Behavior-tp4858951p4859057.html
Sent from the Squeak - Dev mailing list archive at Nabble.com.

_,,,^..^,,,_

best, Eliot

Eliot Miranda-2

Re: Squeak 5.0 Strange Commit Behavior

In reply to this post by marcel.taeumel

On Tue, Nov 3, 2015 at 12:20 PM, marcel.taeumel <[hidden email]> wrote:

Thanks for looking!

No luck :-( Nothing on either of my machines.

Best,
Marcel

--
View this message in context: http://forum.world.st/Squeak-5-0-Strange-Commit-Behavior-tp4858951p4859096.html

Sent from the Squeak - Dev mailing list archive at Nabble.com.

_,,,^..^,,,_

best, Eliot

marcel.taeumel

Re: Squeak 5.0 Strange Commit Behavior

There seem to be good versions in the trunk. I will try copying them over (again).

Best,
Marcel

marcel.taeumel

Re: Squeak 5.0 Strange Commit Behavior

Success! Well, almost... ;-)

Best,
Marcel

Chris Muller-3

Re: Squeak 5.0 Strange Commit Behavior

Did you try clearing your package-cache of the offending versions?

When I tried your script, it worked fine for me..

On Wed, Nov 4, 2015 at 1:11 AM, marcel.taeumel <[hidden email]> wrote:

> Success! Well, almost... ;-)
>
> <http://forum.world.st/file/n4859134/squeak-50-empty-mcz-2.png>
>
> Best,
> Marcel
>
>
>
> --
> View this message in context: http://forum.world.st/Squeak-5-0-Strange-Commit-Behavior-tp4858951p4859134.html
> Sent from the Squeak - Dev mailing list archive at Nabble.com.
>

marcel.taeumel

Re: Squeak 5.0 Strange Commit Behavior

I did. The following versions are still empty/broken:

Exceptions-cmm.49.mcz (23 January 2014)
ScriptLoader-cmm.338.mcz (23 January 2014)
FlexibleVocabularies-bf.13.mcz (11 September 2013)
Squeak-Version-ar.4662.mcz (12 December 2009)

You can browse them on source.squeak.org (http://source.squeak.org/squeak50/). They are empty.

Best,
Marcel