Still Failing: OpenSmalltalk/opensmalltalk-vm#2229 (Cog - 7deac02)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Still Failing: OpenSmalltalk/opensmalltalk-vm#2229 (Cog - 7deac02)

Travis CI
 

OpenSmalltalk

/

opensmalltalk-vm

branch iconCog

arrow to build time
clock icon10 mins and 25 secs

Eliot Miranda avatarEliot Miranda

Unix(macOS) SocketPlugin:
Fix sendDone/primtiveSocketSendDone/sqSocketSendDone on macOS. The select in
socketWritable does not answer true for writable sockets, presumably because
the select in aioPoll already has done. So have dataHandler (which is called
from aioPoll when the socket *is* writable) set a flag in privateSocketStruct
notifiedOfWritability and use this to avoid the wrongly unsuccessful call of
select in sqSocketSendDone. Clear notifiedOfWritability before any and all send/
write system calls.
Have sqWin32NewNet.c process the select result in its socketWritable in exactly
the same way as sqUnixSocket.c's.

I WELCOME ANY REVIEW OF THIS COMMIT!! Levente, Tobias, you might take a close
look at this one.

Want to know about upcoming build environment updates?

Would you like to stay up-to-date with the upcoming Travis CI build environment updates? We set up a mailing list for you!

SIGN UP HERE
book icon

Documentation about Travis CI

<script type="application/ld+json"> { "@context": "http://schema.org", "@type": "EmailMessage", "action": { "@type": "ViewAction", "url": "https://travis-ci.org/github/OpenSmalltalk/opensmalltalk-vm/builds/734179980?utm_medium=notification&amp;utm_source=email", "name": "View Build" }, "description": "View Build #2229 on Travis CI" } </script>