StringHolder >> #packageListKey:from:

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

StringHolder >> #packageListKey:from:

Frank Shearar-3
The above method doesn't belong in StringHolder, but I'm not sure
where it _does_ belong. A comment in it refers to PackageBrowser,
which we don't have. We _do_ have a PackagePaneBrowser though, which
would make a good home for the method.

So is the comment just out of date? Have I missed something?

This would sever another link between Kernel-Models and Tools, which I
count as a good thing!

frank

Reply | Threaded
Open this post in threaded view
|

Re: StringHolder >> #packageListKey:from:

Frank Shearar-3
On 12 December 2012 13:19, Frank Shearar <[hidden email]> wrote:
> The above method doesn't belong in StringHolder, but I'm not sure
> where it _does_ belong. A comment in it refers to PackageBrowser,
> which we don't have. We _do_ have a PackagePaneBrowser though, which
> would make a good home for the method.
>
> So is the comment just out of date? Have I missed something?

DependencyBrowser also uses it, so I'll _copy_ the method to both it
and PPB. (The method doesn't belong on Browser either, which is the
least common superclass of the two classes.)

> This would sever another link between Kernel-Models and Tools, which I
> count as a good thing!
>
> frank