Smalltalk › Squeak › Squeak VM

Suspect single float types

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

Nicolas Cellier

Suspect single float types

I read in CCodeGenerator>>computeKernelReturnTypes

        fetchFloatAt:into: #float storeFloatAt:from: #float
            fetchFloatAtPointer:into: #float storeFloatAtPointer:from: #float
        fetchSingleFloatAt:into: #float storeSingleFloatAt:from: #float
            fetchSingleFloatAtPointer:into: #float storeSingleFloatAtPointer:from: #float

Ain't these #double?

Nicolas Cellier

Re: Suspect single float types

2013-12-28 14:55 GMT+01:00 Nicolas Cellier <[hidden email]>:

I read in CCodeGenerator>>computeKernelReturnTypes

        fetchFloatAt:into: #float storeFloatAt:from: #float
            fetchFloatAtPointer:into: #float storeFloatAtPointer:from: #float
        fetchSingleFloatAt:into: #float storeSingleFloatAt:from: #float
            fetchSingleFloatAtPointer:into: #float storeSingleFloatAtPointer:from: #float

Ain't these #double?

Hi Eliot,
this still sounds suspect to me, fetchSingleFloat might be a float but shouldn't fetchFloat map to double?
Or did I miss the answer ?

Eliot Miranda-2

Re: Suspect single float types

Hi Nicolas.

On Sun, Apr 27, 2014 at 6:13 AM, Nicolas Cellier <[hidden email]> wrote:

2013-12-28 14:55 GMT+01:00 Nicolas Cellier <[hidden email]>:

I read in CCodeGenerator>>computeKernelReturnTypes

        fetchFloatAt:into: #float storeFloatAt:from: #float
            fetchFloatAtPointer:into: #float storeFloatAtPointer:from: #float
        fetchSingleFloatAt:into: #float storeSingleFloatAt:from: #float
            fetchSingleFloatAtPointer:into: #float storeSingleFloatAtPointer:from: #float

Ain't these #double?

Hi Eliot,
this still sounds suspect to me, fetchSingleFloat might be a float but shouldn't fetchFloat map to double?
Or did I miss the answer ?

Ha, good to check. In fact the correct return type for them is void. They're all macros and they fetch and store from/into their last argument.

Thanks!

--
best,

Eliot