Symbol > OneCharacterSymbols

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Symbol > OneCharacterSymbols

marcel.taeumel
Hi, there.

Can we safely remove the class variable "OneCharacterSymbols" in Symbol?

Best,
Marcel


Reply | Threaded
Open this post in threaded view
|

Re: Symbol > OneCharacterSymbols

Levente Uzonyi
Hi Marcel,

I always thought that it's only there to keep those symbol instances
alive. Perhaps the VM needed those in the old days.
I just removed it in my image, compacted the symbol table, and saw no
negative consequences, so I think it's safe to remove it.

Levente


On Thu, 11 Jul 2019, Marcel Taeumel wrote:

> Hi, there.
>
> Can we safely remove the class variable "OneCharacterSymbols" in Symbol?
>
> Best,
> Marcel
>
>

Reply | Threaded
Open this post in threaded view
|

Re: Symbol > OneCharacterSymbols

David T. Lewis
+1 for removing OneCharacterSymbols.

Also remove Symbol>>internCharacter and update its only sender to be:

Character>>asSymbol
        "Answer a Symbol consisting of the receiver as the only element."

        ^Symbol intern: self asString



I think that the last use of it was eliminated here:

   Name: Collections-nice.535
   Author: nice
   Time: 8 September 2013, 10:22:51.173 pm
   UUID: 51a740f5-7aa3-452b-aff4-bfeadb8e4ce5
   Ancestors: Collections-cmm.534
   
   Remove OneCharacterSymbols optimization since it is presumed
   quasi-unused, at least since recent Scanner change.


Dave


On Fri, Jul 12, 2019 at 12:34:36AM +0200, Levente Uzonyi wrote:

> Hi Marcel,
>
> I always thought that it's only there to keep those symbol instances
> alive. Perhaps the VM needed those in the old days.
> I just removed it in my image, compacted the symbol table, and saw no
> negative consequences, so I think it's safe to remove it.
>
> Levente
>
>
> On Thu, 11 Jul 2019, Marcel Taeumel wrote:
>
> >Hi, there.
> >
> >Can we safely remove the class variable "OneCharacterSymbols" in Symbol?
> >
> >Best,
> >Marcel
> >
> >
>