TextMorph >> #fit broken?

m := Morph new.

m openInHand.

m extent: 300 @ 200.

m cellPositioning: #center.

m changeTableLayout.

t := TextMorph new

contents: 'Hello world';

yourself.

t autoFit: true.

t container

> Is this really what we want?

Am 30.09.2019 12:42:57 schrieb Thiede, Christoph <[hidden email]>:

Hi all,

can you reproduce the following?

I assume it this bug was revealed (not caused) by Morphic-mt.1520, so by default, each TextMorph now has the wrapFlag true. Is this really what we want?

Minimal example to reproduce:

m := Morph new.

m openInHand.

m extent: 300 @ 200.

m cellPositioning: #center.

m changeTableLayout.

t := TextMorph new

contents: 'Hello world';

yourself.

t autoFit: true.

t container

Works before, does not work after the recent commit.

Should we maybe initialize wrapFlag with false, in order to revert the behavior from before Morphic-mt.1520? I know also other implementations, aside from Trunk, which are failing after the update.

Best,

Christoph

... TextMorph >> #fit works as expected in this case. :-)

Am 30.09.2019 13:30:04 schrieb Marcel Taeumel <[hidden email]>:

> Is this really what we want?

Maybe, maybe not. We cannot know without context information. :-) I suppose it should be "false" by default. In the MenuMorph, however, I would assume that the filter text was not initialized correctly.

Best,

Marcel

Am 30.09.2019 12:42:57 schrieb Thiede, Christoph <[hidden email]>:

Hi all,

can you reproduce the following?

I assume it this bug was revealed (not caused) by Morphic-mt.1520, so by default, each TextMorph now has the wrapFlag true. Is this really what we want?

Minimal example to reproduce:

m := Morph new.

m openInHand.

m extent: 300 @ 200.

m cellPositioning: #center.

m changeTableLayout.

t := TextMorph new

contents: 'Hello world';

yourself.

t autoFit: true.

t container

Works before, does not work after the recent commit.

Should we maybe initialize wrapFlag with false, in order to revert the behavior from before Morphic-mt.1520? I know also other implementations, aside from Trunk, which are failing after the update.

Best,

Christoph

Another thought: Since the older meaning of TextMorph >> #contents: was to reset the wrapFlag to "false" we might want to fix all those cases:

Am 30.09.2019 13:33:40 schrieb Marcel Taeumel <[hidden email]>:

... TextMorph >> #fit works as expected in this case. :-)

Best,

Marcel

Am 30.09.2019 13:30:04 schrieb Marcel Taeumel <[hidden email]>:

> Is this really what we want?

Maybe, maybe not. We cannot know without context information. :-) I suppose it should be "false" by default. In the MenuMorph, however, I would assume that the filter text was not initialized correctly.

Best,

Marcel

Am 30.09.2019 12:42:57 schrieb Thiede, Christoph <[hidden email]>:

Hi all,

can you reproduce the following?

I assume it this bug was revealed (not caused) by Morphic-mt.1520, so by default, each TextMorph now has the wrapFlag true. Is this really what we want?

Minimal example to reproduce:

m := Morph new.

m openInHand.

m extent: 300 @ 200.

m cellPositioning: #center.

m changeTableLayout.

t := TextMorph new

contents: 'Hello world';

yourself.

t autoFit: true.

t container

Works before, does not work after the recent commit.

Should we maybe initialize wrapFlag with false, in order to revert the behavior from before Morphic-mt.1520? I know also other implementations, aside from Trunk, which are failing after the update.

Best,

Christoph