Smalltalk › Squeak › Squeak - Dev

The Inbox: 60Deprecated-nice.94.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

commits-2

The Inbox: 60Deprecated-nice.94.mcz

Nicolas Cellier uploaded a new version of 60Deprecated to project The Inbox:
http://source.squeak.org/inbox/60Deprecated-nice.94.mcz

==================== Summary ====================

Name: 60Deprecated-nice.94
Author: nice
Time: 13 April 2021, 12:10:09.32989 pm
UUID: 2efd14b2-b4f1-3247-848e-c5f8f0ef9ced
Ancestors: 60Deprecated-dtl.93

Deprecate Symbol findInterned: aString in favour of lookup:

BEWARE: #findInterned: is an old dialect that might still be used by a Number of external packages, including refactoring browser.

This must be discussed.

=============== Diff against 60Deprecated-dtl.93 ===============

Item was added:
+ ----- Method: Symbol class>>findInterned: (in category '*60Deprecated-instance creation') -----
+ findInterned: aString
+
+ self deprecated: 'Use #lookup: instead.'.
+ ^ self lookup: aString!

marcel.taeumel

Re: The Inbox: 60Deprecated-nice.94.mcz

Hi Nicolas,

actually deprecating Symbol API is often dangerous. Especially since Monticello installs moved methods before other changes. I vote for "self flag: #deprecated" or an extra checkpoint in Squeak's update map.

Best,

Marcel

Am 13.04.2021 12:10:22 schrieb [hidden email] <[hidden email]>:
Nicolas Cellier uploaded a new version of 60Deprecated to project The Inbox:
http://source.squeak.org/inbox/60Deprecated-nice.94.mcz

==================== Summary ====================

Name: 60Deprecated-nice.94
Author: nice
Time: 13 April 2021, 12:10:09.32989 pm
UUID: 2efd14b2-b4f1-3247-848e-c5f8f0ef9ced
Ancestors: 60Deprecated-dtl.93

Deprecate Symbol findInterned: aString in favour of lookup:

BEWARE: #findInterned: is an old dialect that might still be used by a Number of external packages, including refactoring browser.

This must be discussed.

=============== Diff against 60Deprecated-dtl.93 ===============

Item was added:
+ ----- Method: Symbol class>>findInterned: (in category '*60Deprecated-instance creation') -----
+ findInterned: aString
+
+ self deprecated: 'Use #lookup: instead.'.
+ ^ self lookup: aString!

Nicolas Cellier

Re: The Inbox: 60Deprecated-nice.94.mcz

It's in the inbox precisely for discussion :)

Le mar. 13 avr. 2021 à 12:13, Marcel Taeumel <[hidden email]> a écrit :

>
> Hi Nicolas,
>
> actually deprecating Symbol API is often dangerous. Especially since Monticello installs moved methods before other changes. I vote for "self flag: #deprecated" or an extra checkpoint in Squeak's update map.
>
> Best,
> Marcel
>
> Am 13.04.2021 12:10:22 schrieb [hidden email] <[hidden email]>:
>
> Nicolas Cellier uploaded a new version of 60Deprecated to project The Inbox:
> http://source.squeak.org/inbox/60Deprecated-nice.94.mcz
>
> ==================== Summary ====================
>
> Name: 60Deprecated-nice.94
> Author: nice
> Time: 13 April 2021, 12:10:09.32989 pm
> UUID: 2efd14b2-b4f1-3247-848e-c5f8f0ef9ced
> Ancestors: 60Deprecated-dtl.93
>
> Deprecate Symbol findInterned: aString in favour of lookup:
>
> BEWARE: #findInterned: is an old dialect that might still be used by a Number of external packages, including refactoring browser.
>
> This must be discussed.
>
> =============== Diff against 60Deprecated-dtl.93 ===============
>
> Item was added:
> + ----- Method: Symbol class>>findInterned: (in category '*60Deprecated-instance creation') -----
> + findInterned: aString
> +
> + self deprecated: 'Use #lookup: instead.'.
> + ^ self lookup: aString!
>
>
>

marcel.taeumel

Re: The Inbox: 60Deprecated-nice.94.mcz

:-)

+1 for deprecating it somehow

-1 for using #deprecated: (also for the sake of backwards compatibility in other projects)

Best,

Marcel

Am 13.04.2021 12:20:45 schrieb Nicolas Cellier <[hidden email]>:
It's in the inbox precisely for discussion :)

Le mar. 13 avr. 2021 à 12:13, Marcel Taeumel a écrit :

>
> Hi Nicolas,
>
> actually deprecating Symbol API is often dangerous. Especially since Monticello installs moved methods before other changes. I vote for "self flag: #deprecated" or an extra checkpoint in Squeak's update map.
>
> Best,
> Marcel
>
> Am 13.04.2021 12:10:22 schrieb [hidden email] :
>
> Nicolas Cellier uploaded a new version of 60Deprecated to project The Inbox:
> http://source.squeak.org/inbox/60Deprecated-nice.94.mcz
>
> ==================== Summary ====================
>
> Name: 60Deprecated-nice.94
> Author: nice
> Time: 13 April 2021, 12:10:09.32989 pm
> UUID: 2efd14b2-b4f1-3247-848e-c5f8f0ef9ced
> Ancestors: 60Deprecated-dtl.93
>
> Deprecate Symbol findInterned: aString in favour of lookup:
>
> BEWARE: #findInterned: is an old dialect that might still be used by a Number of external packages, including refactoring browser.
>
> This must be discussed.
>
> =============== Diff against 60Deprecated-dtl.93 ===============
>
> Item was added:
> + ----- Method: Symbol class>>findInterned: (in category '*60Deprecated-instance creation') -----
> + findInterned: aString
> +
> + self deprecated: 'Use #lookup: instead.'.
> + ^ self lookup: aString!
>
>
>