The Inbox: EToys-ct.389.mcz

(MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w |

| packageSnapshot parentSnapshot patch |

parentSnapshot := w parentSnapshot.

patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot.

patch isEmpty not]

"{a MCWorkingCopy(EToys)}"

Btw: Do you think that this script could be a useful CI test?

Am 07.04.2020 13:27:58 schrieb Thiede, Christoph <[hidden email]>:

Btw: Do you think that this script could be a useful CI test?

modifiedPackages := (MCWorkingCopy allManagers sorted: [:w | w package name] ascending)

select: [:w |

| packageSnapshot parentSnapshot patch |

parentSnapshot := w parentSnapshot.

patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot.

patch isEmpty not]

thenCollect: [:w | w package].

self assert: [modifiedPackages isEmpty] description: ('The following packages have unaccepted changes: {1}' translated format: {modifiedPackages}).

Best,

Christoph

---

Von: Thiede, Christoph
Gesendet: Sonntag, 5. April 2020 21:38:21
An: [hidden email]
Betreff: AW: [squeak-dev] The Inbox: EToys-ct.389.mcz

 

FYI: I rechecked all other packages, too, by updating a fresh #19428 image to the latest #19559. All other packages were clean:

(MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w |

| packageSnapshot parentSnapshot patch |

parentSnapshot := w parentSnapshot.

patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot.

patch isEmpty not]

"{a MCWorkingCopy(EToys)}"

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Sonntag, 5. April 2020 21:13 Uhr
An: [hidden email]
Betreff: [squeak-dev] The Inbox: EToys-ct.389.mcz

 

A new version of EToys was added to project The Inbox:
http://source.squeak.org/inbox/EToys-ct.389.mcz

==================== Summary ====================

Name: EToys-ct.389
Author: xyz
Time: 5 April 2020, 9:12:49.970061 pm
UUID: 843215f1-865c-2e4b-8c42-484a3f382840
Ancestors: EToys-eem.388

Removes extension methods in deprecated class TextMorphEditor. Complements Squeak-Version-mt.5252. Thanks to Subbu (kks) for the report!

=============== Diff against EToys-eem.388 ===============

Item was removed:
- ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') -----
- select
-        "Ignore selection redraw requests."!

Item was removed:
- ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') -----
- selectionInterval: anInterval
-        "Make my selection span the indicated interval.  If the interval extends outside the range of characters of the current text, force it within."
-
-        | mySize |
-        mySize := paragraph text string size.
-        self selectFrom: (anInterval start min: mySize)
-                to:     (anInterval stop min: mySize)!

Am 07.04.2020 14:08:29 schrieb Thiede, Christoph <[hidden email]>:

Wow, I have reinvented the wheel ... Thanks for the tip!

However, does anyone press this button manually? Wouldn't it be helpful if we had an automatic test for it?

testNoChangesInWorkingCopies

modifiedPackages := MCWorkingCopy allManagers

    select: [:w | w checkModified; modified]

    thenCollect: [:w | w package].

self

    assert: [modifiedPackages isEmpty]

    description: ('The following packages have unaccepted changes: {1}' translated format: {modifiedPackages}).

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Dienstag, 7. April 2020 13:50:30
An: gettimothy via Squeak-dev
Betreff: Re: [squeak-dev] The Inbox: EToys-ct.389.mcz

 

Am 07.04.2020 13:27:58 schrieb Thiede, Christoph <[hidden email]>:

Btw: Do you think that this script could be a useful CI test?

modifiedPackages := (MCWorkingCopy allManagers sorted: [:w | w package name] ascending)

select: [:w |

| packageSnapshot parentSnapshot patch |

parentSnapshot := w parentSnapshot.

patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot.

patch isEmpty not]

thenCollect: [:w | w package].

self assert: [modifiedPackages isEmpty] description: ('The following packages have unaccepted changes: {1}' translated format: {modifiedPackages}).

Best,

Christoph

---

Von: Thiede, Christoph
Gesendet: Sonntag, 5. April 2020 21:38:21
An: [hidden email]
Betreff: AW: [squeak-dev] The Inbox: EToys-ct.389.mcz

 

FYI: I rechecked all other packages, too, by updating a fresh #19428 image to the latest #19559. All other packages were clean:

(MCWorkingCopy allManagers sorted: [:w | w package name] ascending) select: [:w |

| packageSnapshot parentSnapshot patch |

parentSnapshot := w parentSnapshot.

patch := (packageSnapshot := w package snapshot) patchRelativeToBase: parentSnapshot.

patch isEmpty not]

"{a MCWorkingCopy(EToys)}"

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Sonntag, 5. April 2020 21:13 Uhr
An: [hidden email]
Betreff: [squeak-dev] The Inbox: EToys-ct.389.mcz

 

A new version of EToys was added to project The Inbox:
http://source.squeak.org/inbox/EToys-ct.389.mcz

==================== Summary ====================

Name: EToys-ct.389
Author: xyz
Time: 5 April 2020, 9:12:49.970061 pm
UUID: 843215f1-865c-2e4b-8c42-484a3f382840
Ancestors: EToys-eem.388

Removes extension methods in deprecated class TextMorphEditor. Complements Squeak-Version-mt.5252. Thanks to Subbu (kks) for the report!

=============== Diff against EToys-eem.388 ===============

Item was removed:
- ----- Method: TextMorphEditor>>select (in category '*Etoys-Squeakland-current selection') -----
- select
-        "Ignore selection redraw requests."!

Item was removed:
- ----- Method: TextMorphEditor>>selectionInterval: (in category '*Etoys-Squeakland-private') -----
- selectionInterval: anInterval
-        "Make my selection span the indicated interval.  If the interval extends outside the range of characters of the current text, force it within."
-
-        | mySize |
-        mySize := paragraph text string size.
-        self selectFrom: (anInterval start min: mySize)
-                to:     (anInterval stop min: mySize)!