The Inbox: EToys-kfr.414.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: EToys-kfr.414.mcz

commits-2
A new version of EToys was added to project The Inbox:
http://source.squeak.org/inbox/EToys-kfr.414.mcz

==================== Summary ====================

Name: EToys-kfr.414
Author: kfr
Time: 31 October 2020, 8:58:48.943742 pm
UUID: 5e186cb9-67d7-124d-901e-ae50d4bacbe8
Ancestors: EToys-eem.413

self world returns nil when the morph is not visible/ opened yet

=============== Diff against EToys-eem.413 ===============

Item was changed:
  ----- Method: CategoryViewer>>assureCategoryFullyVisible (in category '*Etoys-Squeakland-categories') -----
  assureCategoryFullyVisible
  "Keep deleting categoryviewers other than the receiver  until the receiver is fully visible."
 
  | ready toDelete |
  ready := false.
+ [(self bounds bottom > Project current world bottom) and: [ready not]] whileTrue: [
- [(self bounds bottom > self world bottom) and: [ready not]] whileTrue: [
  owner submorphs size > 2
  ifTrue: [
  toDelete := owner submorphs allButFirst reversed
  detect: [:cv | cv ~~ self]
  ifNone: [^ self].
  toDelete delete.
  self world doOneCycleNow]
  ifFalse: [
  ready := true]].!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.414.mcz

Christoph Thiede

Hi Karl,


iirc, in Morphic code you should prefer self currentWorld over Project current world. See these guidelines by Marcel: http://forum.world.st/Changeset-Eliminating-global-state-from-Morphic-tp5121690p5123334.html :-)


Best,

Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Samstag, 31. Oktober 2020 20:59:05
An: [hidden email]
Betreff: [squeak-dev] The Inbox: EToys-kfr.414.mcz
 
A new version of EToys was added to project The Inbox:
http://source.squeak.org/inbox/EToys-kfr.414.mcz

==================== Summary ====================

Name: EToys-kfr.414
Author: kfr
Time: 31 October 2020, 8:58:48.943742 pm
UUID: 5e186cb9-67d7-124d-901e-ae50d4bacbe8
Ancestors: EToys-eem.413

self world returns nil when the morph is not visible/ opened yet

=============== Diff against EToys-eem.413 ===============

Item was changed:
  ----- Method: CategoryViewer>>assureCategoryFullyVisible (in category '*Etoys-Squeakland-categories') -----
  assureCategoryFullyVisible
         "Keep deleting categoryviewers other than the receiver  until the receiver is fully visible."
 
         | ready toDelete |
         ready := false.
+        [(self bounds bottom > Project current world bottom) and: [ready not]] whileTrue: [
-        [(self bounds bottom > self world bottom) and: [ready not]] whileTrue: [
                 owner submorphs size > 2
                         ifTrue: [
                                 toDelete := owner submorphs allButFirst reversed
                                         detect: [:cv | cv ~~ self]
                                         ifNone: [^ self].
                                 toDelete delete.
                                 self world doOneCycleNow]
                         ifFalse: [
                                 ready := true]].!




Carpe Squeak!
Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: EToys-kfr.414.mcz

marcel.taeumel
Treated and in Trunk.

Best,
Marcel

Am 02.11.2020 10:26:31 schrieb Thiede, Christoph <[hidden email]>:

Hi Karl,


iirc, in Morphic code you should prefer self currentWorld over Project current world. See these guidelines by Marcel: http://forum.world.st/Changeset-Eliminating-global-state-from-Morphic-tp5121690p5123334.html :-)


Best,

Christoph


Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Samstag, 31. Oktober 2020 20:59:05
An: [hidden email]
Betreff: [squeak-dev] The Inbox: EToys-kfr.414.mcz
 
A new version of EToys was added to project The Inbox:
http://source.squeak.org/inbox/EToys-kfr.414.mcz

==================== Summary ====================

Name: EToys-kfr.414
Author: kfr
Time: 31 October 2020, 8:58:48.943742 pm
UUID: 5e186cb9-67d7-124d-901e-ae50d4bacbe8
Ancestors: EToys-eem.413

self world returns nil when the morph is not visible/ opened yet

=============== Diff against EToys-eem.413 ===============

Item was changed:
  ----- Method: CategoryViewer>>assureCategoryFullyVisible (in category '*Etoys-Squeakland-categories') -----
  assureCategoryFullyVisible
         "Keep deleting categoryviewers other than the receiver  until the receiver is fully visible."
 
         | ready toDelete |
         ready := false.
+        [(self bounds bottom > Project current world bottom) and: [ready not]] whileTrue: [
-        [(self bounds bottom > self world bottom) and: [ready not]] whileTrue: [
                 owner submorphs size > 2
                         ifTrue: [
                                 toDelete := owner submorphs allButFirst reversed
                                         detect: [:cv | cv ~~ self]
                                         ifNone: [^ self].
                                 toDelete delete.
                                 self world doOneCycleNow]
                         ifFalse: [
                                 ready := true]].!