The Inbox: EToys-tcj.324.mcz

> A new version of EToys was added to project The Inbox:
> http://source.squeak.org/inbox/EToys-tcj.324.mcz
>
> ==================== Summary ====================
>
> Name: EToys-tcj.324
> Author: tcj
> Time: 9 April 2018, 12:33:26.80885 pm
> UUID: 4cdd717b-002f-4dc1-96e4-b32bb0452038
> Ancestors: EToys-nice.323
>
> Replace deprecated (and removed) 3.8-era message sends with
> contemporary equivalents.  Note:  now that this works again, it
> exposes two sends of #isThisEverCalled.
>
> =============== Diff against EToys-nice.323 ===============
>
> Item was changed:
>   ----- Method: PDA>>openMonthView (in category 'initialization') -----
>   openMonthView
>   | row month col paneExtent window paneColor nRows |
>   month := date notNil
>   ifTrue: [date month]
>   ifFalse: ["But... it's here somewhere..."
>   ((self dependents detect: [:m | m isKindOf: PDAMorph])
>   findA: MonthMorph) month].
>   window := SystemWindow labelled: month printString.
>   paneColor := Color transparent.
>   window color: (Color r: 0.968 g: 1.0 b: 0.355).
> + nRows := 0.  month weeksDo: [:w | nRows := nRows + 1].
> - nRows := 0.  month eachWeekDo: [:w | nRows := nRows + 1].
>   paneExtent := ((1.0/7) @ (1.0/nRows)).
>   row := 0.
> + month weeksDo:
> - month eachWeekDo:
>   [:week | col := 0.
> + week datesDo:
> - week do:
>   [:day | day month = month ifTrue:
>   [window addMorph: ((PluggableListMorph on: self list: nil
>   selected: nil changeSelected: nil menu: nil keystroke: nil)
>   list: {(day dayOfMonth printString , '  ' , day weekday)
> asText allBold}
>   , (self scheduleListForDay: day))
>   frame: (paneExtent * (col@row) extent: paneExtent)].
>   col := col + 1].
>   row := row + 1].
>
>   window firstSubmorph color: paneColor.
>   window updatePaneColors.
>   window openInWorld!

> Hi all,
>
> How to test:
>
> 1. do it: PDAMorph new openInWorld
>
> 2. Yellow/menu button in the bottom pane (probably contains "no item
> is selected")
>
> 3. select "spawn entire month"
>
> 4. Witness some usage of #isThisEverCalled in the following methods:
>
> Halt: This is indeed called: 'PluggableListMorph>>list:'
> Halt: This is indeed called: 'PluggableListMorph>>selectedMorph:'
>
> (is #isThisEverCalled ever called anymore?  seems useful)
>
> ...and once you get past these, you may see a rather unadorned window
> appear which looks like a calendar view for a month (but in my image,
> contains no labels -- perhaps due to PluggableListMorph>>#list: not
> doing part of its old job anymore, or something else, or nothing at
> all).
>
> Thanks,
> Tim
>
>
>
> On 2018-04-09 19:33, [hidden email] wrote:
>> A new version of EToys was added to project The Inbox:
>> http://source.squeak.org/inbox/EToys-tcj.324.mcz
>>
>> ==================== Summary ====================
>>
>> Name: EToys-tcj.324
>> Author: tcj
>> Time: 9 April 2018, 12:33:26.80885 pm
>> UUID: 4cdd717b-002f-4dc1-96e4-b32bb0452038
>> Ancestors: EToys-nice.323
>>
>> Replace deprecated (and removed) 3.8-era message sends with
>> contemporary equivalents.  Note:  now that this works again, it
>> exposes two sends of #isThisEverCalled.
>>
>> =============== Diff against EToys-nice.323 ===============
>>
>> Item was changed:
>>   ----- Method: PDA>>openMonthView (in category 'initialization')
>> -----
>>   openMonthView
>>   | row month col paneExtent window paneColor nRows |
>>   month := date notNil
>>   ifTrue: [date month]
>>   ifFalse: ["But... it's here somewhere..."
>>   ((self dependents detect: [:m | m isKindOf: PDAMorph])
>>   findA: MonthMorph) month].
>>   window := SystemWindow labelled: month printString.
>>   paneColor := Color transparent.
>>   window color: (Color r: 0.968 g: 1.0 b: 0.355).
>> + nRows := 0.  month weeksDo: [:w | nRows := nRows + 1].
>> - nRows := 0.  month eachWeekDo: [:w | nRows := nRows + 1].
>>   paneExtent := ((1.0/7) @ (1.0/nRows)).
>>   row := 0.
>> + month weeksDo:
>> - month eachWeekDo:
>>   [:week | col := 0.
>> + week datesDo:
>> - week do:
>>   [:day | day month = month ifTrue:
>>   [window addMorph: ((PluggableListMorph on: self list: nil
>>   selected: nil changeSelected: nil menu: nil keystroke: nil)
>>   list: {(day dayOfMonth printString , '  ' , day weekday)
>> asText allBold}
>>   , (self scheduleListForDay: day))
>>   frame: (paneExtent * (col@row) extent: paneExtent)].
>>   col := col + 1].
>>   row := row + 1].
>>
>>   window firstSubmorph color: paneColor.
>>   window updatePaneColors.
>>   window openInWorld!