Smalltalk › Squeak › Squeak - Dev

The Inbox: Environments-fbs.9.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

commits-2

The Inbox: Environments-fbs.9.mcz

Frank Shearar uploaded a new version of Environments to project The Inbox:
http://source.squeak.org/inbox/Environments-fbs.9.mcz

==================== Summary ====================

Name: Environments-fbs.9
Author: fbs
Time: 2 January 2013, 10:51:07.232 pm
UUID: c2996611-b252-4942-a8a3-2ae7db6995ac
Ancestors: Environments-cwp.8

The ReleaseSqueakTrunk CI job fails because it raises a debugger. This avoids that problem.

=============== Diff against Environments-cwp.8 ===============

Item was added:
+ ----- Method: Environment>>do: (in category 'enumerating') -----
+ do: aBlock
+ "Evaluate aBlock for each of the receiver's values."
+
+ contents valuesDo: aBlock!

Frank Shearar-3

Re: The Inbox: Environments-fbs.9.mcz

On 2 January 2013 22:51, <[hidden email]> wrote:

> Frank Shearar uploaded a new version of Environments to project The Inbox:
> http://source.squeak.org/inbox/Environments-fbs.9.mcz
>
> ==================== Summary ====================
>
> Name: Environments-fbs.9
> Author: fbs
> Time: 2 January 2013, 10:51:07.232 pm
> UUID: c2996611-b252-4942-a8a3-2ae7db6995ac
> Ancestors: Environments-cwp.8
>
> The ReleaseSqueakTrunk CI job fails because it raises a debugger. This avoids that problem.
>
> =============== Diff against Environments-cwp.8 ===============
>
> Item was added:
> + ----- Method: Environment>>do: (in category 'enumerating') -----
> + do: aBlock
> + "Evaluate aBlock for each of the receiver's values."
> +
> + contents valuesDo: aBlock!

I'd added this to the Inbox rather than just pushing to Trunk because
an Environment is not (just) a Dictionary and so should not
necessarily blindly reproduce its API. However, this _is_ blocking all
4.5 alpha release artifacts so if it's not unbearably odious, I'd
appreciate a swift review (even if it's a "no thanks"), if possible!

Thanks,

frank

Colin Putney-3

Re: The Inbox: Environments-fbs.9.mcz

On Thu, Jan 3, 2013 at 5:56 AM, Frank Shearar <[hidden email]> wrote:

On 2 January 2013 22:51, <[hidden email]> wrote:
> Frank Shearar uploaded a new version of Environments to project The Inbox:
> http://source.squeak.org/inbox/Environments-fbs.9.mcz
>
> ==================== Summary ====================
>
> Name: Environments-fbs.9
> Author: fbs
> Time: 2 January 2013, 10:51:07.232 pm
> UUID: c2996611-b252-4942-a8a3-2ae7db6995ac
> Ancestors: Environments-cwp.8
>
> The ReleaseSqueakTrunk CI job fails because it raises a debugger. This avoids that problem.
>
> =============== Diff against Environments-cwp.8 ===============
>
> Item was added:
> + ----- Method: Environment>>do: (in category 'enumerating') -----
> + do: aBlock
> + "Evaluate aBlock for each of the receiver's values."
> +
> + contents valuesDo: aBlock!

I'd added this to the Inbox rather than just pushing to Trunk because
an Environment is not (just) a Dictionary and so should not
necessarily blindly reproduce its API. However, this _is_ blocking all
4.5 alpha release artifacts so if it's not unbearably odious, I'd
appreciate a swift review (even if it's a "no thanks"), if possible!

Oh, I didn't notice this was in the Inbox. I just moved it to trunk.

You're right, long-term, I think we want a new protocol for manipulating bindings, but for now feel free to fix things by making Environment more compatible with SystemDictionary.

Colin