Smalltalk › Squeak › Squeak - Dev

The Inbox: GetText-edc.26.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

commits-2

The Inbox: GetText-edc.26.mcz

A new version of GetText was added to project The Inbox:
http://source.squeak.org/inbox/GetText-edc.26.mcz

==================== Summary ====================

Name: GetText-edc.26
Author: edc
Time: 18 December 2012, 8:23:27.014 am
UUID: a6073c36-9cee-4419-a727-389696afd8ad
Ancestors: GetText-nice.25

This modification is for when you perform Smalltalk unloadAllKnownPackages on Squeak4.4-RC2.tgz the image don't crash

=============== Diff against GetText-nice.25 ===============

Item was changed:
----- Method: GetTextExporter>>appendTranslations: (in category 'exporting') -----
appendTranslations: domains
self appendStringReceivers: #translated into: domains.
self appendStringReceivers: #translatedNoop into: domains.
+ "self appendVocabularies: domains."
- self appendVocabularies: domains.
!

Item was removed:
- ----- Method: GetTextExporter>>appendVocabularies: (in category 'private') -----
- appendVocabularies: domains
- | literalsForDomain references domainName methodReference |
-
- EToyVocabulary allPhrasesWithContextToTranslate do: [ :r |
- methodReference := (MethodReference new setStandardClass: (r second) methodSymbol: (r third)).
- "domainName := self getTextDomainForPackage: (PackageOrganizer default packageOfMethod: methodReference)".
- domainName := 'Etoys-Tiles'.
- literalsForDomain := domains at: domainName ifAbsentPut: [Dictionary new].
- r fourth do: [ :literal |
- references := literalsForDomain at: literal ifAbsentPut: [OrderedCollection new].
- references add: methodReference.
- ].
- ].
- !

Eliot Miranda-2

Re: The Inbox: GetText-edc.26.mcz

Hi Edgar,

the package comment is good. But the source isn't. If I were to come back in a year or two I would want to know why the send line had been commented out and why the appendVocabularies: method had been kept. But reading the source I would have no clue.

On Tue, Dec 18, 2012 at 3:22 AM, <[hidden email]> wrote:

A new version of GetText was added to project The Inbox:
http://source.squeak.org/inbox/GetText-edc.26.mcz

==================== Summary ====================

Name: GetText-edc.26
Author: edc
Time: 18 December 2012, 8:23:27.014 am
UUID: a6073c36-9cee-4419-a727-389696afd8ad
Ancestors: GetText-nice.25

This modification is for when you perform Smalltalk unloadAllKnownPackages on Squeak4.4-RC2.tgz the image don't crash

=============== Diff against GetText-nice.25 ===============

Item was changed:
----- Method: GetTextExporter>>appendTranslations: (in category 'exporting') -----
appendTranslations: domains
self appendStringReceivers: #translated into: domains.
self appendStringReceivers: #translatedNoop into: domains.
+ "self appendVocabularies: domains."
- self appendVocabularies: domains.
!

Item was removed:
- ----- Method: GetTextExporter>>appendVocabularies: (in category 'private') -----
- appendVocabularies: domains
- | literalsForDomain references domainName methodReference |
-
- EToyVocabulary allPhrasesWithContextToTranslate do: [ :r |
- methodReference := (MethodReference new setStandardClass: (r second) methodSymbol: (r third)).
- "domainName := self getTextDomainForPackage: (PackageOrganizer default packageOfMethod: methodReference)".
- domainName := 'Etoys-Tiles'.
- literalsForDomain := domains at: domainName ifAbsentPut: [Dictionary new].
- r fourth do: [ :literal |
- references := literalsForDomain at: literal ifAbsentPut: [OrderedCollection new].
- references add: methodReference.
- ].
- ].
- !

--
best,

Eliot

Edgar De Cleene

Re: The Inbox: GetText-edc.26.mcz

Re: [squeak-dev] The Inbox: GetText-edc.26.mcz

On 12/18/12 6:47 PM, "Eliot Miranda" <[hidden email]> wrote:

Hi Edgar,

the package comment is good. But the source isn't. If I were to come back in a year or two I would want to know why the send line had been commented out and why the appendVocabularies: method had been kept. But reading the source I would have no clue.

Agree with you, must add more comment and say is a quick dirty solution to the problem Hannes found.

Stil we don’t have a “how to “ about packages which have troubles in reduced images , SqueakCore in this case.
Code do not change, the commented out is for you still could load the package in official SqueakCore when this image was build with Jenkins.

If you read the differences, shows EToyVocabulary which of course do not exist in SqueakCore.
Later I discover still more Unreferenced and made a second GetText-edc.27.

And put both into the inbox for review and improve.

My conclusion is we should discover how to unload GetText in a safe form.

Edgar

Hannes Hirzel

Re: The Inbox: GetText-edc.26.mcz

Hello Edgar

I loaded your fix from the inbox

GetText-edc.27.mcz

(Note: version 27 not 26 as the subject line indicates)

TEST

Smalltalk unloadAllKnownPackages

still does not run through cleanly.

RESULT
See attachment

An emergency debugger comes up.

PROPOSAL FOR ACTION

I propose to comment out all packages which create problems so that
the unload script runs fine.

What do we need to comment out?

We did this exercise before, references to the mailing list archive are welcome.

--Hannes

On 12/19/12, Edgar J. De Cleene <[hidden email]> wrote:

>
>
>
> On 12/18/12 6:47 PM, "Eliot Miranda" <[hidden email]> wrote:
>
>> Hi Edgar,
>>
>> the package comment is good. But the source isn't. If I were to
>> come
>> back in a year or two I would want to know why the send line had been
>> commented out and why the appendVocabularies: method had been kept. But
>> reading the source I would have no clue.
>
> Agree with you, must add more comment and say is a quick dirty solution to
> the problem Hannes found.
>
> Stil we don¹t have a ³how to ³ about packages which have troubles in
> reduced
> images , SqueakCore in this case.
> Code do not change, the commented out is for you still could load the
> package in official SqueakCore when this image was build with Jenkins.
>
> If you read the differences, shows EToyVocabulary which of course do not
> exist in SqueakCore.
> Later I discover still more Unreferenced and made a second GetText-edc.27.
>
> And put both into the inbox for review and improve.
>
> My conclusion is we should discover how to unload GetText in a safe form.
>
> Edgar
>
>

Smalltalk unloadAllKnownPackages Squeak4.4-12320-Failure.png (71K) Download Attachment

Edgar De Cleene

Re: The Inbox: GetText-edc.26.mcz

On 12/21/12 5:40 PM, "H. Hirzel" <[hidden email]> wrote:

> I loaded your fix from the inbox
>
> GetText-edc.27.mcz
>
> (Note: version 27 not 26 as the subject line indicates)
>
>
> TEST
>
> Smalltalk unloadAllKnownPackages
>
> still does not run through cleanly.
>
>
>
> RESULT
> See attachment
>
> An emergency debugger comes up.
>
>
>
> PROPOSAL FOR ACTION
>
> I propose to comment out all packages which create problems so that
> the unload script runs fine.
>
> What do we need to comment out?
>
> We did this exercise before, references to the mailing list archive are
> welcome.
>
>
> --Hannes
>

Ok, I unload last Squeak and re test tomorrow.

Edgar