The Inbox: HelpSystem-Core-ct.120.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: HelpSystem-Core-ct.120.mcz

commits-2
A new version of HelpSystem-Core was added to project The Inbox:
http://source.squeak.org/inbox/HelpSystem-Core-ct.120.mcz

==================== Summary ====================

Name: HelpSystem-Core-ct.120
Author: ct
Time: 3 October 2019, 1:39:46.913682 am
UUID: c9b2afad-2786-1f47-a2f5-8ee6258fe75c
Ancestors: HelpSystem-Core-ct.119

Adds browse entry into the HelpBrowser menu

=============== Diff against HelpSystem-Core-ct.119 ===============

Item was added:
+ ----- Method: ClassAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+ ^ self theClass theMetaClass browse!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseSubtopic: (in category 'tools') -----
+ browseSubtopic: aTopic
+
+ ^ ToolSet browse: self helpClass theMetaClass selector: aTopic key!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+ ^ self helpClass theMetaClass browse!

Item was added:
+ ----- Method: DirectoryBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+ ^ FileList openOn: self directoryEntry asFileDirectory!

Item was added:
+ ----- Method: FileBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+ ^ FileList openOn: self fileEntry containingDirectory!

Item was added:
+ ----- Method: HelpBrowser>>browseTopic (in category 'actions') -----
+ browseTopic
+
+ ^ (self currentTopic respondsTo: #browseTopic)
+ ifTrue: [self currentTopic browseTopic]
+ ifFalse: [self currentParentTopic browseSubtopic: self currentTopic]!

Item was added:
+ ----- Method: HelpBrowser>>canBrowseTopic (in category 'testing') -----
+ canBrowseTopic
+
+ ^ (self currentTopic respondsTo: #browseTopic)
+ or: [self currentParentTopic respondsTo: #browseSubtopic:]!

Item was changed:
  ----- Method: HelpBrowser>>treeKey:from:event: (in category 'menus') -----
  treeKey: aChar from: aView event: anEvent
 
  anEvent anyModifierKeyPressed ifFalse: [^ false].
  aChar
  caseOf: {
+ [$b] -> [self browseTopic].
  [$i] -> [self inspectTopic].
  [$I] -> [self exploreTopic]. }
  otherwise: [^ false].
  ^ true!

Item was changed:
  ----- Method: HelpBrowser>>treeListMenu: (in category 'menus') -----
  treeListMenu: aMenu
  <treeListMenu>
 
  self currentTopic ifNil: [^ aMenu].
 
  aMenu
  add: 'Inspect (i)' action: #inspectTopic;
  add: 'Explore (I)' action: #exploreTopic.
 
+ self canBrowseTopic ifTrue: [
+ aMenu
+ addLine;
+ add: 'Browse (b)' action: #browseTopic].
+
  ^ aMenu!

Item was added:
+ ----- Method: MethodListHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+ ^ self theClass browse!

Item was added:
+ ----- Method: PackageAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+ ^ (PackageInfo named: packageName) browse!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: HelpSystem-Core-ct.120.mcz

Christoph Thiede

Do you think we should install a mediator the file browsing (highlighted below) at some place like ToolSet to reduce dependencies? Or is that still insignificant?



Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 3. Oktober 2019 01:39 Uhr
An: [hidden email]
Betreff: [squeak-dev] The Inbox: HelpSystem-Core-ct.120.mcz
 
A new version of HelpSystem-Core was added to project The Inbox:
http://source.squeak.org/inbox/HelpSystem-Core-ct.120.mcz

==================== Summary ====================

Name: HelpSystem-Core-ct.120
Author: ct
Time: 3 October 2019, 1:39:46.913682 am
UUID: c9b2afad-2786-1f47-a2f5-8ee6258fe75c
Ancestors: HelpSystem-Core-ct.119

Adds browse entry into the HelpBrowser menu

=============== Diff against HelpSystem-Core-ct.119 ===============

Item was added:
+ ----- Method: ClassAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self theClass theMetaClass browse!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseSubtopic: (in category 'tools') -----
+ browseSubtopic: aTopic
+
+        ^ ToolSet browse: self helpClass theMetaClass selector: aTopic key!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self helpClass theMetaClass browse!

Item was added:
+ ----- Method: DirectoryBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ FileList openOn: self directoryEntry asFileDirectory!

Item was added:
+ ----- Method: FileBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ FileList openOn: self fileEntry containingDirectory!

Item was added:
+ ----- Method: HelpBrowser>>browseTopic (in category 'actions') -----
+ browseTopic
+
+        ^ (self currentTopic respondsTo: #browseTopic)
+                ifTrue: [self currentTopic browseTopic]
+                ifFalse: [self currentParentTopic browseSubtopic: self currentTopic]!

Item was added:
+ ----- Method: HelpBrowser>>canBrowseTopic (in category 'testing') -----
+ canBrowseTopic
+
+        ^ (self currentTopic respondsTo: #browseTopic)
+                or: [self currentParentTopic respondsTo: #browseSubtopic:]!

Item was changed:
  ----- Method: HelpBrowser>>treeKey:from:event: (in category 'menus') -----
  treeKey: aChar from: aView event: anEvent
 
         anEvent anyModifierKeyPressed ifFalse: [^ false].
         aChar
                 caseOf: {
+                        [$b] -> [self browseTopic].
                         [$i] -> [self inspectTopic].
                         [$I] -> [self exploreTopic]. }
                 otherwise:      [^ false].
         ^ true!

Item was changed:
  ----- Method: HelpBrowser>>treeListMenu: (in category 'menus') -----
  treeListMenu: aMenu
         <treeListMenu>
        
         self currentTopic ifNil: [^ aMenu].
        
         aMenu
                 add: 'Inspect (i)' action: #inspectTopic;
                 add: 'Explore (I)' action: #exploreTopic.
        
+        self canBrowseTopic ifTrue: [
+                aMenu
+                        addLine;
+                        add: 'Browse (b)' action: #browseTopic].
+       
         ^ aMenu!

Item was added:
+ ----- Method: MethodListHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self theClass browse!

Item was added:
+ ----- Method: PackageAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ (PackageInfo named: packageName) browse!




Carpe Squeak!
Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: HelpSystem-Core-ct.120.mcz

Christoph Thiede
UI for editing subtopics is following later. I need a vacation first :)



On Thu, Oct 3, 2019 at 1:43 AM +0200, "Thiede, Christoph" <[hidden email]> wrote:

Do you think we should install a mediator the file browsing (highlighted below) at some place like ToolSet to reduce dependencies? Or is that still insignificant?



Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 3. Oktober 2019 01:39 Uhr
An: [hidden email]
Betreff: [squeak-dev] The Inbox: HelpSystem-Core-ct.120.mcz
 
A new version of HelpSystem-Core was added to project The Inbox:
http://source.squeak.org/inbox/HelpSystem-Core-ct.120.mcz

==================== Summary ====================

Name: HelpSystem-Core-ct.120
Author: ct
Time: 3 October 2019, 1:39:46.913682 am
UUID: c9b2afad-2786-1f47-a2f5-8ee6258fe75c
Ancestors: HelpSystem-Core-ct.119

Adds browse entry into the HelpBrowser menu

=============== Diff against HelpSystem-Core-ct.119 ===============

Item was added:
+ ----- Method: ClassAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self theClass theMetaClass browse!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseSubtopic: (in category 'tools') -----
+ browseSubtopic: aTopic
+
+        ^ ToolSet browse: self helpClass theMetaClass selector: aTopic key!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self helpClass theMetaClass browse!

Item was added:
+ ----- Method: DirectoryBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ FileList openOn: self directoryEntry asFileDirectory!

Item was added:
+ ----- Method: FileBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ FileList openOn: self fileEntry containingDirectory!

Item was added:
+ ----- Method: HelpBrowser>>browseTopic (in category 'actions') -----
+ browseTopic
+
+        ^ (self currentTopic respondsTo: #browseTopic)
+                ifTrue: [self currentTopic browseTopic]
+                ifFalse: [self currentParentTopic browseSubtopic: self currentTopic]!

Item was added:
+ ----- Method: HelpBrowser>>canBrowseTopic (in category 'testing') -----
+ canBrowseTopic
+
+        ^ (self currentTopic respondsTo: #browseTopic)
+                or: [self currentParentTopic respondsTo: #browseSubtopic:]!

Item was changed:
  ----- Method: HelpBrowser>>treeKey:from:event: (in category 'menus') -----
  treeKey: aChar from: aView event: anEvent
 
         anEvent anyModifierKeyPressed ifFalse: [^ false].
         aChar
                 caseOf: {
+                        [$b] -> [self browseTopic].
                         [$i] -> [self inspectTopic].
                         [$I] -> [self exploreTopic]. }
                 otherwise:      [^ false].
         ^ true!

Item was changed:
  ----- Method: HelpBrowser>>treeListMenu: (in category 'menus') -----
  treeListMenu: aMenu
         <treeListMenu>
        
         self currentTopic ifNil: [^ aMenu].
        
         aMenu
                 add: 'Inspect (i)' action: #inspectTopic;
                 add: 'Explore (I)' action: #exploreTopic.
        
+        self canBrowseTopic ifTrue: [
+                aMenu
+                        addLine;
+                        add: 'Browse (b)' action: #browseTopic].
+       
         ^ aMenu!

Item was added:
+ ----- Method: MethodListHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self theClass browse!

Item was added:
+ ----- Method: PackageAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ (PackageInfo named: packageName) browse!




Carpe Squeak!
Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: HelpSystem-Core-ct.120.mcz

marcel.taeumel
UI for editing subtopics is following later. I need a vacation first :)

What are your ideas in this area? At the moment, you can start typing and finish with [CMD]+S like in the code editor. What kind of UI would improve that process? Make it more discoverable?

Best,
Marcel

Am 03.10.2019 04:02:48 schrieb Thiede, Christoph <[hidden email]>:

UI for editing subtopics is following later. I need a vacation first :)



On Thu, Oct 3, 2019 at 1:43 AM +0200, "Thiede, Christoph" <[hidden email]> wrote:

Do you think we should install a mediator the file browsing (highlighted below) at some place like ToolSet to reduce dependencies? Or is that still insignificant?



Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 3. Oktober 2019 01:39 Uhr
An: [hidden email]
Betreff: [squeak-dev] The Inbox: HelpSystem-Core-ct.120.mcz
 
A new version of HelpSystem-Core was added to project The Inbox:
http://source.squeak.org/inbox/HelpSystem-Core-ct.120.mcz

==================== Summary ====================

Name: HelpSystem-Core-ct.120
Author: ct
Time: 3 October 2019, 1:39:46.913682 am
UUID: c9b2afad-2786-1f47-a2f5-8ee6258fe75c
Ancestors: HelpSystem-Core-ct.119

Adds browse entry into the HelpBrowser menu

=============== Diff against HelpSystem-Core-ct.119 ===============

Item was added:
+ ----- Method: ClassAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self theClass theMetaClass browse!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseSubtopic: (in category 'tools') -----
+ browseSubtopic: aTopic
+
+        ^ ToolSet browse: self helpClass theMetaClass selector: aTopic key!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self helpClass theMetaClass browse!

Item was added:
+ ----- Method: DirectoryBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ FileList openOn: self directoryEntry asFileDirectory!

Item was added:
+ ----- Method: FileBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ FileList openOn: self fileEntry containingDirectory!

Item was added:
+ ----- Method: HelpBrowser>>browseTopic (in category 'actions') -----
+ browseTopic
+
+        ^ (self currentTopic respondsTo: #browseTopic)
+                ifTrue: [self currentTopic browseTopic]
+                ifFalse: [self currentParentTopic browseSubtopic: self currentTopic]!

Item was added:
+ ----- Method: HelpBrowser>>canBrowseTopic (in category 'testing') -----
+ canBrowseTopic
+
+        ^ (self currentTopic respondsTo: #browseTopic)
+                or: [self currentParentTopic respondsTo: #browseSubtopic:]!

Item was changed:
  ----- Method: HelpBrowser>>treeKey:from:event: (in category 'menus') -----
  treeKey: aChar from: aView event: anEvent
 
         anEvent anyModifierKeyPressed ifFalse: [^ false].
         aChar
                 caseOf: {
+                        [$b] -> [self browseTopic].
                         [$i] -> [self inspectTopic].
                         [$I] -> [self exploreTopic]. }
                 otherwise:      [^ false].
         ^ true!

Item was changed:
  ----- Method: HelpBrowser>>treeListMenu: (in category 'menus') -----
  treeListMenu: aMenu
         <treeListMenu>
        
         self currentTopic ifNil: [^ aMenu].
        
         aMenu
                 add: 'Inspect (i)' action: #inspectTopic;
                 add: 'Explore (I)' action: #exploreTopic.
        
+        self canBrowseTopic ifTrue: [
+                aMenu
+                        addLine;
+                        add: 'Browse (b)' action: #browseTopic].
+       
         ^ aMenu!

Item was added:
+ ----- Method: MethodListHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self theClass browse!

Item was added:
+ ----- Method: PackageAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ (PackageInfo named: packageName) browse!




Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: HelpSystem-Core-ct.120.mcz

Christoph Thiede

Please have a quick look at HelpSystem-Core-ct.124 :-)


Best,

Christoph



Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 7. Oktober 2019 09:05:38
An: Alan Grimes via Squeak-dev
Betreff: Re: [squeak-dev] The Inbox: HelpSystem-Core-ct.120.mcz
 
UI for editing subtopics is following later. I need a vacation first :)

What are your ideas in this area? At the moment, you can start typing and finish with [CMD]+S like in the code editor. What kind of UI would improve that process? Make it more discoverable?

Best,
Marcel

Am 03.10.2019 04:02:48 schrieb Thiede, Christoph <[hidden email]>:

UI for editing subtopics is following later. I need a vacation first :)



On Thu, Oct 3, 2019 at 1:43 AM +0200, "Thiede, Christoph" <[hidden email]> wrote:

Do you think we should install a mediator the file browsing (highlighted below) at some place like ToolSet to reduce dependencies? Or is that still insignificant?



Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Donnerstag, 3. Oktober 2019 01:39 Uhr
An: [hidden email]
Betreff: [squeak-dev] The Inbox: HelpSystem-Core-ct.120.mcz
 
A new version of HelpSystem-Core was added to project The Inbox:
http://source.squeak.org/inbox/HelpSystem-Core-ct.120.mcz

==================== Summary ====================

Name: HelpSystem-Core-ct.120
Author: ct
Time: 3 October 2019, 1:39:46.913682 am
UUID: c9b2afad-2786-1f47-a2f5-8ee6258fe75c
Ancestors: HelpSystem-Core-ct.119

Adds browse entry into the HelpBrowser menu

=============== Diff against HelpSystem-Core-ct.119 ===============

Item was added:
+ ----- Method: ClassAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self theClass theMetaClass browse!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseSubtopic: (in category 'tools') -----
+ browseSubtopic: aTopic
+
+        ^ ToolSet browse: self helpClass theMetaClass selector: aTopic key!

Item was added:
+ ----- Method: ClassBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self helpClass theMetaClass browse!

Item was added:
+ ----- Method: DirectoryBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ FileList openOn: self directoryEntry asFileDirectory!

Item was added:
+ ----- Method: FileBasedHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ FileList openOn: self fileEntry containingDirectory!

Item was added:
+ ----- Method: HelpBrowser>>browseTopic (in category 'actions') -----
+ browseTopic
+
+        ^ (self currentTopic respondsTo: #browseTopic)
+                ifTrue: [self currentTopic browseTopic]
+                ifFalse: [self currentParentTopic browseSubtopic: self currentTopic]!

Item was added:
+ ----- Method: HelpBrowser>>canBrowseTopic (in category 'testing') -----
+ canBrowseTopic
+
+        ^ (self currentTopic respondsTo: #browseTopic)
+                or: [self currentParentTopic respondsTo: #browseSubtopic:]!

Item was changed:
  ----- Method: HelpBrowser>>treeKey:from:event: (in category 'menus') -----
  treeKey: aChar from: aView event: anEvent
 
         anEvent anyModifierKeyPressed ifFalse: [^ false].
         aChar
                 caseOf: {
+                        [$b] -> [self browseTopic].
                         [$i] -> [self inspectTopic].
                         [$I] -> [self exploreTopic]. }
                 otherwise:      [^ false].
         ^ true!

Item was changed:
  ----- Method: HelpBrowser>>treeListMenu: (in category 'menus') -----
  treeListMenu: aMenu
         <treeListMenu>
        
         self currentTopic ifNil: [^ aMenu].
        
         aMenu
                 add: 'Inspect (i)' action: #inspectTopic;
                 add: 'Explore (I)' action: #exploreTopic.
        
+        self canBrowseTopic ifTrue: [
+                aMenu
+                        addLine;
+                        add: 'Browse (b)' action: #browseTopic].
+       
         ^ aMenu!

Item was added:
+ ----- Method: MethodListHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ self theClass browse!

Item was added:
+ ----- Method: PackageAPIHelpTopic>>browseTopic (in category 'tools') -----
+ browseTopic
+
+        ^ (PackageInfo named: packageName) browse!




Carpe Squeak!