The Inbox: Installer-Core-cmm.380.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Installer-Core-cmm.380.mcz

commits-2
A new version of Installer-Core was added to project The Inbox:
http://source.squeak.org/inbox/Installer-Core-cmm.380.mcz

==================== Summary ====================

Name: Installer-Core-cmm.380
Author: cmm
Time: 13 August 2013, 5:56:00.893 pm
UUID: 565892cf-7178-4806-8fb1-63523b83de58
Ancestors: Installer-Core-cmm.379

Fix for using Installer with MCDirectoryRepository's.

=============== Diff against Installer-Core-cmm.379 ===============

Item was changed:
  ----- Method: InstallerMonticello>>project: (in category 'accessing') -----
  project: name
 
  project := name.
  packages := nil.
 
  (mc respondsTo: #location:) ifTrue:[ mc := mc copy location: root , name ].
+ (mc respondsTo: #directory:) ifTrue: [ mc := mc copy directory: root / name ].
- (mc respondsTo: #directory:) ifTrue: [ mc := mc copy directory: root ,'/', name ].
 
  ^self copy.!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Installer-Core-cmm.380.mcz

Frank Shearar-3
On 13 August 2013 23:56,  <[hidden email]> wrote:

> A new version of Installer-Core was added to project The Inbox:
> http://source.squeak.org/inbox/Installer-Core-cmm.380.mcz
>
> ==================== Summary ====================
>
> Name: Installer-Core-cmm.380
> Author: cmm
> Time: 13 August 2013, 5:56:00.893 pm
> UUID: 565892cf-7178-4806-8fb1-63523b83de58
> Ancestors: Installer-Core-cmm.379
>
> Fix for using Installer with MCDirectoryRepository's.
>
> =============== Diff against Installer-Core-cmm.379 ===============
>
> Item was changed:
>   ----- Method: InstallerMonticello>>project: (in category 'accessing') -----
>   project: name
>
>         project := name.
>         packages := nil.
>
>         (mc respondsTo: #location:) ifTrue:[ mc := mc copy location: root , name ].
> +       (mc respondsTo: #directory:) ifTrue: [ mc := mc copy directory: root / name ].
> -       (mc respondsTo: #directory:) ifTrue: [ mc := mc copy directory: root ,'/', name ].

IIRC the nasty thing about this kind of bug is that it works on Linux
(but not on any other OS that doesn't use / as a separator, like
Windows).

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Installer-Core-cmm.380.mcz

Edgar De Cleene



On 8/14/13 4:44 AM, "Frank Shearar" <[hidden email]> wrote:

>> UUID: 565892cf-7178-4806-8fb1-63523b83de58
>> Ancestors: Installer-Core-cmm.379
>>
>> Fix for using Installer with MCDirectoryRepository's.
>>
>> =============== Diff against Installer-Core-cmm.379 ===============
>>
>> Item was changed:
>>   ----- Method: InstallerMonticello>>project: (in category 'accessing') -----
>>   project: name
>>
>>         project := name.
>>         packages := nil.
>>
>>         (mc respondsTo: #location:) ifTrue:[ mc := mc copy location: root ,
>> name ].
>> +       (mc respondsTo: #directory:) ifTrue: [ mc := mc copy directory: root
>> / name ].
>> -       (mc respondsTo: #directory:) ifTrue: [ mc := mc copy directory: root
>> ,'/', name ].
>
> IIRC the nasty thing about this kind of bug is that it works on Linux
> (but not on any other OS that doesn't use / as a separator, like
> Windows).
>
> frank
>


What about using FileDirectory slash ?

Edgar



Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Installer-Core-cmm.380.mcz

Frank Shearar-3
On 14 August 2013 09:27, Edgar J. De Cleene <[hidden email]> wrote:

>
>
>
> On 8/14/13 4:44 AM, "Frank Shearar" <[hidden email]> wrote:
>
>>> UUID: 565892cf-7178-4806-8fb1-63523b83de58
>>> Ancestors: Installer-Core-cmm.379
>>>
>>> Fix for using Installer with MCDirectoryRepository's.
>>>
>>> =============== Diff against Installer-Core-cmm.379 ===============
>>>
>>> Item was changed:
>>>   ----- Method: InstallerMonticello>>project: (in category 'accessing') -----
>>>   project: name
>>>
>>>         project := name.
>>>         packages := nil.
>>>
>>>         (mc respondsTo: #location:) ifTrue:[ mc := mc copy location: root ,
>>> name ].
>>> +       (mc respondsTo: #directory:) ifTrue: [ mc := mc copy directory: root
>>> / name ].
>>> -       (mc respondsTo: #directory:) ifTrue: [ mc := mc copy directory: root
>>> ,'/', name ].
>>
>> IIRC the nasty thing about this kind of bug is that it works on Linux
>> (but not on any other OS that doesn't use / as a separator, like
>> Windows).
>>
>> frank
>>
>
>
> What about using FileDirectory slash ?

FileDirectory slash returns a String containing the platform-specific
path separator, while #/ returns a new FileDirectory. So if you're
building a String, #slash is fine, but if you're working with a
FileDirectory already, #/ is what you want.

frank

> Edgar
>
>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Installer-Core-cmm.380.mcz

Edgar De Cleene
 root (FileDirectory slash) asSymbol name

Don't works either ?


Edgar