The Inbox: Kernel-cmm.937.mcz

A new version of Kernel was added to project The Inbox:
http://source.squeak.org/inbox/Kernel-cmm.937.mcz

==================== Summary ====================

Name: Kernel-cmm.937
Author: cmm
Time: 5 August 2015, 4:41:15.204 pm
UUID: 874460df-769a-4381-8d3e-29c2e118b7f6
Ancestors: Kernel-cmm.936

Move CompiledMethod>>#hasBreakpoint back to Kernel where it belongs.

=============== Diff against Kernel-cmm.936 ===============

Item was changed:
+ ----- Method: CompiledMethod>>hasBreakpoint (in category '*kernel') -----
- ----- Method: CompiledMethod>>hasBreakpoint (in category 'testing') -----
  hasBreakpoint
+ ^BreakpointManager methodHasBreakpoint: self!
- ^false!

On 05.08.2015, at 21:41, [hidden email] wrote:

Questionable, as BreakpointManager is (rightfully) not in Kernel…

(apart from the private reply) what about

hasBreakpoint
        ^ self class environment
                at: #BreakpointManager
                ifPresent: [:bpm | bpm methodHasBreakpoint: self]
                ifAbsent: [false]


?

Best regards
        -Tobias

> Questionable, as BreakpointManager is (rightfully) not in Kernel…

Oh right, I agree.

> (apart from the private reply) what about
>
> hasBreakpoint
>         ^ self class environment
>                 at: #BreakpointManager
>                 ifPresent: [:bpm | bpm methodHasBreakpoint: self]
>                 ifAbsent: [false]

If #hasBreakpoint is not a performance-critical method, then I like
the above.  If it is performance-critical, then I think your other
suggestion (in the other email) to put Object>>#hasBreakpoint ^false
in Kernel with the current one in System would perform faster.

We should wait until after the release to discuss the radical idea
(scrapping BreakpointManager, etc.).

 - Chris