The Inbox: Monticello-cg.529.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Monticello-cg.529.mcz

commits-2
Claus Gittinger uploaded a new version of Monticello to project The Inbox:
http://source.squeak.org/inbox/Monticello-cg.529.mcz

==================== Summary ====================

Name: Monticello-cg.529
Author: cg
Time: 25 March 2013, 2:10:09.446 pm
UUID: 0bcc62fe-400b-4dba-8d91-6dc1aefbbcbf
Ancestors: Monticello-cg.528

allow colons and slashes in a package's name (MCVersion generated an invalid filename for those).
Needed to be able to load monticello packages as written by ST/X. (Does not affect squeak/pharo operation, as those packages do not normally contain such characters)

=============== Diff against Monticello-bf.527 ===============

Item was changed:
  ----- Method: MCVersion>>fileName (in category 'accessing') -----
  fileName
+ |rawName cookedName|
+
+ rawName := info name.
+ "care for invalid filename characters"
+ cookedName := rawName copy
+ replaceAll: $/ with: $_;
+ replaceAll: $: with: $_..
+ ^ (cookedName, '.', self writerClass extension) asMCVersionName!
- ^ (info name, '.', self writerClass extension) asMCVersionName!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Monticello-cg.529.mcz

Bert Freudenberg
On 2013-03-25, at 13:10, [hidden email] wrote:

> Claus Gittinger uploaded a new version of Monticello to project The Inbox:
> http://source.squeak.org/inbox/Monticello-cg.529.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-cg.529
> Author: cg
> Time: 25 March 2013, 2:10:09.446 pm
> UUID: 0bcc62fe-400b-4dba-8d91-6dc1aefbbcbf
> Ancestors: Monticello-cg.528
>
> allow colons and slashes in a package's name (MCVersion generated an invalid filename for those).
> Needed to be able to load monticello packages as written by ST/X. (Does not affect squeak/pharo operation, as those packages do not normally contain such characters)
>
> =============== Diff against Monticello-bf.527 ===============
>
> Item was changed:
>  ----- Method: MCVersion>>fileName (in category 'accessing') -----
>  fileName
> + |rawName cookedName|
> +
> + rawName := info name.
> + "care for invalid filename characters"
> + cookedName := rawName copy
> + replaceAll: $/ with: $_;
> + replaceAll: $: with: $_..
> + ^ (cookedName, '.', self writerClass extension) asMCVersionName!
> - ^ (info name, '.', self writerClass extension) asMCVersionName!
>


Merged.

- Bert -