The Inbox: Monticello-ct.739.mcz

Am 10.03.2021 18:55:14 schrieb [hidden email] <[hidden email]>:

A new version of Monticello was added to project The Inbox:
http://source.squeak.org/inbox/Monticello-ct.739.mcz

==================== Summary ====================

Name: Monticello-ct.739
Author: ct
Time: 10 March 2021, 6:55:01.889559 pm
UUID: aec2f89c-cf99-ea47-91f4-4cdf2ebd5bb9
Ancestors: Monticello-mt.736

Tweaks 'add to current change set' command to create a changeset from all (non-ignored) items in an operations browser.

Also hides the 'browse full' command from the menu if not any item is selected since it does not have any function in this case.

=============== Diff against Monticello-mt.736 ===============

Item was changed:
----- Method: MCCodeTool>>methodListMenu: (in category 'menus') -----
methodListMenu: aMenu
"Build the menu for the selected method, if any."

self selectedMessageName
ifNil: [items notEmpty ifTrue:
[aMenu addList:#(
- ('browse full (b)' browseMethodFull)
('fileOut (o)' fileOutMessage))]]
ifNotNil: [
aMenu addList:#(
('browse full (b)' browseMethodFull)
('browse hierarchy (h)' browseClassHierarchy)
('browse protocol (p)' browseFullProtocol)
-
('fileOut (o)' fileOutMessage)
('printOut' printOutMessage)
('copy selector (c)' copySelector)
('copy reference (C)' copyReference)).
aMenu addList: #(
-
('browse senders (n)' browseSendersOfMessages)
('browse implementors (m)' browseMessages)
('inheritance (i)' methodHierarchy)
('versions (v)' browseVersions)
('change sets with this method' findMethodInChangeSets)
" ('x revert to previous version' revertToPreviousVersion)"
('remove from current change set' removeFromCurrentChanges)
" ('x revert & remove from changes' revertAndForget)"
('add to current change set' adoptMessageInCurrentChangeset)
" ('x copy up or copy down...' copyUpOrCopyDown)"
" ('x remove method (x)' removeMessage)"
"-"
).
].
" aMenu addList: #(
('x inst var refs...' browseInstVarRefs)
('x inst var defs...' browseInstVarDefs)
('x class var refs...' browseClassVarRefs)
('x class variables' browseClassVariables)
('x class refs (N)' browseClassRefs)
).
"
^ aMenu
!

Item was added:
+ ----- Method: MCOperationsBrowser>>adoptMessageInCurrentChangeset (in category 'menus') -----
+ adoptMessageInCurrentChangeset
+
+ selection ifNotNil: [^ super adoptMessageInCurrentChangeset].
+
+ items do: [:item |
+ self forItem: item setClassAndSelectorIn: [:class :selector |
+ ChangeSet current adoptSelector: selector forClass: class]].
+ self changed: #annotations.!

Item was added:
+ ----- Method: MCOperationsBrowser>>forItem:setClassAndSelectorIn: (in category 'private') -----
+ forItem: item setClassAndSelectorIn: classSelectorBlock
+
+ item definition isMethodDefinition ifFalse: [self halt].
+ ^ classSelectorBlock
+ value: item definition actualClass
+ value: item definition selector!

Item was changed:
----- Method: MCOperationsBrowser>>methodListMenu: (in category 'menus') -----
methodListMenu: aMenu
+ selection
+ ifNil: [items ifNotEmpty: [
+ aMenu addList: #(
+ ('add to current change set' adoptMessageInCurrentChangeset))]]
+ ifNotNil: [aMenu addList: #(
- selection ifNotNil:
- [aMenu addList: #(
('install' installSelection)
('revert (x)' revertSelection)
('browse origin' browseSelectionOrigin)
-)].
self unchangedMethods ifNotEmpty:
[aMenu addList: #(
('revert unchanged methods...' revertUnchangedMethods)
('filter out unchanged methods...' filterOutUnchangedMethods)
-)].
super methodListMenu: aMenu.
^ aMenu!

Item was added:
+ ----- Method: MCSaveVersionDialog>>adoptMessageInCurrentChangeset (in category 'menus') -----
+ adoptMessageInCurrentChangeset
+
+ selection ifNotNil: [^ super adoptMessageInCurrentChangeset].
+
+ (items copyWithoutAll: ignore) do: [:item |
+ self forItem: item setClassAndSelectorIn: [:class :selector |
+ ChangeSet current adoptSelector: selector forClass: class]].
+ self changed: #annotations.!

Hi Marcel,

I use this every day, it's pretty simple and very helpful: Just press Escape to open the context menu when no item is selected. :D

However, it might be helpful if you had a "mouse way" to do the same thing ...

Best,

Christoph