The Inbox: Monticello-dtl.710.mcz

David T. Lewis uploaded a new version of Monticello to project The Inbox:
http://source.squeak.org/inbox/Monticello-dtl.710.mcz

==================== Summary ====================

Name: Monticello-dtl.710
Author: dtl
Time: 13 February 2020, 7:59:28.819893 am
UUID: 8863e728-fcf1-4489-a690-e1dc2eb2eee0
Ancestors: Monticello-eem.709

Let the well-known repository URLs be class variables. Allows ReleaseBuilder to work cleanly with a location other http://source.squeak.org.trunk, e.g. http://www.squeaksource.com/TrunkUpdateStreamV3

=============== Diff against Monticello-eem.709 ===============

Item was changed:
  MCFileBasedRepository subclass: #MCHttpRepository
  instanceVariableNames: 'location user password readerCache indexed webClient'
+ classVariableNames: 'InboxURLString TreatedURLString TrunkURLString UseSharedWebClientInstance'
- classVariableNames: 'UseSharedWebClientInstance'
  poolDictionaries: ''
  category: 'Monticello-Repositories'!

Item was changed:
  ----- Method: MCHttpRepository class>>inbox (in category 'well-known repositories') -----
  inbox
  ^ MCRepositoryGroup default repositories
  detect:
  [ : each | each isInbox ]
  ifNone:
  [ MCHttpRepository
+ location: InboxURLString
- location: MCHttpRepository inboxUrlString
  user: 'squeak'
  password: 'squeak' ]!

Item was removed:
- ----- Method: MCHttpRepository class>>inboxUrlString (in category 'accessing') -----
- inboxUrlString
- ^ 'http://source.squeak.org/inbox'!

Item was changed:
  ----- Method: MCHttpRepository class>>initialize (in category 'class initialization') -----
  initialize
  self unload.
+ InboxURLString := 'http://source.squeak.org/inbox'.
+ TreatedURLString :=  'http://source.squeak.org/treated'.
+ TrunkURLString := 'http://source.squeak.org/trunk'.
  (ServiceRegistry current serviceWithId: #browserMethodMenu) services add: self browseMethodRevisionsService.
  (ServiceRegistry current serviceWithId: #browserClassMenu) services add: self browseClassRevisionsService!

Item was changed:
  ----- Method: MCHttpRepository class>>treated (in category 'well-known repositories') -----
  treated
  ^ MCRepositoryGroup default repositories
  detect:
  [ : each | each isTreated ]
  ifNone:
  [ MCHttpRepository
+ location: TreatedURLString
- location: MCHttpRepository treatedUrlString
  user: 'squeak'
  password: 'squeak' ]!

Item was removed:
- ----- Method: MCHttpRepository class>>treatedUrlString (in category 'accessing') -----
- treatedUrlString
- ^ 'http://source.squeak.org/treated'!

Item was changed:
  ----- Method: MCHttpRepository class>>trunk (in category 'well-known repositories') -----
  trunk
  ^ MCRepositoryGroup default repositories
  detect:
  [ : each | each isTrunk ]
  ifNone:
  [ MCHttpRepository
+ location: TrunkURLString
- location: MCHttpRepository trunkUrlString
  user: 'squeak'
  password: 'squeak' ]!

Item was changed:
  ----- Method: MCHttpRepository class>>trunkUrlString (in category 'accessing') -----
  trunkUrlString
+ ^ TrunkURLString!
- ^ 'http://source.squeak.org/trunk'!

Item was changed:
  ----- Method: MCHttpRepository>>isInbox (in category 'testing') -----
  isInbox
+ ^ location = InboxURLString!
- ^ location = self class inboxUrlString!

Item was changed:
  ----- Method: MCHttpRepository>>isTreated (in category 'testing') -----
  isTreated
+ ^ location = TreatedURLString!
- ^ location = self class treatedUrlString!

Item was changed:
  ----- Method: MCHttpRepository>>isTrunk (in category 'testing') -----
  isTrunk
+ ^ location = TrunkURLString!
- ^ location = self class trunkUrlString!

Merging note - I accidentally pushed this to inbox as a child of
Monticello-eem.709 (inbox) rather than Monticello-cmm.708 (trunk).
However, Monticello-eem.709 is such an obviously good enhancement that
I won't bother republishing. There is a large batch of other Monticello
inbox submissions including nine recent updates from Christoph that need
to be merged or not-merged after the release :-)

Dave


On Thu, Feb 13, 2020 at 12:59:34PM +0000, [hidden email] wrote: