The Inbox: Monticello-eem.709.mcz

A new version of Monticello was added to project The Inbox:
http://source.squeak.org/inbox/Monticello-eem.709.mcz

==================== Summary ====================

Name: Monticello-eem.709
Author: eem
Time: 24 January 2020, 6:17:42.907101 pm
UUID: ec11ed59-223d-4b58-aa08-c214e1ceb2e9
Ancestors: Monticello-cmm.708

Provide 'filter out unchanged methods...' to ignore any timestamp-only changes.

=============== Diff against Monticello-cmm.708 ===============

Item was added:
+ ----- Method: MCOperationsBrowser>>filterOutUnchangedMethods (in category 'actions') -----
+ filterOutUnchangedMethods
+       "Remove from the list methods that only have changed timestamps"
+       | unchangedMethods |
+       unchangedMethods := self unchangedMethods.
+       (self confirm: ('Ignore {1} methods that only differ in timestamp?' translated
+               format: {unchangedMethods size}))
+               ifTrue:
+                       [items := items reject: [:op| op isUnchangedMethod].
+                        self changed: #list]
+ !

Item was changed:
  ----- Method: MCOperationsBrowser>>methodListMenu: (in category 'menus') -----
  methodListMenu: aMenu
        selection ifNotNil:
                [aMenu addList: #(
                        ('install'       installSelection)
                        ('revert (x)'    revertSelection)
                        ('browse origin' browseSelectionOrigin)
                        -)].
        self unchangedMethods ifNotEmpty:
                [aMenu addList: #(
                        ('revert unchanged methods...'  revertUnchangedMethods)
+                       ('filter out unchanged methods...'      filterOutUnchangedMethods)
                        -)].
        super methodListMenu: aMenu.
        ^ aMenu!

Item was changed:
  ----- Method: MCOperationsBrowser>>revertUnchangedMethods (in category 'actions') -----
  revertUnchangedMethods
        "revert methods that only have changed timestamps"
        | loader unchangedMethods |
+       unchangedMethods := self unchangedMethods.
+       (self confirm: ('Revert {1} methods that only differ in timestamp?' translated
+               format: {unchangedMethods size}))
+               ifTrue:
+                       [loader := MCPackageLoader new.
-       unchangedMethods := items select: [:op | op isUnchangedMethod].
-       (self confirm: ('Revert {1} methods that only differ in timestamp?' translated format: {unchangedMethods size}))
-               ifTrue: [
-                       loader := MCPackageLoader new.
                        unchangedMethods do: [:op | op inverse applyTo: loader].
                        loader loadWithName: self changeSetNameForInstall].
  !

Hi Eliot, this concerning to me from the aspect that committing a change with only the timestamp changed is something that shouldn't be done.  Would it not pollute your version history with a bunch of "non-changes" noise?

On Fri, Jan 24, 2020 at 8:17 PM <[hidden email]> wrote:

A new version of Monticello was added to project The Inbox:
http://source.squeak.org/inbox/Monticello-eem.709.mcz

==================== Summary ====================

Name: Monticello-eem.709
Author: eem
Time: 24 January 2020, 6:17:42.907101 pm
UUID: ec11ed59-223d-4b58-aa08-c214e1ceb2e9
Ancestors: Monticello-cmm.708

Provide 'filter out unchanged methods...' to ignore any timestamp-only changes.

=============== Diff against Monticello-cmm.708 ===============

Item was added:
+ ----- Method: MCOperationsBrowser>>filterOutUnchangedMethods (in category 'actions') -----
+ filterOutUnchangedMethods
+       "Remove from the list methods that only have changed timestamps"
+       | unchangedMethods |
+       unchangedMethods := self unchangedMethods.
+       (self confirm: ('Ignore {1} methods that only differ in timestamp?' translated
+               format: {unchangedMethods size}))
+               ifTrue:
+                       [items := items reject: [:op| op isUnchangedMethod].
+                        self changed: #list]
+ !

Item was changed:
  ----- Method: MCOperationsBrowser>>methodListMenu: (in category 'menus') -----
  methodListMenu: aMenu
        selection ifNotNil:
                [aMenu addList: #(
                        ('install'       installSelection)
                        ('revert (x)'    revertSelection)
                        ('browse origin' browseSelectionOrigin)
                        -)].
        self unchangedMethods ifNotEmpty:
                [aMenu addList: #(
                        ('revert unchanged methods...'  revertUnchangedMethods)
+                       ('filter out unchanged methods...'      filterOutUnchangedMethods)
                        -)].
        super methodListMenu: aMenu.
        ^ aMenu!

Item was changed:
  ----- Method: MCOperationsBrowser>>revertUnchangedMethods (in category 'actions') -----
  revertUnchangedMethods
        "revert methods that only have changed timestamps"
        | loader unchangedMethods |
+       unchangedMethods := self unchangedMethods.
+       (self confirm: ('Revert {1} methods that only differ in timestamp?' translated
+               format: {unchangedMethods size}))
+               ifTrue:
+                       [loader := MCPackageLoader new.
-       unchangedMethods := items select: [:op | op isUnchangedMethod].
-       (self confirm: ('Revert {1} methods that only differ in timestamp?' translated format: {unchangedMethods size}))
-               ifTrue: [
-                       loader := MCPackageLoader new.
                        unchangedMethods do: [:op | op inverse applyTo: loader].
                        loader loadWithName: self changeSetNameForInstall].
  !

Hi Chris,

   you may have the use case backwards. Here's what happened today.  I opened Guille's VMMaker.oscog-GuillermoPolito.2676 which is in VMMakerInbox and was shown many thousands of methods which said "different only in timestamps".  My task was to find the methods that were not* different only in time stamps.  I did this by implementing the filter operation (revert unchanged methods spends a lot of time doing nothing; it does not remove the noise).  Once I could see the four methods that differed other than by timestamp (two of mine, two of Guille's) I could load Guille's methods, effecting a manual merge.  I then committed something that didn't inherit from VMMaker.oscog-GuillermoPolito.2676 (because if I did it would introduce all those noisy non-differences), but did include the relevant changes.  Does the menu item  make more sense now?

On Fri, Jan 24, 2020 at 6:56 PM Chris Muller <[hidden email]> wrote:

Hi Eliot, this concerning to me from the aspect that committing a change with only the timestamp changed is something that shouldn't be done.  Would it not pollute your version history with a bunch of "non-changes" noise?

On Fri, Jan 24, 2020 at 8:17 PM <[hidden email]> wrote:

A new version of Monticello was added to project The Inbox:
http://source.squeak.org/inbox/Monticello-eem.709.mcz

==================== Summary ====================

Name: Monticello-eem.709
Author: eem
Time: 24 January 2020, 6:17:42.907101 pm
UUID: ec11ed59-223d-4b58-aa08-c214e1ceb2e9
Ancestors: Monticello-cmm.708

Provide 'filter out unchanged methods...' to ignore any timestamp-only changes.

=============== Diff against Monticello-cmm.708 ===============

Item was added:
+ ----- Method: MCOperationsBrowser>>filterOutUnchangedMethods (in category 'actions') -----
+ filterOutUnchangedMethods
+       "Remove from the list methods that only have changed timestamps"
+       | unchangedMethods |
+       unchangedMethods := self unchangedMethods.
+       (self confirm: ('Ignore {1} methods that only differ in timestamp?' translated
+               format: {unchangedMethods size}))
+               ifTrue:
+                       [items := items reject: [:op| op isUnchangedMethod].
+                        self changed: #list]
+ !

Item was changed:
  ----- Method: MCOperationsBrowser>>methodListMenu: (in category 'menus') -----
  methodListMenu: aMenu
        selection ifNotNil:
                [aMenu addList: #(
                        ('install'       installSelection)
                        ('revert (x)'    revertSelection)
                        ('browse origin' browseSelectionOrigin)
                        -)].
        self unchangedMethods ifNotEmpty:
                [aMenu addList: #(
                        ('revert unchanged methods...'  revertUnchangedMethods)
+                       ('filter out unchanged methods...'      filterOutUnchangedMethods)
                        -)].
        super methodListMenu: aMenu.
        ^ aMenu!

Item was changed:
  ----- Method: MCOperationsBrowser>>revertUnchangedMethods (in category 'actions') -----
  revertUnchangedMethods
        "revert methods that only have changed timestamps"
        | loader unchangedMethods |
+       unchangedMethods := self unchangedMethods.
+       (self confirm: ('Revert {1} methods that only differ in timestamp?' translated
+               format: {unchangedMethods size}))
+               ifTrue:
+                       [loader := MCPackageLoader new.
-       unchangedMethods := items select: [:op | op isUnchangedMethod].
-       (self confirm: ('Revert {1} methods that only differ in timestamp?' translated format: {unchangedMethods size}))
-               ifTrue: [
-                       loader := MCPackageLoader new.
                        unchangedMethods do: [:op | op inverse applyTo: loader].
                        loader loadWithName: self changeSetNameForInstall].
  !

--

_,,,^..^,,,_

best, Eliot

Chris Muller <[hidden email]> schrieb am Mi., 29. Jan. 2020, 23:40:

On Wed, Jan 29, 2020 at 1:04 AM Jakob Reschke <[hidden email]> wrote:

Chris Muller <[hidden email]> schrieb am Mi., 29. Jan. 2020, 03:57:

It's important this feature does not get inherited by SaveDialog since the functionality could be harmful if used there

How so? What is bad about wittingly ignoring non-changes during save? You called it pollution yourself.

Jakob, your language is confusing because "Ignore" is the other command there that, yes, would cause them to not be committed.

But what is being added is a 'filter out unchanged methods from the list...', which, IIUC, would only remove them from the list, making them invisible, but not "Ignore" them.  So, if used on the Save dialog, would they be included in the commit?

Alright if it does not work there it should be fixed in the second iteration of course. I didn't test it. Ignoring instead of removing on save sounds reasonable, then you can change your mind later (although in this case, why would you...).

I suppose this can be covered by a unit test.