Smalltalk › Squeak › Squeak - Dev

The Inbox: Monticello-jr.707.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

4 messages Options

commits-2

The Inbox: Monticello-jr.707.mcz

A new version of Monticello was added to project The Inbox:
http://source.squeak.org/inbox/Monticello-jr.707.mcz

==================== Summary ====================

Name: Monticello-jr.707
Author: jr
Time: 29 December 2019, 6:42:29.985327 pm
UUID: 5f498b54-b255-a140-bd55-c5f01b5b03ca
Ancestors: Monticello-ct.706

Don't log source if system changes are suppressed.

To be able to make some tests less noisy in the changes file.

=============== Diff against Monticello-ct.706 ===============

Item was changed:
----- Method: MCMethodDefinition>>asMethodAddition (in category 'converting') -----
asMethodAddition
^MethodAddition new
compile: source
classified: category
withStamp: timeStamp
notifying: nil
+ logSource: SystemChangeNotifier uniqueInstance isBroadcasting
- logSource: true
inClass: self actualClass.!

Tobias Pape

Re: The Inbox: Monticello-jr.707.mcz

> On 29.12.2019, at 18:42, [hidden email] wrote:
>
> A new version of Monticello was added to project The Inbox:
> http://source.squeak.org/inbox/Monticello-jr.707.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-jr.707
> Author: jr

Isn't Jakob Trunk-commiter already? :D

> Time: 29 December 2019, 6:42:29.985327 pm
> UUID: 5f498b54-b255-a140-bd55-c5f01b5b03ca
> Ancestors: Monticello-ct.706
>
> Don't log source if system changes are suppressed.
>
> To be able to make some tests less noisy in the changes file.
>
> =============== Diff against Monticello-ct.706 ===============
>
> Item was changed:
> ----- Method: MCMethodDefinition>>asMethodAddition (in category 'converting') -----
> asMethodAddition
> ^MethodAddition new
> compile: source
> classified: category
> withStamp: timeStamp
> notifying: nil
> + logSource: SystemChangeNotifier uniqueInstance isBroadcasting
> - logSource: true
> inClass: self actualClass.!
>
>

Nicolas Cellier

Re: The Inbox: Monticello-jr.707.mcz

Le dim. 29 déc. 2019 à 19:07, Tobias Pape <[hidden email]> a écrit :

> On 29.12.2019, at 18:42, [hidden email] wrote:
>
> A new version of Monticello was added to project The Inbox:
> http://source.squeak.org/inbox/Monticello-jr.707.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-jr.707
> Author: jr

Isn't Jakob Trunk-commiter already? :D

I don't think so.

However, concerning this change, it's better to think twice.

There are a lot of senders of doSilently: and I don't think that the intention was to not log into .changes

Are we sure that we will not loose source code of installed stuff?

> Time: 29 December 2019, 6:42:29.985327 pm
> UUID: 5f498b54-b255-a140-bd55-c5f01b5b03ca
> Ancestors: Monticello-ct.706
>
> Don't log source if system changes are suppressed.
>
> To be able to make some tests less noisy in the changes file.
>
> =============== Diff against Monticello-ct.706 ===============
>
> Item was changed:
> ----- Method: MCMethodDefinition>>asMethodAddition (in category 'converting') -----
> asMethodAddition
> ^MethodAddition new
> compile: source
> classified: category
> withStamp: timeStamp
> notifying: nil
> + logSource: SystemChangeNotifier uniqueInstance isBroadcasting
> - logSource: true
> inClass: self actualClass.!
>
>

Jakob Reschke

Re: The Inbox: Monticello-jr.707.mcz

Nicolas Cellier <[hidden email]> schrieb am So., 29. Dez. 2019, 19:26:

However, concerning this change, it's better to think twice.

That's why it is here now. :-)

There are a lot of senders of doSilently: and I don't think that the intention was to not log into .changes
Are we sure that we will not loose source code of installed stuff?

If there is a more appropriate way to mask changes loaded during tests, I will be glad to use it.

Currently I sprinkle doSilently: all over those tests but the Monticello loadings still get logged. I wish they were silent, but how to control this?