The Inbox: Monticello-topa.584.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Monticello-topa.584.mcz

commits-2
A new version of Monticello was added to project The Inbox:
http://source.squeak.org/inbox/Monticello-topa.584.mcz

==================== Summary ====================

Name: Monticello-topa.584
Author: topa
Time: 25 January 2014, 10:00:32.75 pm
UUID: 9e0c437a-a18c-4e31-ac9e-775246bea49d
Ancestors: Monticello-cmm.583

The number of distinct authors in the image is low:
(MCVersionInfo allInstances collect: [ :each | each author ]) asIdentitySet size.  "13336"
(MCVersionInfo allInstances collect: [ :each | each author ]) asSet size. "128"

Hence, we can safely store them as symbols.
This does not save much memory in a small image but should in
production images.

=============== Diff against Monticello-cmm.583 ===============

Item was changed:
  ----- Method: MCVersionInfo>>asDictionary (in category 'converting') -----
  asDictionary
  ^ Dictionary new
  at: #name put: name;
  at: #id put: id asString;
  at: #message put: message;
  at: #date put: date;
  at: #time put: time;
+ at: #author put: self author;
- at: #author put: author;
  at: #ancestors put: (self ancestors collect: [:a | a asDictionary]);
  yourself!

Item was changed:
  ----- Method: MCVersionInfo>>author (in category 'pillaging') -----
  author
+ ^ author asString!
- ^ author!

Item was changed:
  ----- Method: MCVersionInfo>>initializeWithName:id:message:date:time:author:ancestors:stepChildren: (in category 'initialize-release') -----
+ initializeWithName: vName id: aUUID message: aString date: aDate
+
+ ----QUIT/NOSAVE----{25 January 2014 . 9:51:21 pm} Squeak4.5-13148.image priorSource: 10755666!
- initializeWithName: vName id: aUUID message: aString date: aDate time: aTime author: initials ancestors: aCollection stepChildren: stepCollection
- name := vName asString asMCVersionName.
- id := aUUID.
- message := aString.
- date := aDate.
- time := aTime.
- author := initials.
- ancestors :=  aCollection.
- stepChildren := stepCollection!

Item was changed:
  ----- Method: MCVersionInfo>>summaryHeader (in category 'accessing') -----
  summaryHeader
  ^ String streamContents:
  [:s |
  s
  nextPutAll: 'Name: '; nextPutAll: self name; cr.
  date ifNotNil:
  [s
+ nextPutAll: 'Author: '; nextPutAll: self author; cr;
- nextPutAll: 'Author: '; nextPutAll: author; cr;
  nextPutAll: 'Time: '; nextPutAll:  date asString, ', ', time asString; cr].
  id ifNotNil:
  [s nextPutAll: 'UUID: '; nextPutAll: id asString; cr].
  s
  nextPutAll: 'Ancestors: '; nextPutAll: self ancestorString.
  self stepChildren isEmpty ifFalse:
  [s cr; nextPutAll: 'Backported From: '; nextPutAll: self stepChildrenString].
  ]!

Item was added:
+ (PackageInfo named: 'Monticello') postscript: '(MCVersionInfo allInstances select: [ :ea | (ea instVarNamed: ''author'') isSymbol not ])
+ do: [ :ea | ea instVarNamed: ''author'' put: (ea instVarNamed: ''author'') asSymbol]'!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Monticello-topa.584.mcz

Tobias Pape
Arg, my changes file is corrupted :(

i'll redo that. can someone pleas remove this very version?

Best
        -Tobias

On 25.01.2014, at 21:00, [hidden email] wrote:

> A new version of Monticello was added to project The Inbox:
> http://source.squeak.org/inbox/Monticello-topa.584.mcz
>
> ==================== Summary ====================
>
> Name: Monticello-topa.584
> Author: topa
> Time: 25 January 2014, 10:00:32.75 pm
> UUID: 9e0c437a-a18c-4e31-ac9e-775246bea49d
> Ancestors: Monticello-cmm.583
>
> The number of distinct authors in the image is low:
> (MCVersionInfo allInstances collect: [ :each | each author ]) asIdentitySet size.  "13336"
> (MCVersionInfo allInstances collect: [ :each | each author ]) asSet size. "128"
>
> Hence, we can safely store them as symbols.
> This does not save much memory in a small image but should in
> production images.
>
> =============== Diff against Monticello-cmm.583 ===============
>
> Item was changed:
>  ----- Method: MCVersionInfo>>asDictionary (in category 'converting') -----
>  asDictionary
>   ^ Dictionary new
>   at: #name put: name;
>   at: #id put: id asString;
>   at: #message put: message;
>   at: #date put: date;
>   at: #time put: time;
> + at: #author put: self author;
> - at: #author put: author;
>   at: #ancestors put: (self ancestors collect: [:a | a asDictionary]);
>   yourself!
>
> Item was changed:
>  ----- Method: MCVersionInfo>>author (in category 'pillaging') -----
>  author
> + ^ author asString!
> - ^ author!
>
> Item was changed:
>  ----- Method: MCVersionInfo>>initializeWithName:id:message:date:time:author:ancestors:stepChildren: (in category 'initialize-release') -----
> + initializeWithName: vName id: aUUID message: aString date: aDate
> +
> + ----QUIT/NOSAVE----{25 January 2014 . 9:51:21 pm} Squeak4.5-13148.image priorSource: 10755666!
> - initializeWithName: vName id: aUUID message: aString date: aDate time: aTime author: initials ancestors: aCollection stepChildren: stepCollection
> - name := vName asString asMCVersionName.
> - id := aUUID.
> - message := aString.
> - date := aDate.
> - time := aTime.
> - author := initials.
> - ancestors :=  aCollection.
> - stepChildren := stepCollection!
>
> Item was changed:
>  ----- Method: MCVersionInfo>>summaryHeader (in category 'accessing') -----
>  summaryHeader
>   ^ String streamContents:
>   [:s |
>   s
>   nextPutAll: 'Name: '; nextPutAll: self name; cr.
>   date ifNotNil:
>   [s
> + nextPutAll: 'Author: '; nextPutAll: self author; cr;
> - nextPutAll: 'Author: '; nextPutAll: author; cr;
>   nextPutAll: 'Time: '; nextPutAll:  date asString, ', ', time asString; cr].
>   id ifNotNil:
>   [s nextPutAll: 'UUID: '; nextPutAll: id asString; cr].
>   s
>   nextPutAll: 'Ancestors: '; nextPutAll: self ancestorString.
>   self stepChildren isEmpty ifFalse:
>   [s cr; nextPutAll: 'Backported From: '; nextPutAll: self stepChildrenString].
>   ]!
>
> Item was added:
> + (PackageInfo named: 'Monticello') postscript: '(MCVersionInfo allInstances select: [ :ea | (ea instVarNamed: ''author'') isSymbol not ])
> + do: [ :ea | ea instVarNamed: ''author'' put: (ea instVarNamed: ''author'') asSymbol]'!
>
>


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Monticello-topa.584.mcz

Frank Shearar-3
On 25 January 2014 21:03, Tobias Pape <[hidden email]> wrote:
> Arg, my changes file is corrupted :(
>
> i'll redo that. can someone pleas remove this very version?

Done.

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Monticello-topa.584.mcz

Tobias Pape
thanks.

--
Tobias Pape
sent from a mobile device

> Am 26.01.2014 um 12:09 schrieb Frank Shearar <[hidden email]>:
>
>> On 25 January 2014 21:03, Tobias Pape <[hidden email]> wrote:
>> Arg, my changes file is corrupted :(
>>
>> i'll redo that. can someone pleas remove this very version?
>
> Done.
>
> frank
>