The Inbox: Morphic-ct.1500.mcz

Hi all,

is MenuMorph>>#filterListWith: still up to date? Has no senders (in my image) and looks like a duplicate of #handleFiltering:. But it does not display the filter.

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Samstag, 10. August 2019 01:43:38
An: [hidden email]
Betreff: [squeak-dev] The Inbox: Morphic-ct.1500.mcz

 

A new version of Morphic was added to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1500.mcz

==================== Summary ====================

Name: Morphic-ct.1500
Author: ct
Time: 10 August 2019, 1:43:30.153412 am
UUID: 3c117318-6d64-f14e-b166-ebee4ed792f7
Ancestors: Morphic-mt.1498

Refactor menu filtering to ignore special keys like Character end

=============== Diff against Morphic-mt.1498 ===============

Item was changed:
  ----- Method: MenuMorph>>handleFiltering: (in category 'keystroke helpers') -----
  handleFiltering: evt
 
         | matchString |
         matchString := self valueOfProperty: #matchString ifAbsentPut: [ String new ].
+        matchString := true
+                caseOf: {
+                        [ evt keyCharacter = Character backspace ] ->
+                                [ matchString isEmpty
+                                        ifTrue: [ matchString ]
+                                        ifFalse: [ matchString allButLast ] ].
+                        [ evt keyValue >= 32 ] ->
+                                [ matchString , evt keyCharacter ] }
+                otherwise: [ matchString ].
-        matchString := evt keyValue = 8 " Character backspace asciiValue "
-                ifTrue: [
-                        matchString isEmpty
-                                ifTrue: [ matchString ]
-                                ifFalse: [ matchString allButLast ] ]
-                ifFalse: [
-                        matchString copyWith: evt keyCharacter ].
         self setProperty: #matchString toValue: matchString.
         self displayFiltered: evt!

Could somebody please move this to the trunk?

--Hannes

On 8/11/19, Chris Muller  wrote:
> It looks abandoned.  I think you're right.
>  - Chris
>
> On Fri, Aug 9, 2019 at 6:46 PM Thiede, Christoph <
> [hidden email]> wrote:
>
>> Hi all,
>>
>>
>> is MenuMorph>>#filterListWith: still up to date? Has no senders (in my
>> image) and looks like a duplicate of #handleFiltering:. But it does not
>> display the filter.
>>
>>
>> Best,
>>
>> Christoph
>> ------------------------------
>> *Von:* Squeak-dev  im
>> Auftrag von [hidden email] 
>> *Gesendet:* Samstag, 10. August 2019 01:43:38
>> *An:* [hidden email]
>> *Betreff:* [squeak-dev] The Inbox: Morphic-ct.1500.mcz
>>
>> A new version of Morphic was added to project The Inbox:
>> http://source.squeak.org/inbox/Morphic-ct.1500.mcz
>>
>> ==================== Summary ====================
>>
>> Name: Morphic-ct.1500
>> Author: ct
>> Time: 10 August 2019, 1:43:30.153412 am
>> UUID: 3c117318-6d64-f14e-b166-ebee4ed792f7
>> Ancestors: Morphic-mt.1498
>>
>> Refactor menu filtering to ignore special keys like Character end
>>
>> =============== Diff against Morphic-mt.1498 ===============
>>
>> Item was changed:
>>   ----- Method: MenuMorph>>handleFiltering: (in category 'keystroke
>> helpers') -----
>>   handleFiltering: evt
>>
>>          | matchString |
>>          matchString := self valueOfProperty: #matchString ifAbsentPut: [
>> String new ].
>> +        matchString := true
>> +                caseOf: {
>> +                        [ evt keyCharacter = Character backspace ] ->
>> +                                [ matchString isEmpty
>> +                                        ifTrue: [ matchString ]
>> +                                        ifFalse: [ matchString
>> allButLast
>> ] ].
>> +                        [ evt keyValue >= 32 ] ->
>> +                                [ matchString , evt keyCharacter ] }
>> +                otherwise: [ matchString ].
>> -        matchString := evt keyValue = 8 " Character backspace asciiValue
>> "
>> -                ifTrue: [
>> -                        matchString isEmpty
>> -                                ifTrue: [ matchString ]
>> -                                ifFalse: [ matchString allButLast ] ]
>> -                ifFalse: [
>> -                        matchString copyWith: evt keyCharacter ].
>>          self setProperty: #matchString toValue: matchString.
>>          self displayFiltered: evt!
>>
>>
>>
>>
>