The Inbox: Morphic-ct.1624.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Morphic-ct.1624.mcz

commits-2
Christoph Thiede uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1624.mcz

==================== Summary ====================

Name: Morphic-ct.1624
Author: ct
Time: 5 February 2020, 10:01:38.455675 am
UUID: 232459ff-c526-a546-b734-e6b8c6366657
Ancestors: Morphic-cmm.1618

Fixes a bug when undoing dismissal of a SelectionMorph. In the past, this only restored the SelectionMorph itself but not its items.

Please note this solution is not optimal because it abuses #intoWorld:. However, I don't see any unwanted side effects at the moment ... Maybe we would like to introduce an extra hook for this in #reintroduceIntoWorld:?

=============== Diff against Morphic-cmm.1618 ===============

Item was added:
+ ----- Method: SelectionMorph>>intoWorld: (in category 'initialization') -----
+ intoWorld: aWorld
+
+ selectedItems ifNotEmpty: [
+ "Restore selected items for #reintroduceIntoWorld:"
+ selectedItems do: [:morph |
+ aWorld reintroduceIntoWorld: morph].
+ ^ self delete].
+ super intoWorld: aWorld.!