The Inbox: Morphic-ct.1633.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Morphic-ct.1633.mcz

commits-2
Christoph Thiede uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1633.mcz

==================== Summary ====================

Name: Morphic-ct.1633
Author: ct
Time: 29 February 2020, 11:33:45.993896 am
UUID: f258f893-f17e-f245-af98-b875a4701f7e
Ancestors: Morphic-mt.1631

Fixes MorphicHierarchy, which was broken because #world is nil before opening the list in the world.

=============== Diff against Morphic-mt.1631 ===============

Item was changed:
  ----- Method: MorphHierarchyListMorph>>createContainer (in category 'private') -----
  createContainer
  "Private - Create a container"
  | container |
  container := BorderedMorph new.
+ container extent: (self currentWorld extent * (1 / 4 @ (2 / 3))) rounded.
- container extent: (self world extent * (1 / 4 @ (2 / 3))) rounded.
  container layoutPolicy: TableLayout new.
  container hResizing: #rigid.
  container vResizing: #rigid.
  container
  color: (Color gray: 0.9);
  borderWidth: 1;
  borderColor: Color gray.
  container layoutInset: 0.
  "container useRoundedCorners."
  ""
  container setProperty: #morphHierarchy toValue: true.
  container setNameTo: 'Objects Hierarchy' translated.
  ""
  ^ container!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Morphic-ct.1633.mcz

marcel.taeumel
-1

#currentWorld is like a global. Can you think of a better solution for MorphicHierarchy? :-)

Best,
Marcel

Am 29.02.2020 11:34:05 schrieb [hidden email] <[hidden email]>:

Christoph Thiede uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1633.mcz

==================== Summary ====================

Name: Morphic-ct.1633
Author: ct
Time: 29 February 2020, 11:33:45.993896 am
UUID: f258f893-f17e-f245-af98-b875a4701f7e
Ancestors: Morphic-mt.1631

Fixes MorphicHierarchy, which was broken because #world is nil before opening the list in the world.

=============== Diff against Morphic-mt.1631 ===============

Item was changed:
----- Method: MorphHierarchyListMorph>>createContainer (in category 'private') -----
createContainer
"Private - Create a container"
| container |
container := BorderedMorph new.
+ container extent: (self currentWorld extent * (1 / 4 @ (2 / 3))) rounded.
- container extent: (self world extent * (1 / 4 @ (2 / 3))) rounded.
container layoutPolicy: TableLayout new.
container hResizing: #rigid.
container vResizing: #rigid.
container
color: (Color gray: 0.9);
borderWidth: 1;
borderColor: Color gray.
container layoutInset: 0.
"container useRoundedCorners."
""
container setProperty: #morphHierarchy toValue: true.
container setNameTo: 'Objects Hierarchy' translated.
""
^ container!