Smalltalk › Squeak › Squeak - Dev

The Inbox: Morphic-ct.1675.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Inbox: Morphic-ct.1675.mcz

A new version of Morphic was added to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1675.mcz

==================== Summary ====================

Name: Morphic-ct.1675
Author: ct
Time: 20 August 2020, 6:38:23.443941 pm
UUID: b76420e2-369c-7547-89c9-e553ffc4aa7c
Ancestors: Morphic-mt.1674

Proposal to fix unreliable text dragging into text morphs as described in http://forum.world.st/BUG-Text-drag-and-drop-to-workspace-unreliable-td5109035.html

=============== Diff against Morphic-mt.1674 ===============

Item was added:
+ ----- Method: PluggableTextMorph>>handleDropMorph: (in category 'dropping/grabbing') -----
+ handleDropMorph: anEvent
+
+ "Give TextMorphForEditView another chance to handle the drop. It did not get any chance before if it is smaller than ourselves."
+ textMorph handleDropMorph: anEvent.
+
+ "If the event has been handled now, super will ignore it."
+ ^ super handleDropMorph: anEvent!

Jakob Reschke

Re: The Inbox: Morphic-ct.1675.mcz

+1 together with Morphic-ct.1676

Christoph, do I assume correctly that this code won't be reached if
the textMorph already processed the event because it was large enough?
Could there be a double delivery of the event to the text morph under
any circumstances?

Am Do., 20. Aug. 2020 um 18:38 Uhr schrieb <[hidden email]>:

>
> A new version of Morphic was added to project The Inbox:
> http://source.squeak.org/inbox/Morphic-ct.1675.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-ct.1675
> Author: ct
> Time: 20 August 2020, 6:38:23.443941 pm
> UUID: b76420e2-369c-7547-89c9-e553ffc4aa7c
> Ancestors: Morphic-mt.1674
>
> Proposal to fix unreliable text dragging into text morphs as described in http://forum.world.st/BUG-Text-drag-and-drop-to-workspace-unreliable-td5109035.html
>
> =============== Diff against Morphic-mt.1674 ===============
>
> Item was added:
> + ----- Method: PluggableTextMorph>>handleDropMorph: (in category 'dropping/grabbing') -----
> + handleDropMorph: anEvent
> +
> + "Give TextMorphForEditView another chance to handle the drop. It did not get any chance before if it is smaller than ourselves."
> + textMorph handleDropMorph: anEvent.
> +
> + "If the event has been handled now, super will ignore it."
> + ^ super handleDropMorph: anEvent!
>
>