Smalltalk › Squeak › Squeak - Dev

The Inbox: Morphic-ct.1691.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

5 messages Options

commits-2

The Inbox: Morphic-ct.1691.mcz

Christoph Thiede uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1691.mcz

==================== Summary ====================

Name: Morphic-ct.1691
Author: ct
Time: 1 October 2020, 2:50:08.612807 am
UUID: f9f5e618-2e8a-3f4b-a1f8-1c9aca2b5f01
Ancestors: Morphic-eem.1686

Fixes alpha selection strip in HSVA color selector, which has always lived one click back in past.

=============== Diff against Morphic-eem.1686 ===============

Item was changed:
----- Method: HSVAColorSelectorMorph>>alphaSelected: (in category 'accessing') -----
alphaSelected: aFloat
"The alpha has changed."

+ self aMorph value: aFloat.
self triggerSelectedColor!

marcel.taeumel

Re: The Inbox: Morphic-ct.1691.mcz

Hehe. "aMorph" is a good example for unfortunate naming. Took me a while to figure out that the "a" stands for "alpha" after reading the list of inst vars: hsvMorph, aMorph :-D

Best,

Marcel

Am 01.10.2020 02:50:29 schrieb [hidden email] <[hidden email]>:
Christoph Thiede uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1691.mcz

==================== Summary ====================

Name: Morphic-ct.1691
Author: ct
Time: 1 October 2020, 2:50:08.612807 am
UUID: f9f5e618-2e8a-3f4b-a1f8-1c9aca2b5f01
Ancestors: Morphic-eem.1686

Fixes alpha selection strip in HSVA color selector, which has always lived one click back in past.

=============== Diff against Morphic-eem.1686 ===============

Item was changed:
----- Method: HSVAColorSelectorMorph>>alphaSelected: (in category 'accessing') -----
alphaSelected: aFloat
"The alpha has changed."

+ self aMorph value: aFloat.
self triggerSelectedColor!

Christoph Thiede

Re: The Inbox: Morphic-ct.1691.mcz

Would you like me to rename it or is this not worth the effort? :-)

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Mittwoch, 7. Oktober 2020 09:11:53
An: squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1691.mcz

Hehe. "aMorph" is a good example for unfortunate naming. Took me a while to figure out that the "a" stands for "alpha" after reading the list of inst vars: hsvMorph, aMorph :-D

Best,

Marcel

Am 01.10.2020 02:50:29 schrieb [hidden email] <[hidden email]>:

Christoph Thiede uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1691.mcz

==================== Summary ====================

Name: Morphic-ct.1691
Author: ct
Time: 1 October 2020, 2:50:08.612807 am
UUID: f9f5e618-2e8a-3f4b-a1f8-1c9aca2b5f01
Ancestors: Morphic-eem.1686

Fixes alpha selection strip in HSVA color selector, which has always lived one click back in past.

=============== Diff against Morphic-eem.1686 ===============

Item was changed:
----- Method: HSVAColorSelectorMorph>>alphaSelected: (in category 'accessing') -----
alphaSelected: aFloat
"The alpha has changed."

+ self aMorph value: aFloat.
self triggerSelectedColor!

Carpe Squeak!

marcel.taeumel

Re: The Inbox: Morphic-ct.1691.mcz

Hi Christoph,

no worries. This was just an observation. Maybe the next time we touch that class, we can improve the code.

Best,

Marcel

Am 07.10.2020 13:56:17 schrieb Thiede, Christoph <[hidden email]>:

Would you like me to rename it or is this not worth the effort? :-)

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Mittwoch, 7. Oktober 2020 09:11:53
An: squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1691.mcz

Hehe. "aMorph" is a good example for unfortunate naming. Took me a while to figure out that the "a" stands for "alpha" after reading the list of inst vars: hsvMorph, aMorph :-D

Best,

Marcel

Am 01.10.2020 02:50:29 schrieb [hidden email] <[hidden email]>:

Christoph Thiede uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1691.mcz

==================== Summary ====================

Name: Morphic-ct.1691
Author: ct
Time: 1 October 2020, 2:50:08.612807 am
UUID: f9f5e618-2e8a-3f4b-a1f8-1c9aca2b5f01
Ancestors: Morphic-eem.1686

Fixes alpha selection strip in HSVA color selector, which has always lived one click back in past.

=============== Diff against Morphic-eem.1686 ===============

Item was changed:
----- Method: HSVAColorSelectorMorph>>alphaSelected: (in category 'accessing') -----
alphaSelected: aFloat
"The alpha has changed."

+ self aMorph value: aFloat.
self triggerSelectedColor!

Eliot Miranda-2

Re: The Inbox: Morphic-ct.1691.mcz

On Oct 8, 2020, at 4:09 AM, Marcel Taeumel <[hidden email]> wrote:

Hi Christoph,

no worries. This was just an observation. Maybe the next time we touch that class, we can improve the code.

Best,
Marcel

Am 07.10.2020 13:56:17 schrieb Thiede, Christoph <[hidden email]>:

Would you like me to rename it or is this not worth the effort? :-)

I think it’s worth the effort. The refactoring tools should make this a very quick fix :-)

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Mittwoch, 7. Oktober 2020 09:11:53
An: squeak-dev
Betreff: Re: [squeak-dev] The Inbox: Morphic-ct.1691.mcz

Hehe. "aMorph" is a good example for unfortunate naming. Took me a while to figure out that the "a" stands for "alpha" after reading the list of inst vars: hsvMorph, aMorph :-D

Best,

Marcel

Am 01.10.2020 02:50:29 schrieb [hidden email] <[hidden email]>:

Christoph Thiede uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1691.mcz

==================== Summary ====================

Name: Morphic-ct.1691
Author: ct
Time: 1 October 2020, 2:50:08.612807 am
UUID: f9f5e618-2e8a-3f4b-a1f8-1c9aca2b5f01
Ancestors: Morphic-eem.1686

Fixes alpha selection strip in HSVA color selector, which has always lived one click back in past.

=============== Diff against Morphic-eem.1686 ===============

Item was changed:
----- Method: HSVAColorSelectorMorph>>alphaSelected: (in category 'accessing') -----
alphaSelected: aFloat
"The alpha has changed."

+ self aMorph value: aFloat.
self triggerSelectedColor!