Smalltalk › Squeak › Squeak - Dev

The Inbox: Morphic-ct.1709.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Inbox: Morphic-ct.1709.mcz

A new version of Morphic was added to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1709.mcz

==================== Summary ====================

Name: Morphic-ct.1709
Author: ct
Time: 28 October 2020, 9:19:49.476652 pm
UUID: 14a43f24-c7eb-1f4d-9928-48a4e9231bac
Ancestors: Morphic-mt.1708

Make sure an obsolete progress bar does not remain on the screen after the operation has completed.

Example:
(1 to: 3) do: [:i | 1 second wait] displayingProgress: 'I should be visible for no longer than 3 seconds'. 2 seconds wait.

=============== Diff against Morphic-mt.1708 ===============

Item was changed:
----- Method: SystemProgressMorph>>freeSlot: (in category 'private') -----
freeSlot: number
+
number > 0 ifFalse: [^self].
lock critical: [| label |
label := self labels at: number.
(label isNil or: [label owner isNil]) ifTrue: [^self]. "Has been freed before"
label delete.
(self bars at: number) delete.
self activeSlots: self activeSlots - 1.
self activeSlots = 0
ifTrue: [self delete]
+ ifFalse: [self reposition]].
+ self currentWorld displayWorld.!
- ifFalse: [self reposition]]!

Christoph Thiede

Re: The Inbox: Morphic-ct.1709.mcz

Hm, this probably belongs to the category "tricky".

I experienced some scenarios similar to the given snippet in which the remaining progress bar was definitively confusing.

On the other hand, the usual Monticello workflow looks quite different with this change because the progress bars only pop up for a very short moment and most of the time no progress bar can be seen.

However, conceptionally, I'd rather like to fix the latter observation in Monticello, i.e. move up the code that triggers the progress bars in the stack. Any objections? :-)

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Mittwoch, 28. Oktober 2020 21:19:59
An: [hidden email]
Betreff: [squeak-dev] The Inbox: Morphic-ct.1709.mcz

A new version of Morphic was added to project The Inbox:
http://source.squeak.org/inbox/Morphic-ct.1709.mcz

==================== Summary ====================

Name: Morphic-ct.1709
Author: ct
Time: 28 October 2020, 9:19:49.476652 pm
UUID: 14a43f24-c7eb-1f4d-9928-48a4e9231bac
Ancestors: Morphic-mt.1708

Make sure an obsolete progress bar does not remain on the screen after the operation has completed.

Example:
        (1 to: 3) do: [:i | 1 second wait] displayingProgress: 'I should be visible for no longer than 3 seconds'. 2 seconds wait.

=============== Diff against Morphic-mt.1708 ===============

Item was changed:
----- Method: SystemProgressMorph>>freeSlot: (in category 'private') -----
freeSlot: number
+
         number > 0 ifFalse: [^self].
         lock critical: [| label |
                 label := self labels at: number.
                 (label isNil or: [label owner isNil]) ifTrue: [^self]. "Has been freed before"
                 label delete.
                 (self bars at: number) delete.
                 self activeSlots: self activeSlots - 1.
                 self activeSlots = 0
                         ifTrue: [self delete]
+                        ifFalse: [self reposition]].
+        self currentWorld displayWorld.!
-                        ifFalse: [self reposition]]!

Carpe Squeak!