Smalltalk › Squeak › Squeak - Dev

The Inbox: Morphic-dtl.1396.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Inbox: Morphic-dtl.1396.mcz

David T. Lewis uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-dtl.1396.mcz

==================== Summary ====================

Name: Morphic-dtl.1396
Author: dtl
Time: 18 February 2018, 4:53:20.499469 pm
UUID: 19d166b4-6992-40eb-b115-f0d605c9307b
Ancestors: Morphic-dtl.1395

For world-in-world uses such as a Worldlet, displayWorld should act upon the outermost containing world morph. Restore this behavior by un-deprecating PasteUpMorph>>privateOuterDisplayWorld and updating its implementation to match the current PasteUpMorph>>displayWorld, then reverting to the original version of PasteUpMorph>>displayWorld, which sends privateOuterDisplayWorld to the outermost world morph (which usually is self).

See discussion in [squeak-dev] Event Theatre in Object Catalog sparks DNU in 6.0-trunk

=============== Diff against Morphic-dtl.1395 ===============

Item was changed:
----- Method: PasteUpMorph>>displayWorld (in category 'world state') -----
displayWorld

+ self outermostWorldMorph privateOuterDisplayWorld
+ !
- (self valueOfProperty: #shouldDisplayWorld ifAbsent: [true])
- ifTrue: [worldState displayWorld: self submorphs: submorphs].!

Item was added:
+ ----- Method: PasteUpMorph>>privateOuterDisplayWorld (in category 'world state') -----
+ privateOuterDisplayWorld
+
+ (self valueOfProperty: #shouldDisplayWorld ifAbsent: [true])
+ ifTrue: [worldState displayWorld: self submorphs: submorphs].!

David T. Lewis

Re: The Inbox: Morphic-dtl.1396.mcz

I put this in the inbox in case any discussion is needed. If no objections
I will move it to trunk, and also update the 51Deprecated package to match.

Background is in the "Event Theatre in Object Catalog sparks DNU in 6.0-trunk"
thread.

Dave

On Sun, Feb 18, 2018 at 09:53:25PM +0000, [hidden email] wrote:

> David T. Lewis uploaded a new version of Morphic to project The Inbox:
> http://source.squeak.org/inbox/Morphic-dtl.1396.mcz
>
> ==================== Summary ====================
>
> Name: Morphic-dtl.1396
> Author: dtl
> Time: 18 February 2018, 4:53:20.499469 pm
> UUID: 19d166b4-6992-40eb-b115-f0d605c9307b
> Ancestors: Morphic-dtl.1395
>
> For world-in-world uses such as a Worldlet, displayWorld should act upon the outermost containing world morph. Restore this behavior by un-deprecating PasteUpMorph>>privateOuterDisplayWorld and updating its implementation to match the current PasteUpMorph>>displayWorld, then reverting to the original version of PasteUpMorph>>displayWorld, which sends privateOuterDisplayWorld to the outermost world morph (which usually is self).
>
> See discussion in [squeak-dev] Event Theatre in Object Catalog sparks DNU in 6.0-trunk
>
> =============== Diff against Morphic-dtl.1395 ===============
>
> Item was changed:
> ----- Method: PasteUpMorph>>displayWorld (in category 'world state') -----
> displayWorld
>
> + self outermostWorldMorph privateOuterDisplayWorld
> + !
> - (self valueOfProperty: #shouldDisplayWorld ifAbsent: [true])
> - ifTrue: [worldState displayWorld: self submorphs: submorphs].!
>
> Item was added:
> + ----- Method: PasteUpMorph>>privateOuterDisplayWorld (in category 'world state') -----
> + privateOuterDisplayWorld
> +
> + (self valueOfProperty: #shouldDisplayWorld ifAbsent: [true])
> + ifTrue: [worldState displayWorld: self submorphs: submorphs].!
>
>