The Inbox: Morphic-fbs.716.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Morphic-fbs.716.mcz

commits-2
A new version of Morphic was added to project The Inbox:
http://source.squeak.org/inbox/Morphic-fbs.716.mcz

==================== Summary ====================

Name: Morphic-fbs.716
Author: fbs
Time: 18 January 2014, 2:22:54.751 pm
UUID: 16ecb9a0-e390-c540-a5e0-21da7485aac7
Ancestors: Morphic-fbs.715

Sean DeNigris' bugfix from 2014/01/15:

KeyboardEvent is not storing the event position. If you record keyboard events via EventRecorderMorph, writeTape and then readTape back in, error windows will pop up for each played keyboard event.

=============== Diff against Morphic-fbs.715 ===============

Item was changed:
  ----- Method: KeyboardEvent>>storeOn: (in category 'printing') -----
  storeOn: aStream
 
  aStream nextPutAll: type.
  aStream space.
  self timeStamp storeOn: aStream.
  aStream space.
+ position x asInteger storeOn: aStream.
+ aStream space.
+ position y asInteger storeOn: aStream.
+ aStream space.
  buttons storeOn: aStream.
  aStream space.
+ keyValue storeOn: aStream.!
- keyValue storeOn: aStream.
- !

Item was changed:
  ----- Method: KeyboardEvent>>type:readFrom: (in category 'initialize') -----
  type: eventType readFrom: aStream
+ | x y |
  type := eventType.
  timeStamp := Integer readFrom: aStream.
  aStream skip: 1.
+
+ x := Integer readFrom: aStream.
+ aStream skip: 1.
+ y := Integer readFrom: aStream.
+ aStream skip: 1.
+ position := x@y.
+
  buttons := Integer readFrom: aStream.
  aStream skip: 1.
  keyValue := Integer readFrom: aStream.!

Item was removed:
- PluggableSystemWindow subclass: #PluggableSystemWindowWithLabelButton
- instanceVariableNames: 'labelButton'
- classVariableNames: ''
- poolDictionaries: ''
- category: 'Morphic-Windows'!
-
- !PluggableSystemWindowWithLabelButton commentStamp: 'eem 6/29/2010 19:02' prior: 0!
- A PluggableSystemWindowWithLabelButton provides the pull-down menu of browser panes in the multi-pane browser.
-
- Instance Variables
- labelButton: <BrowserPaneButtonMorph>
-
- labelButton
- - the labelButton is a hack to hold onto the panes of a multi-paned browser so that an inst var doesn't have to be added to the Browser hierarchy.
- !

Item was removed:
- ----- Method: PluggableSystemWindowWithLabelButton>>adjustExtraButton (in category 'resize/collapse') -----
- adjustExtraButton
- labelButton ifNil: [^self].
- labelButton
- position: self innerBounds topLeft + (20 @ -3);
- extent: self innerBounds extent * (0.4@1)!

Item was removed:
- ----- Method: PluggableSystemWindowWithLabelButton>>extent: (in category 'geometry') -----
- extent: newExtent
- super extent: newExtent.
- self adjustExtraButton!

Item was removed:
- ----- Method: PluggableSystemWindowWithLabelButton>>savedMultiWindowState: (in category 'accessing') -----
- savedMultiWindowState: aSavedMultiWindowState
- labelButton := MultiWindowLabelButtonMorph
- on: aSavedMultiWindowState
- getState: nil
- action: #selectWindowsMenu.
- labelButton
- triggerOnMouseDown: true;
- savedMultiWindowState: aSavedMultiWindowState.
- labelButton
- layoutFrame: (LayoutFrame "i.e. in the left 40% of the title bar"
- fractions: (0@0 corner: 0.4@0)
- offsets: (20@ -20 corner: 0@0));
- hResizing: #spaceFill;
- vResizing: #spaceFill.
- self addMorphFront: labelButton.
- self adjustExtraButton!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Morphic-fbs.716.mcz

Frank Shearar-3
On 18 January 2014 17:05,  <[hidden email]> wrote:
> Frank Shearar uploaded a new version of Morphic to project The Inbox:
> http://source.squeak.org/inbox/Morphic-fbs.716.mcz

The apparent duplicate mail is from me moving Sean's fix from the
Treated Inbox back to the Inbox.

frank