Merlin de la Haye uploaded a new version of Morphic to project The Inbox:
http://source.squeak.org/inbox/Morphic-mdlh.1297.mcz ==================== Summary ==================== Name: Morphic-mdlh.1297 Author: mdlh Time: 29 December 2016, 11:46:25.676308 am UUID: b2c44cf8-e058-dd49-a748-161548b2da23 Ancestors: Morphic-mt.1296 corrected typo in description text (amout -> amount) =============== Diff against Morphic-mt.1296 =============== Item was changed: ----- Method: PluggableTextMorph class>>visualWrapBorder (in category 'preferences') ----- visualWrapBorder <preference: 'Show wrap border in code panes.' categoryList: #(editing visuals performance) + description: 'Show a visual border after a specific amount of characters. Makes sense for monospaced fonts.' - description: 'Show a visual border after a specific amout of characters. Makes sense for monospaced fonts.' type: #Boolean> ^ VisualWrapBorder ifNil: [false]! Item was changed: ----- Method: ScrollBar>>scrollPageInit: (in category 'scrolling') ----- scrollPageInit: evt evt redButtonPressed ifFalse: [^ self]. self resetTimer. self setNextDirectionFromEvent: evt. self scrollBarAction: #doScrollByPage. self startStepping.! Item was changed: ----- Method: TheWorldMainDockingBar>>listWindowsOn: (in category 'submenu - windows') ----- listWindowsOn: menu | windows | windows := self allVisibleWindows sorted: [:winA :winB | ((winA model isNil or: [winB model isNil]) or: [winA model name = winB model name]) ifTrue: [winA label < winB label] ifFalse: [winA model name < winB model name]]. windows ifEmpty: [ menu addItem: [ :item | item contents: 'No Windows' translated; isEnabled: false ] ]. windows do: [ :each | menu addItem: [ :item | item contents: (self windowMenuItemLabelFor: each); + icon: ((each model respondsTo: #windowColorToUse) + ifTrue: [self colorIcon: each model windowColorToUse] + ifFalse: [self colorIcon: each color]); - icon: (each model ifNotNil: [self colorIcon: each model windowColorToUse]); target: each; selector: #comeToFront; subMenuUpdater: self selector: #windowMenuFor:on: arguments: { each }; action: [ each beKeyWindow; expand ] ] ]. menu addLine; add: 'Close all windows' target: self selector: #closeAllWindowsUnsafe; addItem: [:item | item contents: 'Close all windows without changes'; target: self; icon: MenuIcons smallBroomIcon; selector: #closeAllWindows]; add: 'Close all windows but workspaces' target: self selector: #closeAllWindowsButWorkspaces.! |
On Wed, 11 Jan 2017 09:31:43 0000, [hidden email]
<[hidden email]> wrote: > Merlin de la Haye uploaded a new version of Morphic to project The Inbox: > http://source.squeak.org/inbox/Morphic-mdlh.1297.mcz > > ==================== Summary ==================== > > Name: Morphic-mdlh.1297 > Author: mdlh > Time: 29 December 2016, 11:46:25.676308 am > UUID: b2c44cf8-e058-dd49-a748-161548b2da23 > Ancestors: Morphic-mt.1296 > > corrected typo in description text (amout -> amount) > > =============== Diff against Morphic-mt.1296 =============== > > Item was changed: > ----- Method: PluggableTextMorph class>>visualWrapBorder (in category > 'preferences') ----- > visualWrapBorder > <preference: 'Show wrap border in code panes.' > categoryList: #(editing visuals performance) > + description: 'Show a visual border after a specific amount of > characters. Makes sense for monospaced fonts.' > - description: 'Show a visual border after a specific amout of characters. > Makes sense for monospaced fonts.' > type: #Boolean> > ^ VisualWrapBorder ifNil: [false]! > > Item was changed: > ----- Method: ScrollBar>>scrollPageInit: (in category 'scrolling') ----- > scrollPageInit: evt > > evt redButtonPressed ifFalse: [^ self]. > > self resetTimer. > self setNextDirectionFromEvent: evt. > self scrollBarAction: #doScrollByPage. > self startStepping.! > > Item was changed: > ----- Method: TheWorldMainDockingBar>>listWindowsOn: (in category 'submenu > - windows') ----- > listWindowsOn: menu > > | windows | > windows := self allVisibleWindows sorted: [:winA :winB | > ((winA model isNil or: [winB model isNil]) or: [winA model name = winB > model name]) > ifTrue: [winA label < winB label] > ifFalse: [winA model name < winB model name]]. > windows ifEmpty: [ > menu addItem: [ :item | > item > contents: 'No Windows' translated; > isEnabled: false ] ]. > windows do: [ :each | > menu addItem: [ :item | > item > contents: (self windowMenuItemLabelFor: each); > + icon: ((each model respondsTo: #windowColorToUse) > + ifTrue: [self colorIcon: each model windowColorToUse] > + ifFalse: [self colorIcon: each color]); > - icon: (each model ifNotNil: [self colorIcon: each model > windowColorToUse]); What is the intent of this change? > target: each; > selector: #comeToFront; > subMenuUpdater: self > selector: #windowMenuFor:on: > arguments: { each }; > action: [ each beKeyWindow; expand ] ] ]. > menu > addLine; > add: 'Close all windows' target: self selector: #closeAllWindowsUnsafe; > addItem: [:item | item > contents: 'Close all windows without changes'; > target: self; > icon: MenuIcons smallBroomIcon; > selector: #closeAllWindows]; > add: 'Close all windows but workspaces' target: self selector: > #closeAllWindowsButWorkspaces.! > > > |
Hi Hannes,
I have talked to Merlin and this commit is only a small fix of a typo in a preference. The other changes where included by accident. I cleaned up the commit and merged it already, so this commit is not relevant anymore. Maybe this is a good time to ask how to delete commits from the inbox :) Bests Patrick ________________________________________ From: Squeak-dev <[hidden email]> on behalf of H. Hirzel <[hidden email]> Sent: Thursday, February 23, 2017 13:38 To: [hidden email] Subject: Re: [squeak-dev] The Inbox: Morphic-mdlh.1297.mcz On Wed, 11 Jan 2017 09:31:43 0000, [hidden email] <[hidden email]> wrote: > Merlin de la Haye uploaded a new version of Morphic to project The Inbox: > http://source.squeak.org/inbox/Morphic-mdlh.1297.mcz > > ==================== Summary ==================== > > Name: Morphic-mdlh.1297 > Author: mdlh > Time: 29 December 2016, 11:46:25.676308 am > UUID: b2c44cf8-e058-dd49-a748-161548b2da23 > Ancestors: Morphic-mt.1296 > > corrected typo in description text (amout -> amount) > > =============== Diff against Morphic-mt.1296 =============== > > Item was changed: > ----- Method: PluggableTextMorph class>>visualWrapBorder (in category > 'preferences') ----- > visualWrapBorder > <preference: 'Show wrap border in code panes.' > categoryList: #(editing visuals performance) > + description: 'Show a visual border after a specific amount of > characters. Makes sense for monospaced fonts.' > - description: 'Show a visual border after a specific amout of characters. > Makes sense for monospaced fonts.' > type: #Boolean> > ^ VisualWrapBorder ifNil: [false]! > > Item was changed: > ----- Method: ScrollBar>>scrollPageInit: (in category 'scrolling') ----- > scrollPageInit: evt > > evt redButtonPressed ifFalse: [^ self]. > > self resetTimer. > self setNextDirectionFromEvent: evt. > self scrollBarAction: #doScrollByPage. > self startStepping.! > > Item was changed: > ----- Method: TheWorldMainDockingBar>>listWindowsOn: (in category 'submenu > - windows') ----- > listWindowsOn: menu > > | windows | > windows := self allVisibleWindows sorted: [:winA :winB | > ((winA model isNil or: [winB model isNil]) or: [winA model name = winB > model name]) > ifTrue: [winA label < winB label] > ifFalse: [winA model name < winB model name]]. > windows ifEmpty: [ > menu addItem: [ :item | > item > contents: 'No Windows' translated; > isEnabled: false ] ]. > windows do: [ :each | > menu addItem: [ :item | > item > contents: (self windowMenuItemLabelFor: each); > + icon: ((each model respondsTo: #windowColorToUse) > + ifTrue: [self colorIcon: each model windowColorToUse] > + ifFalse: [self colorIcon: each color]); > - icon: (each model ifNotNil: [self colorIcon: each model > windowColorToUse]); What is the intent of this change? > target: each; > selector: #comeToFront; > subMenuUpdater: self > selector: #windowMenuFor:on: > arguments: { each }; > action: [ each beKeyWindow; expand ] ] ]. > menu > addLine; > add: 'Close all windows' target: self selector: #closeAllWindowsUnsafe; > addItem: [:item | item > contents: 'Close all windows without changes'; > target: self; > icon: MenuIcons smallBroomIcon; > selector: #closeAllWindows]; > add: 'Close all windows but workspaces' target: self selector: > #closeAllWindowsButWorkspaces.! > > > |
Free forum by Nabble | Edit this page |