The Inbox: Network-topa.71.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Network-topa.71.mcz

commits-2
A new version of Network was added to project The Inbox:
http://source.squeak.org/inbox/Network-topa.71.mcz

==================== Summary ====================

Name: Network-topa.71
Author: topa
Time: 5 May 2010, 1:52:54.504 pm
UUID: dcf51858-a556-48ce-83ff-43f393284a39
Ancestors: Network-topa.70

Allow for Urls that might contain passwords/usernames with
"dangerous" characters. This is consitent with RFC 1738

=============== Diff against Network-topa.70 ===============

Item was changed:
  ----- Method: HierarchicalUrl>>printOn: (in category 'printing') -----
  printOn: aStream
 
  aStream nextPutAll: self schemeName.
  aStream nextPutAll: '://'.
  self username ifNotNil: [
+ aStream nextPutAll: self username encodeForHTTP.
- aStream nextPutAll: self username.
  self password ifNotNil: [
  aStream nextPutAll: ':'.
+ aStream nextPutAll: self password encodeForHTTP].
- aStream nextPutAll: self password ].
  aStream nextPutAll: '@' ].
  aStream nextPutAll: self authority.
  port ifNotNil: [aStream nextPut: $:; print: port].
  path do: [ :pathElem |
  aStream nextPut: $/.
  aStream nextPutAll: pathElem encodeForHTTP. ].
  self query isNil ifFalse: [
  aStream nextPut: $?.
  aStream nextPutAll: self query. ].
  self fragment isNil ifFalse: [
  aStream nextPut: $#.
  aStream nextPutAll: self fragment encodeForHTTP. ].!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: Network-topa.71.mcz

Tobias Pape
Hello.

I'd like to see this small fix (combined with topa.70; and the according
tests) in the trunk. Any obstacles?

So Long,
        -Tobias

Am 2010-05-05 um 11:52 schrieb [hidden email]:

> A new version of Network was added to project The Inbox:
> http://source.squeak.org/inbox/Network-topa.71.mcz
>
> ==================== Summary ====================
>
> Name: Network-topa.71
> Author: topa
> Time: 5 May 2010, 1:52:54.504 pm
> UUID: dcf51858-a556-48ce-83ff-43f393284a39
> Ancestors: Network-topa.70
>
> Allow for Urls that might contain passwords/usernames with
> "dangerous" characters. This is consitent with RFC 1738
>
> =============== Diff against Network-topa.70 ===============
>
> Item was changed:
>  ----- Method: HierarchicalUrl>>printOn: (in category 'printing') -----
>  printOn: aStream
>
>   aStream nextPutAll: self schemeName.
>   aStream nextPutAll: '://'.
>   self username ifNotNil: [
> + aStream nextPutAll: self username encodeForHTTP.
> - aStream nextPutAll: self username.
>   self password ifNotNil: [
>   aStream nextPutAll: ':'.
> + aStream nextPutAll: self password encodeForHTTP].
> - aStream nextPutAll: self password ].
>   aStream nextPutAll: '@' ].
>   aStream nextPutAll: self authority.
>   port ifNotNil: [aStream nextPut: $:; print: port].
>   path do: [ :pathElem |
>   aStream nextPut: $/.
>   aStream nextPutAll: pathElem encodeForHTTP. ].
>   self query isNil ifFalse: [
>   aStream nextPut: $?.
>   aStream nextPutAll: self query. ].
>   self fragment isNil ifFalse: [
>   aStream nextPut: $#.
>   aStream nextPutAll: self fragment encodeForHTTP. ].!
>