The Inbox: NetworkTests-dtl.28.mcz

A new version of NetworkTests was added to project The Inbox:
http://source.squeak.org/inbox/NetworkTests-dtl.28.mcz

==================== Summary ====================

Name: NetworkTests-dtl.28
Author: dtl
Time: 4 June 2012, 10:21:54.325 pm
UUID: a0572f7a-ba1b-494e-9ed5-6c25a69ec89a
Ancestors: NetworkTests-ul.27

Unit test updates to accompany Network-dtl.123

Minor updates to accommodate SocketAddress versus ByteArray usage.

Provide SocketTestOldNetwork and SocketStreamTestOldNetwork to exercise SocketTest and SocketStreamTest with the NetNameResolver set in UseOldNetwork mode.

=============== Diff against NetworkTests-ul.27 ===============

Item was added:
+ SocketStreamTest subclass: #SocketStreamTestOldNetwork
+ instanceVariableNames: 'originalSetting'
+ classVariableNames: ''
+ poolDictionaries: ''
+ category: 'NetworkTests-Kernel'!
+
+ !SocketStreamTestOldNetwork commentStamp: 'dtl 6/4/2012 21:14' prior: 0!
+ Run the SocketStreamTest tests with NetNameResolver set to use old network protocol. This is intended to verify some degree of backward compatibility. These tests should be eliminated when the UseOldNetwork class variable is eliminated from NetNameResolver. !

Item was added:
+ ----- Method: SocketStreamTestOldNetwork>>setUp (in category 'running') -----
+ setUp
+
+ originalSetting := NetNameResolver useOldNetwork.
+ NetNameResolver useOldNetwork: true.
+ super setUp
+ !

Item was added:
+ ----- Method: SocketStreamTestOldNetwork>>targetClass (in category 'running') -----
+ targetClass
+ ^self class!

Item was added:
+ ----- Method: SocketStreamTestOldNetwork>>tearDown (in category 'running') -----
+ tearDown
+
+ super tearDown.
+ NetNameResolver useOldNetwork: originalSetting
+ !

Item was changed:
  ----- Method: SocketTest>>testRemoteAddress (in category 'tests') -----
  testRemoteAddress
  "Tests the various remoteAddress values for sockets"
 
  self testServerAccept.
+ self assert: listenerSocket remoteAddress asByteArray = #[0 0 0 0].
- self assert: listenerSocket remoteAddress = #[0 0 0 0].
  self assert: clientSocket remoteAddress = self listenerAddress.
  self assert: serverSocket remoteAddress = self listenerAddress.
  !

Item was added:
+ SocketTest subclass: #SocketTestOldNetwork
+ instanceVariableNames: 'originalSetting'
+ classVariableNames: ''
+ poolDictionaries: ''
+ category: 'NetworkTests-Kernel'!
+
+ !SocketTestOldNetwork commentStamp: 'dtl 6/4/2012 21:14' prior: 0!
+ Run the SocketTest tests with NetNameResolver set to use old network protocol. This is intended to verify some degree of backward compatibility. These tests should be eliminated when the UseOldNetwork class variable is eliminated from NetNameResolver. !

Item was added:
+ ----- Method: SocketTestOldNetwork>>setUp (in category 'running') -----
+ setUp
+
+ originalSetting := NetNameResolver useOldNetwork.
+ NetNameResolver useOldNetwork: true.
+ super setUp
+ !

Item was added:
+ ----- Method: SocketTestOldNetwork>>tearDown (in category 'running') -----
+ tearDown
+
+ super tearDown.
+ NetNameResolver useOldNetwork: originalSetting
+ !