The Inbox: PreferenceBrowser-kfr.58.mcz

A new version of PreferenceBrowser was added to project The Inbox:
http://source.squeak.org/inbox/PreferenceBrowser-kfr.58.mcz

==================== Summary ====================

Name: PreferenceBrowser-kfr.58
Author: kfr
Time: 3 January 2016, 6:13:14.444 pm
UUID: e5f58d19-2c9a-4e05-b58d-0b7ade0be73f
Ancestors: PreferenceBrowser-kfr.57

Fix for updating color when using the NewColorPickerMorph

=============== Diff against PreferenceBrowser-kfr.57 ===============

Item was changed:
  ----- Method: PBColorPreferenceView>>changeColor: (in category 'user interface') -----
  changeColor: aButton
+ NewColorPickerMorph useIt
+ ifTrue:
+ [ (NewColorPickerMorph
+ on: self
+ originalColor: aButton color
+ setColorSelector: #setButtonColor:) openNear: aButton fullBoundsInWorld ]
+ ifFalse:
+ [ ColorPickerMorph new
+ choseModalityFromPreference ;
+ sourceHand: aButton activeHand ;
+ target: self ;
+ selector: #setButtonColor: ;
+ originalColor: aButton color ;
+
+ putUpFor: aButton
+ near: aButton fullBoundsInWorld ] !
- aButton changeColor.
- self preference preferenceValue: aButton fillStyle.
- button label: self preference preferenceValue asString.
- self adjustLabelColor !

Item was added:
+ ----- Method: PBColorPreferenceView>>setButtonColor: (in category 'user interface') -----
+ setButtonColor: aColor
+ button color: aColor.
+ self preference preferenceValue: aColor.
+ button label: self preference preferenceValue asString.
+ self adjustLabelColor
+ !

Uh, nice. You did not have to adapt the color picker for that?

Best,
Marcel

> But as for changes to NewColorPickerMorph:
>
> I think the color picker need a cancel button

-1.  Maybe an "Undo" or "Previous Color" button, but not a Cancel
button.  Morphic is supposed to be in-place manipulation.

> And ability to pick up colors from outside the color picker

+1