The Inbox: ReleaseBuilder-cmm.105.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: ReleaseBuilder-cmm.105.mcz

commits-2
A new version of ReleaseBuilder was added to project The Inbox:
http://source.squeak.org/inbox/ReleaseBuilder-cmm.105.mcz

==================== Summary ====================

Name: ReleaseBuilder-cmm.105
Author: cmm
Time: 31 December 2013, 4:27:44.493 pm
UUID: 0bae46e0-1d72-49c3-830c-5dc2fa2b4958
Ancestors: ReleaseBuilder-cmm.104

Please let all internal image work and modifications for building our releases be delegated to ReleaseBuilder.

=============== Diff against ReleaseBuilder-cmm.104 ===============

Item was changed:
  ----- Method: ReleaseBuilder class>>prepareNewBuild: (in category 'scripts') -----
  prepareNewBuild: anMCRepository
  "ReleaseBuilderTrunk prepareNewBuild"
  "Prepare everything that should be done for a new image build"
+ MCMcmUpdater updateMissingPackages: true.
+ MCMcmUpdater enableUpdatesForAllPackages.
+ Workspace allInstances do: [ : each | each topView delete].
+ MorphicProject initialize.
  TTCFont registerAll.
  RealEstateAgent standardSize: 600@400.
  SystemVersion newVersion: self versionString.
  SMLoaderPlus
  setDefaultFilters: (OrderedCollection with: #filterSafelyAvailable).
  self setDisplayExtent: 800 @ 600;
  setPreferences;
  switchToNewRepository: anMCRepository;
  openWelcomeWorkspaces.
  self cleanPackages.
  Smalltalk cleanUp: true.
  Undeclared removeUnreferencedKeys.
  Smalltalk garbageCollect.
  self loadWellKnownPackages.
  Compiler recompileAll.!


Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: ReleaseBuilder-cmm.105.mcz

Frank Shearar-3
On 31 December 2013 22:27,  <[hidden email]> wrote:

> A new version of ReleaseBuilder was added to project The Inbox:
> http://source.squeak.org/inbox/ReleaseBuilder-cmm.105.mcz
>
> ==================== Summary ====================
>
> Name: ReleaseBuilder-cmm.105
> Author: cmm
> Time: 31 December 2013, 4:27:44.493 pm
> UUID: 0bae46e0-1d72-49c3-830c-5dc2fa2b4958
> Ancestors: ReleaseBuilder-cmm.104
>
> Please let all internal image work and modifications for building our releases be delegated to ReleaseBuilder.
>
> =============== Diff against ReleaseBuilder-cmm.104 ===============
>
> Item was changed:
>   ----- Method: ReleaseBuilder class>>prepareNewBuild: (in category 'scripts') -----
>   prepareNewBuild: anMCRepository
>         "ReleaseBuilderTrunk prepareNewBuild"
>         "Prepare everything that should be done for a new image build"
> +       MCMcmUpdater updateMissingPackages: true.
> +       MCMcmUpdater enableUpdatesForAllPackages.
> +       Workspace allInstances do: [ : each | each topView delete].

Duly removed from squeak-ci's release.st.

> +       MorphicProject initialize.

Why? I guess to set the background from MorphicProject class >>
#defaultBackgroundForm. Why store an image in a string inside the
image? It looks like you're jumping through hoops just to avoid
touching anything outside the image.

(release.st pulls in the image from the squeak-ci repository. The
image is currently this guy -
https://github.com/squeak-smalltalk/squeak-ci/blob/de815b8722284e8095c0ed35ee29606f9c19dbd8/resources/wallpaper.png)

frank

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: ReleaseBuilder-cmm.105.mcz

Chris Muller-3
On Tue, Dec 31, 2013 at 5:13 PM, Frank Shearar <[hidden email]> wrote:

> On 31 December 2013 22:27,  <[hidden email]> wrote:
>> A new version of ReleaseBuilder was added to project The Inbox:
>> http://source.squeak.org/inbox/ReleaseBuilder-cmm.105.mcz
>>
>> ==================== Summary ====================
>>
>> Name: ReleaseBuilder-cmm.105
>> Author: cmm
>> Time: 31 December 2013, 4:27:44.493 pm
>> UUID: 0bae46e0-1d72-49c3-830c-5dc2fa2b4958
>> Ancestors: ReleaseBuilder-cmm.104
>>
>> Please let all internal image work and modifications for building our releases be delegated to ReleaseBuilder.
>>
>> =============== Diff against ReleaseBuilder-cmm.104 ===============
>>
>> Item was changed:
>>   ----- Method: ReleaseBuilder class>>prepareNewBuild: (in category 'scripts') -----
>>   prepareNewBuild: anMCRepository
>>         "ReleaseBuilderTrunk prepareNewBuild"
>>         "Prepare everything that should be done for a new image build"
>> +       MCMcmUpdater updateMissingPackages: true.
>> +       MCMcmUpdater enableUpdatesForAllPackages.
>> +       Workspace allInstances do: [ : each | each topView delete].
>
> Duly removed from squeak-ci's release.st.
>
>> +       MorphicProject initialize.
>
> Why? I guess to set the background from MorphicProject class >>
> #defaultBackgroundForm.

Yes.

> Why store an image in a string inside the
> image?

Well, this is a separate discussion which Nicolas also recently asked.
 Background and icon data represented in big String literals is
nothing new and everyone recognizes its an undesirable redundancy;
something we should talk about eliminating in 4.6.

Let's just stay with the old way for 4.5 so we can get it done and
everyone can see where the release background comes from.  Notice I've
at least refreshed the form with one that is a lot smaller than the
old one.

> It looks like you're jumping through hoops just to avoid
> touching anything outside the image.

No.

> (release.st pulls in the image from the squeak-ci repository. The
> image is currently this guy -
> https://github.com/squeak-smalltalk/squeak-ci/blob/de815b8722284e8095c0ed35ee29606f9c19dbd8/resources/wallpaper.png)
>
> frank
>

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: ReleaseBuilder-cmm.105.mcz

Frank Shearar-3
On 31 December 2013 23:49, Chris Muller <[hidden email]> wrote:

> On Tue, Dec 31, 2013 at 5:13 PM, Frank Shearar <[hidden email]> wrote:
>> On 31 December 2013 22:27,  <[hidden email]> wrote:
>>> A new version of ReleaseBuilder was added to project The Inbox:
>>> http://source.squeak.org/inbox/ReleaseBuilder-cmm.105.mcz
>>>
>>> ==================== Summary ====================
>>>
>>> Name: ReleaseBuilder-cmm.105
>>> Author: cmm
>>> Time: 31 December 2013, 4:27:44.493 pm
>>> UUID: 0bae46e0-1d72-49c3-830c-5dc2fa2b4958
>>> Ancestors: ReleaseBuilder-cmm.104
>>>
>>> Please let all internal image work and modifications for building our releases be delegated to ReleaseBuilder.
>>>
>>> =============== Diff against ReleaseBuilder-cmm.104 ===============
>>>
>>> Item was changed:
>>>   ----- Method: ReleaseBuilder class>>prepareNewBuild: (in category 'scripts') -----
>>>   prepareNewBuild: anMCRepository
>>>         "ReleaseBuilderTrunk prepareNewBuild"
>>>         "Prepare everything that should be done for a new image build"
>>> +       MCMcmUpdater updateMissingPackages: true.
>>> +       MCMcmUpdater enableUpdatesForAllPackages.
>>> +       Workspace allInstances do: [ : each | each topView delete].
>>
>> Duly removed from squeak-ci's release.st.
>>
>>> +       MorphicProject initialize.
>>
>> Why? I guess to set the background from MorphicProject class >>
>> #defaultBackgroundForm.
>
> Yes.
>
>> Why store an image in a string inside the
>> image?
>
> Well, this is a separate discussion which Nicolas also recently asked.
>  Background and icon data represented in big String literals is
> nothing new and everyone recognizes its an undesirable redundancy;
> something we should talk about eliminating in 4.6.

Fair enough. I was also thinking of Nicolas' experiences.

> Let's just stay with the old way for 4.5 so we can get it done and
> everyone can see where the release background comes from.  Notice I've
> at least refreshed the form with one that is a lot smaller than the
> old one.

Well, it's your release to manage, so it's up to you as to how exactly
you want to run things. I suppose I'm just a bit miffed that you're
not using the process I spent time developing.

>> It looks like you're jumping through hoops just to avoid
>> touching anything outside the image.
>
> No.

OK.

frank

>> (release.st pulls in the image from the squeak-ci repository. The
>> image is currently this guy -
>> https://github.com/squeak-smalltalk/squeak-ci/blob/de815b8722284e8095c0ed35ee29606f9c19dbd8/resources/wallpaper.png)
>>
>> frank
>>
>

Reply | Threaded
Open this post in threaded view
|

Re: The Inbox: ReleaseBuilder-cmm.105.mcz

Frank Shearar-3
On 1 January 2014 14:51, Frank Shearar <[hidden email]> wrote:

> On 31 December 2013 23:49, Chris Muller <[hidden email]> wrote:
>> On Tue, Dec 31, 2013 at 5:13 PM, Frank Shearar <[hidden email]> wrote:
>>> On 31 December 2013 22:27,  <[hidden email]> wrote:
>>>> A new version of ReleaseBuilder was added to project The Inbox:
>>>> http://source.squeak.org/inbox/ReleaseBuilder-cmm.105.mcz
>>>>
>>>> ==================== Summary ====================
>>>>
>>>> Name: ReleaseBuilder-cmm.105
>>>> Author: cmm
>>>> Time: 31 December 2013, 4:27:44.493 pm
>>>> UUID: 0bae46e0-1d72-49c3-830c-5dc2fa2b4958
>>>> Ancestors: ReleaseBuilder-cmm.104
>>>>
>>>> Please let all internal image work and modifications for building our releases be delegated to ReleaseBuilder.
>>>>
>>>> =============== Diff against ReleaseBuilder-cmm.104 ===============
>>>>
>>>> Item was changed:
>>>>   ----- Method: ReleaseBuilder class>>prepareNewBuild: (in category 'scripts') -----
>>>>   prepareNewBuild: anMCRepository
>>>>         "ReleaseBuilderTrunk prepareNewBuild"
>>>>         "Prepare everything that should be done for a new image build"
>>>> +       MCMcmUpdater updateMissingPackages: true.
>>>> +       MCMcmUpdater enableUpdatesForAllPackages.
>>>> +       Workspace allInstances do: [ : each | each topView delete].
>>>
>>> Duly removed from squeak-ci's release.st.
>>>
>>>> +       MorphicProject initialize.
>>>
>>> Why? I guess to set the background from MorphicProject class >>
>>> #defaultBackgroundForm.
>>
>> Yes.
>>
>>> Why store an image in a string inside the
>>> image?
>>
>> Well, this is a separate discussion which Nicolas also recently asked.
>>  Background and icon data represented in big String literals is
>> nothing new and everyone recognizes its an undesirable redundancy;
>> something we should talk about eliminating in 4.6.
>
> Fair enough. I was also thinking of Nicolas' experiences.
>
>> Let's just stay with the old way for 4.5 so we can get it done and
>> everyone can see where the release background comes from.  Notice I've
>> at least refreshed the form with one that is a lot smaller than the
>> old one.
>
> Well, it's your release to manage, so it's up to you as to how exactly
> you want to run things. I suppose I'm just a bit miffed that you're
> not using the process I spent time developing.
>
>>> It looks like you're jumping through hoops just to avoid
>>> touching anything outside the image.
>>
>> No.
>
> OK.

So, er, I hadn't noticed that this was just an Inbox submission. I'm
happy for it to go into Trunk. Despite my desire to be able to run
scripts that are stored outside the image, Chris' changes are entirely
sensible.

frank