The Inbox: SMBase-dtl.131.mcz

> A new version of SMBase was added to project The Inbox:
> http://source.squeak.org/inbox/SMBase-dtl.131.mcz
>
> ==================== Summary ====================
>
> Name: SMBase-dtl.131
> Author: dtl
> Time: 16 December 2012, 6:04:50.573 pm
> UUID: 688798d6-12c7-4c6d-8cca-1f6539b446d8
> Ancestors: SMBase-cmm.130
>
> SqueakMap does not consider 'Squeak 4.4' and 'Squeak4.4' to be the same version, but it probably should do so. Remove spaces from the version string compare.
>
> =============== Diff against SMBase-cmm.130 ===============
>
> Item was changed:
>   ----- Method: SMPackageRelease>>isCompatibleWithCurrentSystemVersion (in category 'testing') -----
>   isCompatibleWithCurrentSystemVersion
>   "Return true if this release is listed as being compatible with the SystemVersion of the current image.  Only checks major/minor version number; does not differentiate between alpha/beta/gamma releases.  Checks version categories of both the SMPackageRelease and the parent SMPackage."
>  
>   | current |
> + current := (self majorMinorVersionFrom: SystemVersion current version)
> + copyWithout: Character space.
> - current := self majorMinorVersionFrom: SystemVersion current version.
>   self categories, self package categories do: [:c |
>   ((c parent name = 'Squeak versions') and: [
> + ((self majorMinorVersionFrom: c name)
> + copyWithout: Character space) = current])
> + ifTrue: [^true]].
> - (self majorMinorVersionFrom: c name) = current])
> - ifTrue: [^true]].
>   ^ false
> + !
> -
> - " ^ (self categories, self package categories
> - detect:
> - [:cat | (cat parent name = 'Squeak versions')
> - and: [(SystemVersion new version: cat name) majorMinorVersion = SystemVersion current majorMinorVersion]]
> - ifNone: []) notNil
> - "!
>

> I don't know my way around the SqueakMap code, so I put this in the
> inbox. This is intended to make the SqueakMap package loader recognize
> packages tagged as 'Squeak 4.4' as being compatible with Squeak
> system version 'Squeak4.4'.
>
> Dave
>
> On Sun, Dec 16, 2012 at 11:04:53PM +0000, [hidden email] wrote:
>> A new version of SMBase was added to project The Inbox:
>> http://source.squeak.org/inbox/SMBase-dtl.131.mcz
>>
>> ==================== Summary ====================
>>
>> Name: SMBase-dtl.131
>> Author: dtl
>> Time: 16 December 2012, 6:04:50.573 pm
>> UUID: 688798d6-12c7-4c6d-8cca-1f6539b446d8
>> Ancestors: SMBase-cmm.130
>>
>> SqueakMap does not consider 'Squeak 4.4' and 'Squeak4.4' to be the same version, but it probably should do so. Remove spaces from the version string compare.
>>
>> =============== Diff against SMBase-cmm.130 ===============
>>
>> Item was changed:
>>   ----- Method: SMPackageRelease>>isCompatibleWithCurrentSystemVersion (in category 'testing') -----
>>   isCompatibleWithCurrentSystemVersion
>>       "Return true if this release is listed as being compatible with the SystemVersion of the current image.  Only checks major/minor version number; does not differentiate between alpha/beta/gamma releases.  Checks version categories of both the SMPackageRelease and the parent SMPackage."
>>
>>       | current |
>> +     current := (self majorMinorVersionFrom: SystemVersion current version)
>> +             copyWithout: Character space.
>> -     current := self majorMinorVersionFrom: SystemVersion current version.
>>       self categories, self package categories do: [:c |
>>               ((c parent name = 'Squeak versions') and: [
>> +                     ((self majorMinorVersionFrom: c name)
>> +                             copyWithout: Character space) = current])
>> +                     ifTrue: [^true]].
>> -                     (self majorMinorVersionFrom: c name) = current])
>> -                             ifTrue: [^true]].
>>       ^ false
>> + !
>> -
>> - "   ^ (self categories, self package categories
>> -             detect:
>> -                     [:cat | (cat parent name = 'Squeak versions')
>> -                                     and: [(SystemVersion new version: cat name) majorMinorVersion = SystemVersion current majorMinorVersion]]
>> -             ifNone: []) notNil
>> - "!
>>
>