Smalltalk › Squeak › Squeak - Dev

The Inbox: ST80-ct.263.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

2 messages Options

commits-2

The Inbox: ST80-ct.263.mcz

A new version of ST80 was added to project The Inbox:
http://source.squeak.org/inbox/ST80-ct.263.mcz

==================== Summary ====================

Name: ST80-ct.263
Author: ct
Time: 21 November 2020, 2:33:51.363822 pm
UUID: f3315492-4d28-f24c-971e-260fb9e743dd
Ancestors: ST80-mt.262

Fixes confirmation dialog before closing an MVCProject, which should also show up when closing the current MVCProject. Kind of complements ST80-ct.250, but no strong dependency.

=============== Diff against ST80-mt.262 ===============

Item was changed:
----- Method: MVCProject>>okToChange (in category 'release') -----
okToChange
"If there is no open window, we are fine to close."

+ ^ (self world scheduledControllers size <= 1)
- ^ (self parent ~~ Project current
- or: [self world scheduledControllers size <= 1])
or: [super okToChange]!

Christoph Thiede

Re: The Inbox: ST80-ct.263.mcz

By the way, why are these checks defined in #okToChange and not #okToClose? :-)

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von [hidden email] <[hidden email]>
Gesendet: Samstag, 21. November 2020 14:33:52
An: [hidden email]
Betreff: [squeak-dev] The Inbox: ST80-ct.263.mcz

A new version of ST80 was added to project The Inbox:
http://source.squeak.org/inbox/ST80-ct.263.mcz

==================== Summary ====================

Name: ST80-ct.263
Author: ct
Time: 21 November 2020, 2:33:51.363822 pm
UUID: f3315492-4d28-f24c-971e-260fb9e743dd
Ancestors: ST80-mt.262

Fixes confirmation dialog before closing an MVCProject, which should also show up when closing the current MVCProject. Kind of complements ST80-ct.250, but no strong dependency.

=============== Diff against ST80-mt.262 ===============

Item was changed:
----- Method: MVCProject>>okToChange (in category 'release') -----
okToChange
         "If there is no open window, we are fine to close."

+        ^ (self world scheduledControllers size <= 1)
-        ^ (self parent ~~ Project current
-                or: [self world scheduledControllers size <= 1])
                 or: [super okToChange]!

Carpe Squeak!