The Inbox: SUnit-ct.121.mcz

'tests'?

Am 07.12.2019 22:06:07 schrieb David T. Lewis <[hidden email]>:

Yes, it should be 'tests'.

But don't feel badly about picking the "wrong" category, just have
a look at what all the rest of us have done over the years:

Dictionary withAll: ( { 'testing' . 'Testing' . 'tests' . 'test' }
collect: [ :cat |
cat -> (TestCase withAllSubclasses
select: [ :cls | cls organization categories includes: cat ])]).

Dave


On Sat, Dec 07, 2019 at 08:40:39PM +0000, Thiede, Christoph wrote:
> 'tests'?
>
> ________________________________
> Von: Squeak-dev im Auftrag von Chris Muller
> Gesendet: Samstag, 7. Dezember 2019 21:07:59
> An: squeak dev
> Betreff: Re: [squeak-dev] The Inbox: SUnit-ct.121.mcz
>
> "testing" is for messages that answer booleans. For example, TestCase>>#shouldPass.
>
> The #test... methods should be categorized differently.
>
> - Chris
>
>
> On Sat, Dec 7, 2019 at 8:31 AM <>> wrote:
> A new version of SUnit was added to project The Inbox:
> http://source.squeak.org/inbox/SUnit-ct.121.mcz
>
> ==================== Summary ====================
>
> Name: SUnit-ct.121
> Author: ct
> Time: 7 December 2019, 3:31:28.823146 pm
> UUID: 56da0773-e6ce-8d44-9496-57eea4253f3f
> Ancestors: SUnit-mt.120
>
> Specify default message category for test selectors. Depends on Kernel-mt.1284.
>
> =============== Diff against SUnit-mt.120 ===============
>
> Item was added:
> + ----- Method: TestCase class>>defaultCategoryForSelector: (in category 'organization') -----
> + defaultCategoryForSelector: aSelector
> +
> + aSelector isTestSelector
> + ifTrue: [^ #testing].
> + ^ super defaultCategoryForSelector: aSelector!
>
>

>

Oops, I have always been using this wrong name when writing tests ... Thank you!

I need to know what is easier for you: Should I

a) commit again with this commit as ancestor,

b) commit again with latest Trunk commit as ancestor, or

c) don't commit again at all to reduce noise and you can replace this single selector when merging? :)

Best,

Christoph

Am 08.12.2019 19:44:31 schrieb Thiede, Christoph <[hidden email]>:

Oops, I have always been using this wrong name when writing tests ... Thank you!

I need to know what is easier for you: Should I

a) commit again with this commit as ancestor,

b) commit again with latest Trunk commit as ancestor, or

c) don't commit again at all to reduce noise and you can replace this single selector when merging? :)

Best,

Christoph

---

Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Sonntag, 8. Dezember 2019 15:54:44
An: John Pfersich via Squeak-dev
Betreff: Re: [squeak-dev] The Inbox: SUnit-ct.121.mcz

 

Yes, it must be 'tests' for the tests in test cases. ;-) Not 'testing'.

Best,

Marcel

Am 07.12.2019 22:06:07 schrieb David T. Lewis <[hidden email]>:

Yes, it should be 'tests'.

But don't feel badly about picking the "wrong" category, just have
a look at what all the rest of us have done over the years:

Dictionary withAll: ( { 'testing' . 'Testing' . 'tests' . 'test' }
collect: [ :cat |
cat -> (TestCase withAllSubclasses
select: [ :cls | cls organization categories includes: cat ])]).

Dave


On Sat, Dec 07, 2019 at 08:40:39PM +0000, Thiede, Christoph wrote:
> 'tests'?
>
> ________________________________
> Von: Squeak-dev im Auftrag von Chris Muller
> Gesendet: Samstag, 7. Dezember 2019 21:07:59
> An: squeak dev
> Betreff: Re: [squeak-dev] The Inbox: SUnit-ct.121.mcz
>
> "testing" is for messages that answer booleans. For example, TestCase>>#shouldPass.
>
> The #test... methods should be categorized differently.
>
> - Chris
>
>
> On Sat, Dec 7, 2019 at 8:31 AM <>> wrote:
> A new version of SUnit was added to project The Inbox:
> http://source.squeak.org/inbox/SUnit-ct.121.mcz
>
> ==================== Summary ====================
>
> Name: SUnit-ct.121
> Author: ct
> Time: 7 December 2019, 3:31:28.823146 pm
> UUID: 56da0773-e6ce-8d44-9496-57eea4253f3f
> Ancestors: SUnit-mt.120
>
> Specify default message category for test selectors. Depends on Kernel-mt.1284.
>
> =============== Diff against SUnit-mt.120 ===============
>
> Item was added:
> + ----- Method: TestCase class>>defaultCategoryForSelector: (in category 'organization') -----
> + defaultCategoryForSelector: aSelector
> +
> + aSelector isTestSelector
> + ifTrue: [^ #testing].
> + ^ super defaultCategoryForSelector: aSelector!
>
>

>

Hi Marcel,

you're right, there are few scenarios where you could need #defaultCategoryForSelector:. However, I think TestCase is a good example that would be even worth this change if it was the only implementor. If I remember how often I created a test class in my Squeak life and created the tests category manually ...

We could even say:

Hypothetically, you could even define rules like:

Just some thoughts :)

Best,

Christoph