The Inbox: Sound-ct.67.mcz

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

The Inbox: Sound-ct.67.mcz

commits-2
A new version of Sound was added to project The Inbox:
http://source.squeak.org/inbox/Sound-ct.67.mcz

==================== Summary ====================

Name: Sound-ct.67
Author: ct
Time: 21 September 2019, 5:19:41.362935 pm
UUID: 024cdae7-2879-1343-8e88-b2533bc7377d
Ancestors: Sound-eem.66

Proposal: Ask the user when trying to play a sound while recording

Imagine you opened both a SoundRecorder and a SoundPlayer, maybe even in different spaces/projects. Now as a non-Squeak-Sound-expert, I found it quite irritating to press the "play" button while the recorder was active and just nothing to happen. Why don't ask the user which way he prefers?

=============== Diff against Sound-eem.66 ===============

Item was changed:
  ----- Method: SoundPlayer class>>canStartPlayer (in category 'playing') -----
  canStartPlayer
  "Some platforms do no support simultaneous record and play. If this is one of those platforms, return false if there is a running SoundRecorder."
 
+ (SoundRecorder canRecordWhilePlaying or: [SoundRecorder anyActive not])
+ ifTrue: [^ true].
+ (self confirm: 'Cannot start player as a sound recorder is active.\Stop recording now?' withCRs)
+ ifFalse: [^ false].
+ SoundRecorder stopRecording.
+ ^ true!
- ^SoundRecorder canRecordWhilePlaying
- or: [ SoundRecorder anyActive not]
-
- !