The Inbox: System-akg.994.mcz

Alistair Grant uploaded a new version of System to project The Inbox:
http://source.squeak.org/inbox/System-akg.994.mcz

==================== Summary ====================

Name: System-akg.994
Author: akg
Time: 8 January 2018, 3:24:14.764929 pm
UUID: ff5974b8-48a2-4d89-92af-a4fc36269edf
Ancestors: System-tpr.993

- Rename PrimitiveOSError class to PrimitiveError
- Rename #isPrimitiveOSError to #isPrimitiveError

PrimitiveError holds an errorName that indicates what type of error it is, e.g. an OS error, thus the class doesn't need the "OS" in the name.

=============== Diff against System-tpr.993 ===============

Item was added:
+ ----- Method: Object>>isPrimitiveError (in category '*system-support') -----
+ isPrimitiveError
+ "Answer a boolean indicating if the receiver is an error object returned by a primitive"
+ ^false!

Item was removed:
- ----- Method: Object>>isPrimitiveOSError (in category '*System-Support-error handling') -----
- isPrimitiveOSError
- ^false!

Item was added:
+ Object subclass: #PrimitiveError
+ instanceVariableNames: 'errorName errorCode'
+ classVariableNames: ''
+ poolDictionaries: ''
+ category: 'System-Support'!
+
+ !PrimitiveError commentStamp: 'akg 1/8/2018 15:09' prior: 0!
+ A PrimitiveError is used to answer a primitive failure code that has an associated operating system/library error.
+
+ Instance Variables
+ errorName: <Symbol>
+ errorCode: <Integer>
+
+ errorName
+ - typically #'operating system error'
+
+ errorCode
+ - the value of the error, a signed 64-bit value, a representation imposed by the VM; specific clients must map this error value into an unsigned value as appropriate if required
+
+ Typical usage is shown in the ficticious method below:
+
+ primitiveOperation
+ <primitive: 'primitiveOperation' module: 'APlugin' error: error>
+ ^(error isPrimitiveError)
+ ifTrue: [ self processErrorCode: error errorCode ]
+ ifFalse: [ self primitiveFailed ].!

Item was added:
+ ----- Method: PrimitiveError>>errorCode (in category 'accessing') -----
+ errorCode
+
+ ^errorCode!

Item was added:
+ ----- Method: PrimitiveError>>errorCode: (in category 'accessing') -----
+ errorCode: anInteger
+
+ errorCode := anInteger!

Item was added:
+ ----- Method: PrimitiveError>>errorName (in category 'accessing') -----
+ errorName
+
+ ^errorName!

Item was added:
+ ----- Method: PrimitiveError>>errorName: (in category 'accessing') -----
+ errorName: aSymbol
+
+ errorName := aSymbol!

Item was added:
+ ----- Method: PrimitiveError>>isPrimitiveError (in category 'testing') -----
+ isPrimitiveError
+ "Answer a boolean indicating if the receiver is an error object returned by a primitive"
+ ^true!

Item was removed:
- Object subclass: #PrimitiveOSError
- instanceVariableNames: 'errorName errorCode'
- classVariableNames: ''
- poolDictionaries: ''
- category: 'System-Support'!
-
- !PrimitiveOSError commentStamp: 'eem 12/7/2017 19:31' prior: 0!
- A PrimitiveOSError is used to answer a primitive failure code that has an associated operating system/library error.
-
- Instance Variables
- errorName: <Symbol>
- errorValue: <Integer>
-
- errorName
- - typically #'operating system error'
-
- errorValue
- - the value of the error, a signed 64-bit value, a representation imposed by the VM; specific clients must map this error value into an unsigned value as appropriate if required!

Item was removed:
- ----- Method: PrimitiveOSError>>errorCode (in category 'accessing') -----
- errorCode
-
- ^errorCode!

Item was removed:
- ----- Method: PrimitiveOSError>>errorCode: (in category 'accessing') -----
- errorCode: anObject
-
- errorCode := anObject!

Item was removed:
- ----- Method: PrimitiveOSError>>errorName (in category 'accessing') -----
- errorName
-
- ^errorName!

Item was removed:
- ----- Method: PrimitiveOSError>>errorName: (in category 'accessing') -----
- errorName: anObject
-
- errorName := anObject!

Item was removed:
- ----- Method: PrimitiveOSError>>isPrimitiveOSError (in category 'testing') -----
- isPrimitiveOSError
- ^true!

Item was changed:
  ----- Method: SmalltalkImage>>recreateSpecialObjectsArray (in category 'special objects') -----
  recreateSpecialObjectsArray
  "Smalltalk recreateSpecialObjectsArray"
 
  "To external package developers:
  **** DO NOT OVERRIDE THIS METHOD.  *****
  If you are writing a plugin and need additional special object(s) for your own use,
  use addGCRoot() function and use own, separate special objects registry "
 
  "The Special Objects Array is an array of objects used by the Squeak virtual machine.
  Its contents are critical and accesses to it by the VM are unchecked, so don't even
  think of playing here unless you know what you are doing."
  | newArray |
  newArray := Array new: 60.
  "Nil false and true get used throughout the VM"
  newArray at: 1 put: nil.
  newArray at: 2 put: false.
  newArray at: 3 put: true.
  "This association holds the active process (a ProcessScheduler)"
  newArray at: 4 put: (self specialObjectsArray at: 4) "(self bindingOf: #Processor) but it answers an Alias".
  "Numerous classes below used for type checking and instantiation"
  newArray at: 5 put: Bitmap.
  newArray at: 6 put: SmallInteger.
  newArray at: 7 put: ByteString.
  newArray at: 8 put: Array.
  newArray at: 9 put: Smalltalk.
  newArray at: 10 put: BoxedFloat64.
  newArray at: 11 put: (self globals at: #Context).
  newArray at: 12 put: nil. "was BlockContext."
  newArray at: 13 put: Point.
  newArray at: 14 put: LargePositiveInteger.
  newArray at: 15 put: Display.
  newArray at: 16 put: Message.
  newArray at: 17 put: CompiledMethod.
  newArray at: 18 put: ((self specialObjectsArray at: 18) ifNil: [Semaphore new]). "low space Semaphore"
  newArray at: 19 put: Semaphore.
  newArray at: 20 put: Character.
  newArray at: 21 put: #doesNotUnderstand:.
  newArray at: 22 put: #cannotReturn:.
  newArray at: 23 put: nil. "This is the process signalling low space."
  "An array of the 32 selectors that are compiled as special bytecodes,
  paired alternately with the number of arguments each takes."
  newArray at: 24 put: #( #+ 1 #- 1 #< 1 #> 1 #<= 1 #>= 1 #= 1 #~= 1
  #* 1 #/ 1 #\\ 1 #@ 1 #bitShift: 1 #// 1 #bitAnd: 1 #bitOr: 1
  #at: 1 #at:put: 2 #size 0 #next 0 #nextPut: 1 #atEnd 0 #== 1 #class 0
  #~~ 1 #value 0 #value: 1 #do: 1 #new 0 #new: 1 #x 0 #y 0 ).
  "An array of the 255 Characters in ascii order.
  Cog inlines table into machine code at: prim so do not regenerate it.
  This is nil in Spur, which has immediate Characters."
  newArray at: 25 put: (self specialObjectsArray at: 25).
  newArray at: 26 put: #mustBeBoolean.
  newArray at: 27 put: ByteArray.
  newArray at: 28 put: Process.
  "An array of up to 31 classes whose instances will have compact headers; an empty array in Spur"
  newArray at: 29 put: self compactClassesArray.
  newArray at: 30 put: ((self specialObjectsArray at: 30) ifNil: [Semaphore new]). "delay Semaphore"
  newArray at: 31 put: ((self specialObjectsArray at: 31) ifNil: [Semaphore new]). "user interrupt Semaphore"
  "Entries 32 - 34 unreferenced. Previously these contained prototype instances to be copied for fast initialization"
  newArray at: 32 put: nil. "was the prototype Float"
  newArray at: 33 put: nil. "was the prototype 4-byte LargePositiveInteger"
  newArray at: 34 put: nil. "was the prototype Point"
  newArray at: 35 put: #cannotInterpret:.
  newArray at: 36 put: nil. "was the prototype MethodContext"
  newArray at: 37 put: BlockClosure.
  newArray at: 38 put: nil. "was the prototype BlockContext"
  "array of objects referred to by external code"
  newArray at: 39 put: (self specialObjectsArray at: 39). "external semaphores"
  newArray at: 40 put: nil. "Reserved for Mutex in Cog VMs"
  newArray at: 41 put: ((self specialObjectsArray at: 41) ifNil: [LinkedList new]). "Reserved for a LinkedList instance for overlapped calls in CogMT"
  newArray at: 42 put: ((self specialObjectsArray at: 42) ifNil: [Semaphore new]). "finalization Semaphore"
  newArray at: 43 put: LargeNegativeInteger.
  "External objects for callout.
  Note: Written so that one can actually completely remove the FFI."
  newArray at: 44 put: (self at: #ExternalAddress ifAbsent: []).
  newArray at: 45 put: (self at: #ExternalStructure ifAbsent: []).
  newArray at: 46 put: (self at: #ExternalData ifAbsent: []).
  newArray at: 47 put: (self at: #ExternalFunction ifAbsent: []).
  newArray at: 48 put: (self at: #ExternalLibrary ifAbsent: []).
  newArray at: 49 put: #aboutToReturn:through:.
  newArray at: 50 put: #run:with:in:.
  "51 reserved for immutability message"
  newArray at: 51 put: #attemptToAssign:withIndex:.
  newArray at: 52 put: #(nil "nil => generic error" #'bad receiver'
  #'bad argument' #'bad index'
  #'bad number of arguments'
  #'inappropriate operation'  #'unsupported operation'
  #'no modification' #'insufficient object memory'
  #'insufficient C memory' #'not found' #'bad method'
  #'internal error in named primitive machinery'
  #'object may move' #'resource limit exceeded'
  #'object is pinned' #'primitive write beyond end of object'
  #'object moved' #'object not pinned' #'callback error'),
+ {PrimitiveError new errorName: #'operating system error'; yourself}.
- {PrimitiveOSError new errorName: #'operating system error'; yourself}.
  "53 to 55 are for Alien"
  newArray at: 53 put: (self at: #Alien ifAbsent: []).
  newArray at: 54 put: #invokeCallbackContext:. "use invokeCallback:stack:registers:jmpbuf: for old Alien callbacks."
  newArray at: 55 put: (self at: #UnsafeAlien ifAbsent: []).
 
  "Used to be WeakFinalizationList for WeakFinalizationList hasNewFinalization, obsoleted by ephemeron support."
  newArray at: 56 put: nil.
 
  "reserved for foreign callback process"
  newArray at: 57 put: (self specialObjectsArray at: 57 ifAbsent: []).
 
  newArray at: 58 put: #unusedBytecode.
  "59 reserved for Sista counter tripped message"
  newArray at: 59 put: #conditionalBranchCounterTrippedOn:.
  "60 reserved for Sista class trap message"
  newArray at: 60 put: #classTrapFor:.
 
  "Now replace the virtual machine's reference in one atomic operation"
  self specialObjectsArray becomeForward: newArray!