The Inbox: System-ct.1112.mcz

Am 03.10.2019 01:01:16 schrieb [hidden email] <[hidden email]>:

A new version of System was added to project The Inbox:
http://source.squeak.org/inbox/System-ct.1112.mcz

==================== Summary ====================

Name: System-ct.1112
Author: ct
Time: 3 October 2019, 1:00:59.749083 am
UUID: 46296c5c-1bbf-8849-96ad-70af15677f55
Ancestors: System-pre.1111

Recategorizes Smalltalk startup + shutdown list methods

=============== Diff against System-pre.1111 ===============

Item was changed:
+ ----- Method: SmalltalkImage>>add:toList:after: (in category 'startup + shutdown list') -----
- ----- Method: SmalltalkImage>>add:toList:after: (in category 'startup list') -----
add: aClass toList: startUpOrShutDownList after: predecessor
"Add the name of aClass to the startUp or shutDown list.
Add it after the name of predecessor"

(Smalltalk globals includes: aClass)
ifFalse: [self error: aClass name , ' cannot be found in Smalltalk dictionary.'].

"Add after predecessor, moving it if already there."
(Smalltalk globals includes: predecessor)
ifFalse: [self error: predecessor name , ' cannot be found in Smalltalk dictionary.'].
(startUpOrShutDownList includes: predecessor name)
ifFalse: [self error: predecessor name , ' cannot be found in the list.'].
startUpOrShutDownList remove: aClass name ifAbsent:[].
startUpOrShutDownList add: aClass name after: predecessor name!

Item was changed:
+ ----- Method: SmalltalkImage>>add:toList:before: (in category 'startup + shutdown list') -----
- ----- Method: SmalltalkImage>>add:toList:before: (in category 'startup list') -----
add: aClass toList: startUpOrShutDownList before: successor
"Add the name of aClass to the startUp or shutDown list.
Add it before the name of successor"

(Smalltalk globals includes: aClass)
ifFalse: [self error: aClass name , ' cannot be found in Smalltalk dictionary.'].

"Add before successor, moving it if already there."
(Smalltalk globals includes: successor)
ifFalse: [self error: successor name , ' cannot be found in Smalltalk dictionary.'].
(startUpOrShutDownList includes: successor name)
ifFalse: [self error: successor name , ' cannot be found in the list.'].
startUpOrShutDownList remove: aClass name ifAbsent: [].
startUpOrShutDownList add: aClass name before: successor name.!

Item was changed:
+ ----- Method: SmalltalkImage>>addToShutDownList: (in category 'startup + shutdown list') -----
- ----- Method: SmalltalkImage>>addToShutDownList: (in category 'startup list') -----
addToShutDownList: aClass
"This will add a ref to this class at the BEGINNING of the shutDown list."
"No-op if already in the list."

(ShutDownList includes: aClass name) ifFalse: [ShutDownList addFirst: aClass name]!

Item was changed:
+ ----- Method: SmalltalkImage>>addToShutDownList:before: (in category 'startup + shutdown list') -----
- ----- Method: SmalltalkImage>>addToShutDownList:before: (in category 'startup list') -----
addToShutDownList: aClass before: predecessor

self add: aClass toList: ShutDownList before: predecessor!

Item was changed:
+ ----- Method: SmalltalkImage>>addToStartUpList: (in category 'startup + shutdown list') -----
- ----- Method: SmalltalkImage>>addToStartUpList: (in category 'startup list') -----
addToStartUpList: aClass
"This will add a ref to this class at the END of the startUp list."
"No-op if already in the list."

(StartUpList includes: aClass name) ifFalse: [StartUpList addLast: aClass name]!

Item was changed:
+ ----- Method: SmalltalkImage>>addToStartUpList:before: (in category 'startup + shutdown list') -----
- ----- Method: SmalltalkImage>>addToStartUpList:before: (in category 'startup list') -----
addToStartUpList: aClass before: predecessor

self add: aClass toList: StartUpList before: predecessor!

Item was changed:
+ ----- Method: SmalltalkImage>>removeFromShutDownList: (in category 'startup + shutdown list') -----
- ----- Method: SmalltalkImage>>removeFromShutDownList: (in category 'snapshot and quit') -----
removeFromShutDownList: aClass

ShutDownList remove: aClass name ifAbsent: []!

Item was changed:
+ ----- Method: SmalltalkImage>>removeFromStartUpList: (in category 'startup + shutdown list') -----
- ----- Method: SmalltalkImage>>removeFromStartUpList: (in category 'snapshot and quit') -----
removeFromStartUpList: aClass

StartUpList remove: aClass name ifAbsent: []!

I think this is quite minor, but I'd agree with any "&", too. Just wanted to move similar things into one protocol :)