Smalltalk › Squeak › Squeak - Dev

The Inbox: System-ct.1129.mcz

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

3 messages Options

commits-2

The Inbox: System-ct.1129.mcz

A new version of System was added to project The Inbox:
http://source.squeak.org/inbox/System-ct.1129.mcz

==================== Summary ====================

Name: System-ct.1129
Author: ct
Time: 14 December 2019, 3:15:31.775612 pm
UUID: cfe4fdea-f1a2-f043-8a53-43461a9dbf28
Ancestors: System-mt.1127

Restore display after leaving emergency evaluator

=============== Diff against System-mt.1127 ===============

Item was changed:
----- Method: Transcripter class>>emergencyEvaluator (in category 'utilities') -----
emergencyEvaluator
+ "Transcripter emergencyEvaluator"
+ (self newInFrame: (0@0 corner: 320@200))
- (Transcripter newInFrame: (0@0 corner: 320@200))
show: 'Type ''revert'' to revert your last method change.
Type ''exit'' to exit the emergency evaluator.';
+ readEvalPrint.
+ Display restore.!
- readEvalPrint!

marcel.taeumel

Re: The Inbox: System-ct.1129.mcz

Hmm... not sure about this. The current "package" is as follows:

Project >> #primitiveError:

Project class >> #tryEmergencyEvaluatorForRecovery:

Transcripter >> #emergencyEvaluator

As you can see, there is already the correct call "Project current restoreDisplay" in #primitiveError:. That restoring depends on the current GUI framework.

I experiment with the EE via "self primitiveError: nil".

Best,

Marcel

Am 15.12.2019 12:15:26 schrieb [hidden email] <[hidden email]>:
A new version of System was added to project The Inbox:
http://source.squeak.org/inbox/System-ct.1129.mcz

==================== Summary ====================

Name: System-ct.1129
Author: ct
Time: 14 December 2019, 3:15:31.775612 pm
UUID: cfe4fdea-f1a2-f043-8a53-43461a9dbf28
Ancestors: System-mt.1127

Restore display after leaving emergency evaluator

=============== Diff against System-mt.1127 ===============

Item was changed:
----- Method: Transcripter class>>emergencyEvaluator (in category 'utilities') -----
emergencyEvaluator
+ "Transcripter emergencyEvaluator"
+ (self newInFrame: (0@0 corner: 320@200))
- (Transcripter newInFrame: (0@0 corner: 320@200))
show: 'Type ''revert'' to revert your last method change.
Type ''exit'' to exit the emergency evaluator.';
+ readEvalPrint.
+ Display restore.!
- readEvalPrint!

Christoph Thiede

Re: The Inbox: System-ct.1129.mcz

Ah, I had opened the EE via "Transcripter emergencyEvaluator". It would be great if it worked "clean" also in standalone mode.

How expensive is one display restauration? Can't we just call [Project current restoreDisplay] in #emergencyEvaluator?

Best,

Christoph

Von: Squeak-dev <[hidden email]> im Auftrag von Taeumel, Marcel
Gesendet: Montag, 16. Dezember 2019 19:53:26
An: John Pfersich via Squeak-dev
Betreff: Re: [squeak-dev] The Inbox: System-ct.1129.mcz

Hmm... not sure about this. The current "package" is as follows:

Project >> #primitiveError:

Project class >> #tryEmergencyEvaluatorForRecovery:

Transcripter >> #emergencyEvaluator

As you can see, there is already the correct call "Project current restoreDisplay" in #primitiveError:. That restoring depends on the current GUI framework.

I experiment with the EE via "self primitiveError: nil".

Best,

Marcel

Am 15.12.2019 12:15:26 schrieb [hidden email] <[hidden email]>:

A new version of System was added to project The Inbox:
http://source.squeak.org/inbox/System-ct.1129.mcz

==================== Summary ====================

Name: System-ct.1129
Author: ct
Time: 14 December 2019, 3:15:31.775612 pm
UUID: cfe4fdea-f1a2-f043-8a53-43461a9dbf28
Ancestors: System-mt.1127

Restore display after leaving emergency evaluator

=============== Diff against System-mt.1127 ===============

Item was changed:
----- Method: Transcripter class>>emergencyEvaluator (in category 'utilities') -----
emergencyEvaluator
+ "Transcripter emergencyEvaluator"
+ (self newInFrame: (0@0 corner: 320@200))
- (Transcripter newInFrame: (0@0 corner: 320@200))
show: 'Type ''revert'' to revert your last method change.
Type ''exit'' to exit the emergency evaluator.';
+ readEvalPrint.
+ Display restore.!
- readEvalPrint!

Carpe Squeak!